Commit Graph

140 Commits

Author SHA1 Message Date
Frédéric Mangano-Tarumi
d1299360de smart ot::file handle 2018-11-24 11:33:04 -05:00
Frédéric Mangano-Tarumi
bfa46273b9 fix ot::read_comments when handling empty lines 2018-11-24 11:33:04 -05:00
Frédéric Mangano-Tarumi
26411d3843 t: test ot::read_comments 2018-11-24 11:33:04 -05:00
Frédéric Mangano-Tarumi
af61b01448 substitute the @-markers in the man page 2018-11-21 21:41:55 -05:00
Frédéric Mangano-Tarumi
a043e74e14 review the user doc 2018-11-21 21:40:08 -05:00
Frédéric Mangano-Tarumi
20dc8d0fa2 add a changelog 2018-11-21 21:02:42 -05:00
Frédéric Mangano-Tarumi
407c12c7ac review the overall code documentation 2018-11-19 19:23:11 -05:00
Frédéric Mangano-Tarumi
8949094203 run: return better status 2018-11-18 11:43:45 -05:00
Frédéric Mangano-Tarumi
ddb838ac81 process: return better errors 2018-11-18 11:43:29 -05:00
Frédéric Mangano-Tarumi
62d56aafff accompany returned status codes with a message 2018-11-18 11:04:11 -05:00
Frédéric Mangano-Tarumi
b9a0ece567 include the error message in ot::status 2018-11-18 10:42:27 -05:00
Frédéric Mangano-Tarumi
5445c5bc7c t: test the ogg writer 2018-11-18 10:15:49 -05:00
Frédéric Mangano-Tarumi
cc83a438ae t: tests for ogg_reader 2018-11-18 09:45:11 -05:00
Frédéric Mangano-Tarumi
6ed0326a74 t: copy gobble.opus to the binary directory 2018-11-18 09:34:22 -05:00
Frédéric Mangano-Tarumi
0980b35ecd polish the interface of the opus module 2018-11-17 17:34:51 -05:00
Frédéric Mangano-Tarumi
2670b661a8 don't create null ogg writers 2018-11-17 17:17:59 -05:00
Frédéric Mangano-Tarumi
c604fdb667 encapsulate ogg_writer 2018-11-17 17:07:14 -05:00
Frédéric Mangano-Tarumi
8334a5617f polish ogg_reader 2018-11-17 16:10:20 -05:00
Frédéric Mangano-Tarumi
cdd591c0c1 really close the files before moving them 2018-11-17 15:40:57 -05:00
Frédéric Mangano-Tarumi
e22a1d381a hide the reader's stream in the ogg module 2018-11-16 19:10:14 -05:00
Frédéric Mangano-Tarumi
121220ea05 rewrite run with RAII in mind 2018-11-16 18:29:40 -05:00
Frédéric Mangano-Tarumi
b6c7a90d92 move run into the cli module
Now the code has been wholly reorganized!
2018-11-14 20:15:30 -05:00
Frédéric Mangano-Tarumi
2e88bdc207 t: cli.t -> opustags.t
It reflects the module it tests.
2018-11-14 19:56:51 -05:00
Frédéric Mangano-Tarumi
22bfd05b36 move the main loop to ot::process 2018-11-14 19:56:23 -05:00
Frédéric Mangano-Tarumi
8a5b80e075 process_tags function in the main module 2018-11-14 18:51:04 -05:00
Frédéric Mangano-Tarumi
e41cf918d1 RAII interface for dynamic ogg packets 2018-11-13 20:46:30 -05:00
Frédéric Mangano-Tarumi
82ff7f7751 validate_identification_header: take the ogg_packet 2018-11-13 18:51:28 -05:00
Frédéric Mangano-Tarumi
351d6149c9 identification header check in opus.cc 2018-11-13 18:45:44 -05:00
Frédéric Mangano-Tarumi
9ed2b82b4a error: static assertion of the list of messages 2018-11-13 18:35:34 -05:00
Frédéric Mangano-Tarumi
1866dbd1f0 call stderror for ot::status:standard_error 2018-11-13 18:15:43 -05:00
Frédéric Mangano-Tarumi
5ff99b620c ot::error_message 2018-11-13 18:04:26 -05:00
Frédéric Mangano-Tarumi
b0e8813be6 t: introduce tap.h 2018-11-13 18:04:08 -05:00
Frédéric Mangano-Tarumi
c17ad7853c move print_comments in cli, next to read_comments 2018-11-11 12:04:16 -05:00
Frédéric Mangano-Tarumi
632caae915 dedicated function for checking if two files are the same 2018-11-11 11:57:25 -05:00
Frédéric Mangano-Tarumi
b9dbaf1049 finish moving the argv checks to cli 2018-11-11 11:35:05 -05:00
Frédéric Mangano-Tarumi
326ae74afa t: factor opustags_binary and opustags together 2018-11-11 11:19:56 -05:00
Frédéric Mangano-Tarumi
497caaa8f3 t: simply the prototype of Perl's opustags 2018-11-11 11:12:26 -05:00
Frédéric Mangano-Tarumi
6565cb56b3 t: faithful copy without --overwrite 2018-11-11 11:01:13 -05:00
Frédéric Mangano-Tarumi
f664ed94d4 t: generate out.opus in the binary dir 2018-11-11 10:58:33 -05:00
Frédéric Mangano-Tarumi
b5dc595855 move the help and some arguments checking in cli.cc 2018-11-11 10:54:54 -05:00
Frédéric Mangano-Tarumi
bf386899ae fix a few signedness warnings 2018-11-11 10:30:48 -05:00
Frédéric Mangano-Tarumi
51a3eba093 dedicated function for set-all's parsing 2018-11-11 10:24:18 -05:00
Frédéric Mangano-Tarumi
fae547c4eb t: rename unit.t to opus.t 2018-11-10 14:07:14 -05:00
Frédéric Mangano-Tarumi
3aeb2097de cmake: factor the libogg dependency 2018-11-10 14:00:13 -05:00
Frédéric Mangano-Tarumi
132073b842 move argument parsing to cli.cc 2018-11-10 11:52:33 -05:00
Frédéric Mangano-Tarumi
2a31c5491b use std::string instead of ot::string_view
String views are cool, but let's play it safe and standard for now. The
impact on performance is insignificant, since most of the job is reading
the ogg file, not actually manipulating tags.
2018-11-10 11:30:30 -05:00
Frédéric Mangano-Tarumi
1b9bd83e8f store path_in and path_out as std::string 2018-11-10 11:24:07 -05:00
Frédéric Mangano-Tarumi
f02ff44e43 struct for the CLI arguments 2018-11-10 11:04:13 -05:00
Frédéric Mangano-Tarumi
b7f85b5fe2 main: store to_add and to_delete in std::vector 2018-11-10 10:54:21 -05:00
Frédéric Mangano-Tarumi
c338a04196 string_view: convert from std::string 2018-11-10 10:52:20 -05:00