Commit Graph

97 Commits

Author SHA1 Message Date
Frédéric Mangano-Tarumi
3aeb2097de cmake: factor the libogg dependency 2018-11-10 14:00:13 -05:00
Frédéric Mangano-Tarumi
132073b842 move argument parsing to cli.cc 2018-11-10 11:52:33 -05:00
Frédéric Mangano-Tarumi
2a31c5491b use std::string instead of ot::string_view
String views are cool, but let's play it safe and standard for now. The
impact on performance is insignificant, since most of the job is reading
the ogg file, not actually manipulating tags.
2018-11-10 11:30:30 -05:00
Frédéric Mangano-Tarumi
1b9bd83e8f store path_in and path_out as std::string 2018-11-10 11:24:07 -05:00
Frédéric Mangano-Tarumi
f02ff44e43 struct for the CLI arguments 2018-11-10 11:04:13 -05:00
Frédéric Mangano-Tarumi
b7f85b5fe2 main: store to_add and to_delete in std::vector 2018-11-10 10:54:21 -05:00
Frédéric Mangano-Tarumi
c338a04196 string_view: convert from std::string 2018-11-10 10:52:20 -05:00
Frédéric Mangano-Tarumi
0426c369be t: test --overwrite 2018-11-10 10:26:12 -05:00
Frédéric Mangano-Tarumi
74cc6038b2 t: pass opus data in stdin/stdout 2018-11-10 10:24:14 -05:00
Frédéric Mangano-Tarumi
702f86a355 ogg_reader::read_page() 2018-11-09 18:30:11 -05:00
Frédéric Mangano-Tarumi
0c4c11032f general status code enum 2018-11-09 18:28:21 -05:00
Frédéric Mangano-Tarumi
72a911c11b RAII for the stream and sync states 2018-11-09 18:00:52 -05:00
Frédéric Mangano-Tarumi
07af78519b group ogg encoding/decoding variables together 2018-11-09 17:28:03 -05:00
Frédéric Mangano-Tarumi
2905b193b1 t: trigger all the possible parse errors 2018-11-07 20:46:07 -05:00
Frédéric Mangano-Tarumi
9d3e9c20a3 make parse_tags return a precise error code 2018-11-07 20:31:08 -05:00
Frédéric Mangano-Tarumi
0b4e01c3b0 delete add_tags, it had become too simple 2018-11-06 21:14:40 -05:00
Frédéric Mangano-Tarumi
cc5896b1a0 move print_tags in the main module
That's where it belongs. The other modules are not supposed to write
anything to the console.
2018-11-06 21:07:43 -05:00
Frédéric Mangano-Tarumi
1744cab9ed string_view: expose data and size as functions
Be consistent with C++17.
2018-11-06 21:01:03 -05:00
Frédéric Mangano-Tarumi
d9b96d471d store the vendor as a string_view 2018-11-06 20:51:55 -05:00
Frédéric Mangano-Tarumi
590a6814dd delete free_tags, now useless thanks to RAII 2018-11-06 20:48:13 -05:00
Frédéric Mangano-Tarumi
7ae7a50151 store comments in a std::list 2018-11-06 20:46:34 -05:00
Frédéric Mangano-Tarumi
0df7514a83 preserve the extra data after the comments 2018-11-06 18:46:40 -05:00
Frédéric Mangano-Tarumi
bd50fb34d9 t: recode a packet with padding (fails) 2018-11-05 19:03:21 -05:00
Frédéric Mangano-Tarumi
3e77092f85 t: check that render_tags is faithful 2018-11-05 18:53:01 -05:00
Frédéric Mangano-Tarumi
a3a6cb4e36 t: check parse_tags on a simple sample 2018-11-05 18:41:14 -05:00
Frédéric Mangano-Tarumi
af988efd8a configure cmake for unit tests 2018-11-04 18:24:29 -05:00
Frédéric Mangano-Tarumi
f2a60e4220 overall documentation for opus.cc 2018-11-04 17:47:50 -05:00
Frédéric Mangano-Tarumi
002b253c06 t: safer calls to opustags 2018-11-04 14:15:49 -05:00
Frédéric Mangano-Tarumi
62ea90e5d5 t: merge tags.t and meta.t in cli.t 2018-11-04 13:15:27 -05:00
Frédéric Mangano-Tarumi
098eefe60f explicit use of the ot namespace 2018-11-03 17:25:14 -04:00
Frédéric Mangano-Tarumi
3ba7ba8166 create ogg.cc for libogg helpers 2018-11-03 17:22:31 -04:00
Frédéric Mangano-Tarumi
3c0aad169b move the opus-related functions in opus.cc 2018-11-03 17:18:15 -04:00
Frédéric Mangano-Tarumi
06520bf87e create opustags.h 2018-11-03 16:52:58 -04:00
Frédéric Mangano-Tarumi
7fb5b49b81 move the sources in src/ 2018-11-02 16:56:53 -04:00
Frédéric Mangano-Tarumi
a2eb11cbe3 make check depends on opustags 2018-10-31 18:24:58 -04:00
Frédéric Mangano-Tarumi
dd364c6262 t: check the exit code when called without options 2018-10-31 18:22:48 -04:00
Frédéric Mangano-Tarumi
a3e7624866 get the version number from the cmake project 2018-10-31 18:21:47 -04:00
Frédéric Mangano-Tarumi
65aad6f62a build the project with cmake 2018-10-30 19:14:34 -04:00
Frédéric Mangano-Tarumi
241c9b3071 t: allow running the suite from an arbitrary directory 2018-10-30 19:12:58 -04:00
Frédéric Mangano-Tarumi
dd0faa29bc don't print "no tags"
It's undesired, especially if the output is piped somewhere else.

It *could* be printed to stderr alternatively, but better not say
anything when there is nothing to say.
2018-10-30 18:29:08 -04:00
Frédéric Mangano-Tarumi
1837f0b0ec build as C++14 2018-10-30 18:28:12 -04:00
Frédéric Mangano-Tarumi
1e6698af3e t: check malformed tags 2018-10-29 18:46:37 -04:00
Frédéric Mangano-Tarumi
82d0400207 t: complex --set-all 2018-10-29 18:26:21 -04:00
Frédéric Mangano-Tarumi
24b6268d7a .gitignore 2018-10-28 20:02:38 -04:00
Frédéric Mangano-Tarumi
e91ad48c10 t: delete the temporary opus file at the end 2018-10-28 20:01:57 -04:00
Frédéric Mangano-Tarumi
9c50d7d047 t: set all, delete all, and final touches 2018-10-28 20:00:48 -04:00
Frédéric Mangano-Tarumi
3624761c7b t: complex tag editing 2018-10-28 19:56:00 -04:00
Frédéric Mangano-Tarumi
f56ade7941 delete_tags did not delete multiple tags correctly 2018-10-28 19:56:00 -04:00
Frédéric Mangano-Tarumi
15335da1f8 t: check -h too 2018-10-28 19:56:00 -04:00
Frédéric Mangano-Tarumi
2006431fa8 t: trivial manipulations 2018-10-28 18:41:26 -04:00