mirror/opustags
1
0
Fork 0
mirror of https://github.com/fmang/opustags.git synced 2025-10-16 19:00:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

StreamTagsHandler: fix done() for ALL_STREAMS

Browse Source
This commit is contained in:
rr-
2016-02-25 10:06:49 +01:00
parent e5e7952b89
commit c101041bd7
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/tags_handlers/stream_tags_handler.cc
View File

@@ -24,7 +24,7 @@ void StreamTagsHandler::list(const int streamno, const Tags &tags)
if (!relevant(streamno))
return;
list_impl(tags);
work_finished = true;
work_finished = this->streamno != ALL_STREAMS;
}
bool StreamTagsHandler::edit(const int streamno, Tags &tags)
@@ -32,7 +32,7 @@ bool StreamTagsHandler::edit(const int streamno, Tags &tags)
if (!relevant(streamno))
return false;
const auto ret = edit_impl(tags);
work_finished = true;
work_finished = this->streamno != ALL_STREAMS;
return ret;
}

6
tests/tags_handlers/stream_tags_handler_test.cc
View File

@@ -78,9 +78,15 @@ TEST_CASE("Stream-based tags handler test")
}
SECTION("Any stream") {
Tags dummy_tags;
DummyTagsHandler handler(StreamTagsHandler::ALL_STREAMS);
REQUIRE(handler.relevant(1));
REQUIRE(handler.relevant(2));
REQUIRE(handler.relevant(3));
REQUIRE(!handler.done());
handler.list(1, dummy_tags);
REQUIRE(!handler.done());
handler.list(2, dummy_tags);
REQUIRE(!handler.done());
}
}