mirror/mihon
1
0
Fork 0
mirror of https://github.com/mihonapp/mihon.git synced 2025-10-31 14:27:57 +01:00
Code Issues Packages Projects Releases Wiki Activity

Recommendation bug fixes (#17)

Browse Source 
* Return an empty recommendations list instead of throwing an error

* Fix api response find for searched manga

* Fix spelling

Co-authored-by: she11sh0cked <she11sh0cked@users.noreply.github.com>
This commit is contained in:
she11sh0cked
2020-05-19 22:54:59 +02:00
committed by GitHub
parent ef2241e0cb
commit fd09f64fe6
1 changed files with 19 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/RecommendsPager.kt
View File

@@ -61,16 +61,12 @@ open class RecommendsPager(
throw Exception("Null Response")
}
val response = JsonParser.parseString(responseBody).obj
val results = response["results"].array
.sortedBy {
val result = response["results"].array
.find {
val title = it["title"].string
title.contains(manga.title, true)
}
val result = results.last()
val title = result["title"].string
if (!title.contains(manga.title, true)) {
return@map null
}
?: return@map null
result["mal_id"].string
}
}
@@ -170,21 +166,23 @@ open class RecommendsPager(
val data = response["data"]!!.obj
val page = data["Page"].obj
val media = page["media"].array
val results = media.sortedBy {
val synonyms = it["synonyms"].array
countOccurrence(synonyms, manga.title)
}
val result = results.last()
val title = result["title"].obj
val synonyms = result["synonyms"].array
if (
title["romaji"].nullString?.contains("", true) != true &&
title["english"].nullString?.contains("", true) != true &&
title["native"].nullString?.contains("", true) != true &&
countOccurrence(synonyms, manga.title) <= 0
) {
return@map listOf<SMangaImpl>()
val result = media.find {
val title = it["title"].obj
if (title["romaji"].nullString?.contains(manga.title, true) == true) {
return@find true
}
if (title["english"].nullString?.contains(manga.title, true) == true) {
return@find true
}
if (title["native"].nullString?.contains(manga.title, true) == true) {
return@find true
}
if (countOccurrence(it["synonyms"].array, manga.title) <= 0) {
return@find true
}
false
}
?: return@map listOf<SMangaImpl>()
val recommendations = result["recommendations"].obj
val edges = recommendations["edges"].array
edges.map {