Mod Updater: Force remove mod archives

Closes #293

.travis.yml

@@ -16,8 +16,7 @@ jobs:
         - bash -c 'shopt -s globstar; shellcheck **/*.sh'
     - &build
       stage: build
-      # set EXTRA_TAG to latest,stable when no more experimental versions for 0.17 come out
-      env: VERSION_SHORT=0.17 EXTRA_TAG=latest
+      env: VERSION_SHORT=0.17 EXTRA_TAG=latest,stable
       script:
         - ./build.sh $VERSION_SHORT
     - <<: *build

0.17/files/update-mods.sh

@@ -58,7 +58,7 @@ update_mod()
 
   if [[ $HTTP_STATUS != 200 ]]; then
     print_failure "  Download failed: Code $HTTP_STATUS."
-    rm "$MOD_DIR/$MOD_FILENAME"
+    rm -f "$MOD_DIR/$MOD_FILENAME"
     return 1
   fi
 
@@ -69,7 +69,7 @@ update_mod()
 
   if ! [[ $(sha1sum "$MOD_DIR/$MOD_FILENAME") =~ $MOD_SHA1 ]]; then
     print_failure "  SHA1 mismatch!"
-    rm "$MOD_DIR/$MOD_FILENAME"
+    rm -f "$MOD_DIR/$MOD_FILENAME"
     return 1
   fi
 
@@ -78,7 +78,7 @@ update_mod()
   for file in "$MOD_DIR/${MOD_NAME}_"*".zip"; do # wildcard does usually not work in quotes: https://unix.stackexchange.com/a/67761
     if [[ $file != $MOD_DIR/$MOD_FILENAME ]]; then
       print_success "  Deleting old version: $file"
-      rm "$file"
+      rm -f "$file"
     fi
   done
 

build.sh

@@ -38,7 +38,7 @@ else
   if [[ -n ${EXTRA_TAG:-} ]]; then
     IFS=","
     for TAG in $EXTRA_TAG; do
-      TAGS+=" -t $DOCKER_REPO:$EXTRA_TAG"
+      TAGS+=" -t $DOCKER_REPO:$TAG"
     done
   fi
 fi
@@ -55,7 +55,7 @@ fi
 # latest changes where made in the folder corosponding to the version we build, we are on master and don#t build a PR.
 if [[ $(dirname "$(git diff --name-only HEAD^)") =~ $VERSION_SHORT ]] && [[ $TRAVIS_BRANCH == master ]] && [[ $TRAVIS_PULL_REQUEST_BRANCH == "" ]] ||
   # we build a tag and we are not on master
-  [[ $VERSION == "${TRAVIS_BRANCH_VERSION:-}" ]] && [[ $TRAVIS_PULL_REQUEST_BRANCH == "" ]] ||
+  [[ $VERSION == "${TRAVIS_BRANCH_VERSION:-}" ]] && [[ ${TRAVIS_PULL_REQUEST_BRANCH:-} == "" ]] ||
   # we are not in CI
   [[ -z ${CI:-} ]]; then