ProfessionalUwU/pacserver
1
0
Fork 0
Code Issues Pull Requests 1 Releases Wiki Activity

refactor #1

Manually merged
ProfessionalUwU merged 3 commits from refactor into dev 2023-06-15 20:25:30 +02:00
Conversation 1 Commits 3 Files Changed 8 +68 -79
ProfessionalUwU commented 2023-06-15 20:12:00 +02:00
Owner
Copy Link

Major refactoring

Unit tests

Test were rewritten to conform to the tree a principle. Arrange, Act and Assert.

Code

Duplicate code was removed and merged into one method.

Formatting

Code now follows a new formatting rule. camelCase.

# Major refactoring ## Unit tests Test were rewritten to conform to the tree a principle. Arrange, Act and Assert. ## Code Duplicate code was removed and merged into one method. ## Formatting Code now follows a new formatting rule. camelCase.
ProfessionalUwU added the
Kind/Enhancement
Kind/Testing
 labels 2023-06-15 20:12:00 +02:00
AustrianToast was assigned by ProfessionalUwU 2023-06-15 20:12:00 +02:00
ProfessionalUwU self-assigned this 2023-06-15 20:12:00 +02:00
ProfessionalUwU added 2 commits 2023-06-15 20:12:00 +02:00
ProfessionalUwU requested review from AustrianToast 2023-06-15 20:12:23 +02:00
AustrianToast approved these changes 2023-06-15 20:18:55 +02:00
AustrianToast left a comment
Collaborator
Copy Link

Looks fine

Looks fine
ProfessionalUwU added 1 commit 2023-06-15 20:23:54 +02:00
ProfessionalUwU manually merged commit a03dffabb7 into dev 2023-06-15 20:25:30 +02:00
ProfessionalUwU deleted branch refactor 2023-06-16 01:28:53 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
AustrianToast
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Merge
Dev
Ready to merge into dev
Merge
Main
Ready to merge into main
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Kind/Enhancement
Kind/Testing
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees ProfessionalUwU AustrianToast
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ProfessionalUwU/pacserver#1
No description provided.
Delete Branch "refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?