Frédéric Mangano
2443490b0b
update the man page to reflect the new expectations
2016-03-07 17:16:09 +01:00
Frédéric Mangano
a96cc9c222
allow inserting already present tags
2016-03-04 15:23:07 +01:00
Frédéric Mangano
cd550d8d80
move single tag parsing outside of Tags class
2016-03-04 15:21:05 +01:00
Frédéric Mangano
4cd0e34d0d
ogg: fix wrapping loop issue for comment_count
...
since the number of remaining bytes keeps decreasing, it wouldn't cause
infinite looping, but it would allow an indefinite number of comments (more
than 2^32)
2016-03-04 15:02:17 +01:00
Frédéric Mangano
0e2b1fec9c
tests: make style uniform
2016-03-04 14:50:48 +01:00
Frédéric Mangano
817ba5cba6
actions: fix hardcoded serialno in test
...
I had originally written the tests with a different sample
2016-03-03 21:19:24 +01:00
Frédéric Mangano
20663a847f
testing actions!
...
a tough one
2016-03-03 21:14:46 +01:00
Frédéric Mangano
40bbc90786
ogg: check the validity of streams
2016-03-03 21:14:46 +01:00
Frédéric Mangano
d21517de94
ogg: test a malicious tags packet
2016-03-03 21:14:46 +01:00
Frédéric Mangano
a78906a8d4
specify TagsHandler::end_of_stream
2016-03-03 21:14:36 +01:00
rr-
32c5e2b0a6
Tags: make keys case insensitive
2016-03-03 12:30:56 +01:00
rr-
449235ed5a
Tests: add missing sample
2016-03-03 12:30:03 +01:00
rr-
661c469bd6
Tags: implement multi values, change .set to .add
2016-03-03 12:30:03 +01:00
Frédéric Mangano
7f984e1492
ogg: test multi-stream Ogg files
...
the sample is generated with this command:
ffmpeg -i mystery.ogg -i beep.ogg -c copy -map 0:0 -map 1:0 -map 0:0 -shortest mystery-beep.ogg
it should be added into the CMakeLists.txt
2016-03-02 16:08:13 +01:00
Frédéric Mangano
4f1070f272
ogg: checked the packetno of the OpusTags packet
2016-03-02 15:53:21 +01:00
Frédéric Mangano
b4dc544031
ogg: test decoding garbage
2016-03-02 15:35:36 +01:00
Frédéric Mangano
5e19657d25
test: tags keys should be case insensitive
2016-03-02 15:20:15 +01:00
Frédéric Mangano
898846f1f4
ogg: test up to tags decoding
...
and it works!
2016-03-02 15:20:05 +01:00
Frédéric Mangano
c19233236a
ogg: flush packets before paging in
2016-03-02 15:15:13 +01:00
Frédéric Mangano
84a0ce55af
proposition of logger
2016-03-02 14:44:04 +01:00
Frédéric Mangano
95ddd2e7da
some more tests for Tags
...
it needs to be a multimap
2016-03-02 14:33:45 +01:00
Frédéric Mangano
9fd629bcc3
ogg: wrong reference magic number
...
a fairy told me as I was commuting
2016-03-02 09:27:33 +01:00
Frédéric Mangano
53fbf533fb
ogg: fix memory issue using shared pointers
2016-03-01 16:24:47 +01:00
Frédéric Mangano
0e3dfbe381
forbid copy of ogg::Stream and ogg::Decoder
...
realize they cause serious memory issues
now adding a Stream to the vector doesn't typecheck…
2016-03-01 16:03:11 +01:00
Frédéric Mangano
8364667b4c
at least call the new opustags 2.x
2016-03-01 15:52:10 +01:00
Frédéric Mangano
4d9ee3bf88
ogg decoding test, along with an opus sample
2016-03-01 15:49:04 +01:00
Frédéric Mangano
f941464c61
ogg: Decoder and Encoder to use a reference rather than a pointer
2016-03-01 15:01:24 +01:00
Frédéric Mangano
f469d76e62
untested tags rendering routine draft
2016-03-01 14:37:09 +01:00
Frédéric Mangano
acbf99d276
first untested implementation of tags parsing
2016-03-01 14:08:27 +01:00
Frédéric Mangano
fe7f23576a
ogg: parse magic number
2016-03-01 13:29:01 +01:00
rr-
c101041bd7
StreamTagsHandler: fix done() for ALL_STREAMS
2016-02-25 10:06:49 +01:00
rr-
e5e7952b89
Improve CompositeTagsHandler::done()
2016-02-25 10:03:58 +01:00
rr-
221c314625
ModificationTagsHandler: small optimization
2016-02-24 23:13:16 +01:00
rr-
7b6ad95b35
Refactor Options to use TagsHandlers; add --stream
2016-02-24 22:14:21 +01:00
rr-
24c2dae49e
Add ability to target any stream in TagsHandlers
2016-02-24 22:14:15 +01:00
rr-
02c966bacb
Add getters to TagsHandlers for most things
2016-02-24 21:55:48 +01:00
rr-
4f5d33491b
RemovalTagsHandler: add ability to delete all tags
2016-02-24 21:38:24 +01:00
rr-
d9f123c84c
Add ListingTagsHandler
2016-02-24 21:25:59 +01:00
rr-
a67f8c1472
Change Tags to preserve order of insertion
2016-02-24 21:25:59 +01:00
rr-
d7b187ec59
Remove unused #include
2016-02-24 20:48:26 +01:00
rr-
fca4f81eac
Add ModificationTagsHandler
2016-02-24 20:32:03 +01:00
rr-
b362f6565f
Add RemovalTagsHandler
2016-02-24 20:18:10 +01:00
rr-
6832cbf3f5
Add InsertionTagsHandler + a place for errors
2016-02-24 20:13:38 +01:00
rr-
2ee7702b9d
Add StreamTagsHandler
2016-02-24 20:04:24 +01:00
rr-
aeca60d128
Add CompositeTagsHandler
2016-02-24 20:03:31 +01:00
rr-
1d8d96cdee
Use K&R brace style for SECTION macro in tests
2016-02-24 20:03:31 +01:00
rr-
094bed2b35
Make Tags just an string<->string map for now
2016-02-24 19:43:11 +01:00
rr-
b62ac98ca5
Move TagsHandler to own file, make an interface
2016-02-24 19:42:45 +01:00
Frédéric Mangano
12327e6f68
style fixes
...
missing newlines
nullptr instead of NULL
bracket tweak
2016-02-24 18:15:39 +01:00
rr-
326c164e09
Restyle to K&R
2016-02-24 18:10:03 +01:00