mirror of
https://github.com/Jguer/yay.git
synced 2024-11-06 17:17:22 +01:00
8916cd174b
* rework relationship between runtime and cfg * separate runtime from cfg * simplify instantiation logic * move installer to appropriate package * move operator to sync package * add tests for srcinfo service * consolidate srcinfo service in sync * add logger to srcinfo * add logger to preparer * remove unused text functions * remove remaining text.* from srcinfo * remove global logger parts * remove global org method exports * remove global logger * move text->input * add rule to prevent fmt.Print * update golangci go version * remove outdated FAQs * remove outdated FAQs
730 lines
20 KiB
Go
730 lines
20 KiB
Go
//go:build !integration
|
|
// +build !integration
|
|
|
|
package main
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
"os"
|
|
"os/exec"
|
|
"strings"
|
|
"sync"
|
|
"testing"
|
|
|
|
"github.com/Jguer/aur"
|
|
alpm "github.com/Jguer/go-alpm/v2"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/Jguer/yay/v12/pkg/db"
|
|
"github.com/Jguer/yay/v12/pkg/db/mock"
|
|
mockaur "github.com/Jguer/yay/v12/pkg/dep/mock"
|
|
"github.com/Jguer/yay/v12/pkg/runtime"
|
|
"github.com/Jguer/yay/v12/pkg/settings"
|
|
"github.com/Jguer/yay/v12/pkg/settings/exe"
|
|
"github.com/Jguer/yay/v12/pkg/settings/parser"
|
|
"github.com/Jguer/yay/v12/pkg/text"
|
|
"github.com/Jguer/yay/v12/pkg/vcs"
|
|
)
|
|
|
|
func TestSyncUpgrade(t *testing.T) {
|
|
t.Parallel()
|
|
makepkgBin := t.TempDir() + "/makepkg"
|
|
pacmanBin := t.TempDir() + "/pacman"
|
|
gitBin := t.TempDir() + "/git"
|
|
f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
|
|
require.NoError(t, err)
|
|
require.NoError(t, f.Close())
|
|
|
|
f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
|
|
require.NoError(t, err)
|
|
require.NoError(t, f.Close())
|
|
|
|
f, err = os.OpenFile(gitBin, os.O_RDONLY|os.O_CREATE, 0o755)
|
|
require.NoError(t, err)
|
|
require.NoError(t, f.Close())
|
|
|
|
captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
|
|
return "", "", nil
|
|
}
|
|
|
|
showOverride := func(cmd *exec.Cmd) error {
|
|
return nil
|
|
}
|
|
|
|
mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
|
|
cmdBuilder := &exe.CmdBuilder{
|
|
MakepkgBin: makepkgBin,
|
|
SudoBin: "su",
|
|
PacmanBin: pacmanBin,
|
|
PacmanConfigPath: "/etc/pacman.conf",
|
|
GitBin: "git",
|
|
Runner: mockRunner,
|
|
SudoLoopEnabled: false,
|
|
}
|
|
|
|
cmdArgs := parser.MakeArguments()
|
|
cmdArgs.AddArg("S")
|
|
cmdArgs.AddArg("y")
|
|
cmdArgs.AddArg("u")
|
|
|
|
dbName := mock.NewDB("core")
|
|
|
|
db := &mock.DBExecutor{
|
|
AlpmArchitecturesFn: func() ([]string, error) {
|
|
return []string{"x86_64"}, nil
|
|
},
|
|
RefreshHandleFn: func() error {
|
|
return nil
|
|
},
|
|
ReposFn: func() []string {
|
|
return []string{"core"}
|
|
},
|
|
InstalledRemotePackagesFn: func() map[string]alpm.IPackage {
|
|
return map[string]alpm.IPackage{}
|
|
},
|
|
InstalledRemotePackageNamesFn: func() []string {
|
|
return []string{}
|
|
},
|
|
SyncUpgradesFn: func(
|
|
bool,
|
|
) (map[string]db.SyncUpgrade, error) {
|
|
return map[string]db.SyncUpgrade{
|
|
"linux": {
|
|
Package: &mock.Package{
|
|
PName: "linux",
|
|
PVersion: "5.10.0",
|
|
PDB: dbName,
|
|
},
|
|
LocalVersion: "4.3.0",
|
|
Reason: alpm.PkgReasonExplicit,
|
|
},
|
|
}, nil
|
|
},
|
|
}
|
|
|
|
run := &runtime.Runtime{
|
|
Cfg: &settings.Configuration{
|
|
RemoveMake: "no",
|
|
},
|
|
Logger: text.NewLogger(io.Discard, os.Stderr, strings.NewReader("\n"), true, "test"),
|
|
CmdBuilder: cmdBuilder,
|
|
VCSStore: &vcs.Mock{},
|
|
AURClient: &mockaur.MockAUR{
|
|
GetFn: func(ctx context.Context, query *aur.Query) ([]aur.Pkg, error) {
|
|
return []aur.Pkg{}, nil
|
|
},
|
|
},
|
|
}
|
|
err = handleCmd(context.Background(), run, cmdArgs, db)
|
|
require.NoError(t, err)
|
|
|
|
wantCapture := []string{}
|
|
wantShow := []string{
|
|
"pacman -S -y --config /etc/pacman.conf --",
|
|
"pacman -S -y -u --config /etc/pacman.conf --",
|
|
}
|
|
|
|
require.Len(t, mockRunner.ShowCalls, len(wantShow))
|
|
require.Len(t, mockRunner.CaptureCalls, len(wantCapture))
|
|
|
|
for i, call := range mockRunner.ShowCalls {
|
|
show := call.Args[0].(*exec.Cmd).String()
|
|
show = strings.ReplaceAll(show, makepkgBin, "makepkg")
|
|
show = strings.ReplaceAll(show, pacmanBin, "pacman")
|
|
show = strings.ReplaceAll(show, gitBin, "pacman")
|
|
|
|
// options are in a different order on different systems and on CI root user is used
|
|
assert.Subset(t, strings.Split(show, " "), strings.Split(wantShow[i], " "), fmt.Sprintf("%d - %s", i, show))
|
|
}
|
|
}
|
|
|
|
func TestSyncUpgrade_IgnoreAll(t *testing.T) {
|
|
t.Parallel()
|
|
makepkgBin := t.TempDir() + "/makepkg"
|
|
pacmanBin := t.TempDir() + "/pacman"
|
|
gitBin := t.TempDir() + "/git"
|
|
f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
|
|
require.NoError(t, err)
|
|
require.NoError(t, f.Close())
|
|
|
|
f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
|
|
require.NoError(t, err)
|
|
require.NoError(t, f.Close())
|
|
|
|
f, err = os.OpenFile(gitBin, os.O_RDONLY|os.O_CREATE, 0o755)
|
|
require.NoError(t, err)
|
|
require.NoError(t, f.Close())
|
|
|
|
captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
|
|
return "", "", nil
|
|
}
|
|
|
|
showOverride := func(cmd *exec.Cmd) error {
|
|
return nil
|
|
}
|
|
|
|
mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
|
|
cmdBuilder := &exe.CmdBuilder{
|
|
MakepkgBin: makepkgBin,
|
|
SudoBin: "su",
|
|
PacmanBin: pacmanBin,
|
|
PacmanConfigPath: "/etc/pacman.conf",
|
|
GitBin: "git",
|
|
Runner: mockRunner,
|
|
SudoLoopEnabled: false,
|
|
}
|
|
|
|
cmdArgs := parser.MakeArguments()
|
|
cmdArgs.AddArg("S")
|
|
cmdArgs.AddArg("y")
|
|
cmdArgs.AddArg("u")
|
|
|
|
dbName := mock.NewDB("core")
|
|
|
|
db := &mock.DBExecutor{
|
|
AlpmArchitecturesFn: func() ([]string, error) {
|
|
return []string{"x86_64"}, nil
|
|
},
|
|
RefreshHandleFn: func() error {
|
|
return nil
|
|
},
|
|
ReposFn: func() []string {
|
|
return []string{"core"}
|
|
},
|
|
InstalledRemotePackagesFn: func() map[string]alpm.IPackage {
|
|
return map[string]alpm.IPackage{}
|
|
},
|
|
InstalledRemotePackageNamesFn: func() []string {
|
|
return []string{}
|
|
},
|
|
SyncUpgradesFn: func(
|
|
bool,
|
|
) (map[string]db.SyncUpgrade, error) {
|
|
return map[string]db.SyncUpgrade{
|
|
"linux": {
|
|
Package: &mock.Package{
|
|
PName: "linux",
|
|
PVersion: "5.10.0",
|
|
PDB: dbName,
|
|
},
|
|
LocalVersion: "4.3.0",
|
|
Reason: alpm.PkgReasonExplicit,
|
|
},
|
|
}, nil
|
|
},
|
|
}
|
|
|
|
run := &runtime.Runtime{
|
|
Cfg: &settings.Configuration{
|
|
RemoveMake: "no",
|
|
},
|
|
Logger: text.NewLogger(io.Discard, os.Stderr, strings.NewReader("1\n"), true, "test"),
|
|
CmdBuilder: cmdBuilder,
|
|
VCSStore: &vcs.Mock{},
|
|
AURClient: &mockaur.MockAUR{
|
|
GetFn: func(ctx context.Context, query *aur.Query) ([]aur.Pkg, error) {
|
|
return []aur.Pkg{}, nil
|
|
},
|
|
},
|
|
}
|
|
err = handleCmd(context.Background(), run, cmdArgs, db)
|
|
require.NoError(t, err)
|
|
|
|
wantCapture := []string{}
|
|
wantShow := []string{
|
|
"pacman -S -y --config /etc/pacman.conf --",
|
|
}
|
|
|
|
require.Len(t, mockRunner.ShowCalls, len(wantShow))
|
|
require.Len(t, mockRunner.CaptureCalls, len(wantCapture))
|
|
|
|
for i, call := range mockRunner.ShowCalls {
|
|
show := call.Args[0].(*exec.Cmd).String()
|
|
show = strings.ReplaceAll(show, makepkgBin, "makepkg")
|
|
show = strings.ReplaceAll(show, pacmanBin, "pacman")
|
|
show = strings.ReplaceAll(show, gitBin, "pacman")
|
|
|
|
// options are in a different order on different systems and on CI root user is used
|
|
assert.Subset(t, strings.Split(show, " "), strings.Split(wantShow[i], " "), fmt.Sprintf("%d - %s", i, show))
|
|
}
|
|
}
|
|
|
|
func TestSyncUpgrade_IgnoreOne(t *testing.T) {
|
|
t.Parallel()
|
|
makepkgBin := t.TempDir() + "/makepkg"
|
|
pacmanBin := t.TempDir() + "/pacman"
|
|
gitBin := t.TempDir() + "/git"
|
|
f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
|
|
require.NoError(t, err)
|
|
require.NoError(t, f.Close())
|
|
|
|
f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
|
|
require.NoError(t, err)
|
|
require.NoError(t, f.Close())
|
|
|
|
f, err = os.OpenFile(gitBin, os.O_RDONLY|os.O_CREATE, 0o755)
|
|
require.NoError(t, err)
|
|
require.NoError(t, f.Close())
|
|
|
|
captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
|
|
return "", "", nil
|
|
}
|
|
|
|
showOverride := func(cmd *exec.Cmd) error {
|
|
return nil
|
|
}
|
|
|
|
mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
|
|
cmdBuilder := &exe.CmdBuilder{
|
|
MakepkgBin: makepkgBin,
|
|
SudoBin: "su",
|
|
PacmanBin: pacmanBin,
|
|
PacmanConfigPath: "/etc/pacman.conf",
|
|
GitBin: "git",
|
|
Runner: mockRunner,
|
|
SudoLoopEnabled: false,
|
|
}
|
|
|
|
cmdArgs := parser.MakeArguments()
|
|
cmdArgs.AddArg("S")
|
|
cmdArgs.AddArg("y")
|
|
cmdArgs.AddArg("u")
|
|
|
|
dbName := mock.NewDB("core")
|
|
|
|
db := &mock.DBExecutor{
|
|
AlpmArchitecturesFn: func() ([]string, error) {
|
|
return []string{"x86_64"}, nil
|
|
},
|
|
RefreshHandleFn: func() error {
|
|
return nil
|
|
},
|
|
ReposFn: func() []string {
|
|
return []string{"core"}
|
|
},
|
|
InstalledRemotePackagesFn: func() map[string]alpm.IPackage {
|
|
return map[string]alpm.IPackage{}
|
|
},
|
|
InstalledRemotePackageNamesFn: func() []string {
|
|
return []string{}
|
|
},
|
|
SyncUpgradesFn: func(
|
|
bool,
|
|
) (map[string]db.SyncUpgrade, error) {
|
|
return map[string]db.SyncUpgrade{
|
|
"gcc": {
|
|
Package: &mock.Package{
|
|
PName: "gcc",
|
|
PVersion: "6.0.0",
|
|
PDB: dbName,
|
|
},
|
|
LocalVersion: "5.0.0",
|
|
Reason: alpm.PkgReasonExplicit,
|
|
},
|
|
"linux": {
|
|
Package: &mock.Package{
|
|
PName: "linux",
|
|
PVersion: "5.10.0",
|
|
PDB: dbName,
|
|
},
|
|
LocalVersion: "4.3.0",
|
|
Reason: alpm.PkgReasonExplicit,
|
|
},
|
|
"linux-headers": {
|
|
Package: &mock.Package{
|
|
PName: "linux-headers",
|
|
PVersion: "5.10.0",
|
|
PDB: dbName,
|
|
},
|
|
LocalVersion: "4.3.0",
|
|
Reason: alpm.PkgReasonDepend,
|
|
},
|
|
}, nil
|
|
},
|
|
}
|
|
|
|
run := &runtime.Runtime{
|
|
Cfg: &settings.Configuration{
|
|
RemoveMake: "no",
|
|
},
|
|
Logger: text.NewLogger(io.Discard, os.Stderr, strings.NewReader("1\n"), true, "test"),
|
|
CmdBuilder: cmdBuilder,
|
|
VCSStore: &vcs.Mock{},
|
|
AURClient: &mockaur.MockAUR{
|
|
GetFn: func(ctx context.Context, query *aur.Query) ([]aur.Pkg, error) {
|
|
return []aur.Pkg{}, nil
|
|
},
|
|
},
|
|
}
|
|
|
|
err = handleCmd(context.Background(), run, cmdArgs, db)
|
|
require.NoError(t, err)
|
|
|
|
wantCapture := []string{}
|
|
wantShow := []string{
|
|
"pacman -S -y --config /etc/pacman.conf --",
|
|
"pacman -S -y -u --config /etc/pacman.conf --ignore linux-headers --",
|
|
}
|
|
|
|
require.Len(t, mockRunner.ShowCalls, len(wantShow))
|
|
require.Len(t, mockRunner.CaptureCalls, len(wantCapture))
|
|
|
|
for i, call := range mockRunner.ShowCalls {
|
|
show := call.Args[0].(*exec.Cmd).String()
|
|
show = strings.ReplaceAll(show, makepkgBin, "makepkg")
|
|
show = strings.ReplaceAll(show, pacmanBin, "pacman")
|
|
show = strings.ReplaceAll(show, gitBin, "pacman")
|
|
|
|
// options are in a different order on different systems and on CI root user is used
|
|
assert.Subset(t, strings.Split(show, " "), strings.Split(wantShow[i], " "), fmt.Sprintf("%d - %s", i, show))
|
|
}
|
|
}
|
|
|
|
// Pinned deps with rollup
|
|
func TestSyncUpgradeAURPinnedSplitPackage(t *testing.T) {
|
|
t.Parallel()
|
|
makepkgBin := t.TempDir() + "/makepkg"
|
|
pacmanBin := t.TempDir() + "/pacman"
|
|
tmpDir := t.TempDir()
|
|
gitBin := t.TempDir() + "/git"
|
|
f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
|
|
require.NoError(t, err)
|
|
require.NoError(t, f.Close())
|
|
|
|
f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
|
|
require.NoError(t, err)
|
|
require.NoError(t, f.Close())
|
|
|
|
f, err = os.OpenFile(gitBin, os.O_RDONLY|os.O_CREATE, 0o755)
|
|
require.NoError(t, err)
|
|
require.NoError(t, f.Close())
|
|
|
|
pkgBuildDir := tmpDir + "/vosk-api"
|
|
os.Mkdir(pkgBuildDir, 0o755)
|
|
fSource, err := os.OpenFile(pkgBuildDir+"/.SRCINFO", os.O_RDWR|os.O_CREATE, 0o666)
|
|
require.NoError(t, err)
|
|
n, errF := fSource.WriteString(`pkgbase = vosk-api
|
|
pkgdesc = Offline speech recognition toolkit
|
|
pkgver = 0.3.45
|
|
pkgrel = 1
|
|
url = https://alphacephei.com/vosk/
|
|
arch = x86_64
|
|
license = Apache
|
|
|
|
pkgname = vosk-api
|
|
pkgdesc = vosk-api
|
|
|
|
pkgname = python-vosk
|
|
pkgdesc = Python module for vosk-api
|
|
depends = vosk-api=0.3.45`)
|
|
require.NoError(t, errF)
|
|
require.Greater(t, n, 0)
|
|
require.NoError(t, fSource.Close())
|
|
|
|
tars := []string{
|
|
tmpDir + "/vosk-api-0.3.45-1-x86_64.pkg.tar.zst",
|
|
tmpDir + "/python-vosk-0.3.45-1-x86_64.pkg.tar.zst",
|
|
}
|
|
|
|
captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
|
|
return strings.Join(tars, "\n"), "", nil
|
|
}
|
|
|
|
once := sync.Once{}
|
|
|
|
showOverride := func(cmd *exec.Cmd) error {
|
|
once.Do(func() {
|
|
for _, tar := range tars {
|
|
f, err := os.OpenFile(tar, os.O_RDONLY|os.O_CREATE, 0o666)
|
|
require.NoError(t, err)
|
|
require.NoError(t, f.Close())
|
|
}
|
|
})
|
|
if sanitizeCall(cmd.String(), tmpDir, makepkgBin,
|
|
pacmanBin, gitBin) == "pacman -U --config /etc/pacman.conf -- /testdir/vosk-api-0.3.45-1-x86_64.pkg.tar.zst" {
|
|
return errors.New("Unsatisfied dependency")
|
|
}
|
|
return nil
|
|
}
|
|
|
|
mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
|
|
cmdBuilder := &exe.CmdBuilder{
|
|
MakepkgBin: makepkgBin,
|
|
SudoBin: "su",
|
|
PacmanBin: pacmanBin,
|
|
PacmanConfigPath: "/etc/pacman.conf",
|
|
GitBin: "git",
|
|
Runner: mockRunner,
|
|
SudoLoopEnabled: false,
|
|
}
|
|
|
|
cmdArgs := parser.MakeArguments()
|
|
cmdArgs.AddArg("S")
|
|
cmdArgs.AddArg("y")
|
|
cmdArgs.AddArg("u")
|
|
|
|
db := &mock.DBExecutor{
|
|
AlpmArchitecturesFn: func() ([]string, error) {
|
|
return []string{"x86_64"}, nil
|
|
},
|
|
RefreshHandleFn: func() error {
|
|
return nil
|
|
},
|
|
ReposFn: func() []string {
|
|
return []string{"core"}
|
|
},
|
|
SyncSatisfierFn: func(s string) mock.IPackage {
|
|
return nil
|
|
},
|
|
InstalledRemotePackagesFn: func() map[string]alpm.IPackage {
|
|
return map[string]alpm.IPackage{
|
|
"vosk-api": &mock.Package{
|
|
PName: "vosk-api",
|
|
PVersion: "0.3.43-1",
|
|
PBase: "vosk-api",
|
|
PReason: alpm.PkgReasonDepend,
|
|
},
|
|
"python-vosk": &mock.Package{
|
|
PName: "python-vosk",
|
|
PVersion: "0.3.43-1",
|
|
PBase: "python-vosk",
|
|
PReason: alpm.PkgReasonExplicit,
|
|
// TODO: fix mock Depends
|
|
},
|
|
}
|
|
},
|
|
InstalledRemotePackageNamesFn: func() []string {
|
|
return []string{"vosk-api", "python-vosk"}
|
|
},
|
|
LocalSatisfierExistsFn: func(s string) bool {
|
|
return false
|
|
},
|
|
SyncUpgradesFn: func(
|
|
bool,
|
|
) (map[string]db.SyncUpgrade, error) {
|
|
return map[string]db.SyncUpgrade{}, nil
|
|
},
|
|
}
|
|
|
|
run := &runtime.Runtime{
|
|
Cfg: &settings.Configuration{
|
|
DoubleConfirm: true,
|
|
RemoveMake: "no",
|
|
BuildDir: tmpDir,
|
|
},
|
|
Logger: text.NewLogger(io.Discard, os.Stderr, strings.NewReader("\n\n\n\n"), true, "test"),
|
|
CmdBuilder: cmdBuilder,
|
|
VCSStore: &vcs.Mock{},
|
|
AURClient: &mockaur.MockAUR{
|
|
GetFn: func(ctx context.Context, query *aur.Query) ([]aur.Pkg, error) {
|
|
return []aur.Pkg{
|
|
{
|
|
Name: "vosk-api",
|
|
PackageBase: "vosk-api",
|
|
Version: "0.3.45-1",
|
|
},
|
|
{
|
|
Name: "python-vosk",
|
|
PackageBase: "vosk-api",
|
|
Version: "0.3.45-1",
|
|
Depends: []string{
|
|
"vosk-api=0.3.45",
|
|
},
|
|
},
|
|
}, nil
|
|
},
|
|
},
|
|
}
|
|
|
|
err = handleCmd(context.Background(), run, cmdArgs, db)
|
|
require.NoError(t, err)
|
|
|
|
wantCapture := []string{
|
|
"/usr/bin/git -C /testdir/vosk-api reset --hard HEAD",
|
|
"/usr/bin/git -C /testdir/vosk-api merge --no-edit --ff",
|
|
"makepkg --packagelist", "makepkg --packagelist",
|
|
"makepkg --packagelist",
|
|
}
|
|
wantShow := []string{
|
|
"pacman -S -y --config /etc/pacman.conf --",
|
|
"makepkg --verifysource --skippgpcheck -Ccf", "makepkg --nobuild -fC --ignorearch",
|
|
"makepkg -c --nobuild --noextract --ignorearch",
|
|
"pacman -U --config /etc/pacman.conf -- /testdir/vosk-api-0.3.45-1-x86_64.pkg.tar.zst",
|
|
"makepkg --nobuild -fC --ignorearch", "makepkg -c --nobuild --noextract --ignorearch",
|
|
"makepkg --nobuild -fC --ignorearch", "makepkg -c --nobuild --noextract --ignorearch",
|
|
"pacman -U --config /etc/pacman.conf -- /testdir/vosk-api-0.3.45-1-x86_64.pkg.tar.zst /testdir/python-vosk-0.3.45-1-x86_64.pkg.tar.zst",
|
|
"pacman -D -q --asdeps --config /etc/pacman.conf -- vosk-api",
|
|
"pacman -D -q --asexplicit --config /etc/pacman.conf -- python-vosk",
|
|
}
|
|
|
|
require.Len(t, mockRunner.ShowCalls, len(wantShow),
|
|
fmt.Sprintf("%#v", sanitizeCalls(mockRunner.ShowCalls, tmpDir, makepkgBin, pacmanBin, gitBin)))
|
|
require.Len(t, mockRunner.CaptureCalls, len(wantCapture),
|
|
fmt.Sprintf("%#v", sanitizeCalls(mockRunner.CaptureCalls, tmpDir, makepkgBin, pacmanBin, gitBin)))
|
|
|
|
for i, call := range mockRunner.ShowCalls {
|
|
show := call.Args[0].(*exec.Cmd).String()
|
|
show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
|
|
show = strings.ReplaceAll(show, makepkgBin, "makepkg")
|
|
show = strings.ReplaceAll(show, pacmanBin, "pacman")
|
|
show = strings.ReplaceAll(show, gitBin, "pacman")
|
|
|
|
// options are in a different order on different systems and on CI root user is used
|
|
assert.Subset(t, strings.Split(show, " "), strings.Split(wantShow[i], " "), fmt.Sprintf("%d - %s", i, show))
|
|
}
|
|
}
|
|
|
|
func sanitizeCalls(calls []exe.Call, tmpDir, makepkg, pacman, git string) []string {
|
|
san := make([]string, 0, len(calls))
|
|
for _, c := range calls {
|
|
s := c.Args[0].(*exec.Cmd).String()
|
|
san = append(san, sanitizeCall(s, tmpDir, makepkg, pacman, git))
|
|
}
|
|
|
|
return san
|
|
}
|
|
|
|
func sanitizeCall(s, tmpDir, makepkg, pacman, git string) string {
|
|
_, after, found := strings.Cut(s, makepkg)
|
|
if found {
|
|
s = "makepkg" + after
|
|
}
|
|
|
|
_, after, found = strings.Cut(s, pacman)
|
|
if found {
|
|
s = "pacman" + after
|
|
}
|
|
|
|
_, after, found = strings.Cut(s, git)
|
|
if found {
|
|
s = "git" + after
|
|
}
|
|
|
|
s = strings.ReplaceAll(s, tmpDir, "/testdir")
|
|
|
|
return s
|
|
}
|
|
|
|
func TestSyncUpgrade_NoCombinedUpgrade(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
testCases := []struct {
|
|
name string
|
|
combinedUpgrade bool
|
|
want []string
|
|
}{
|
|
{
|
|
name: "combined upgrade",
|
|
combinedUpgrade: true,
|
|
want: []string{"pacman -S -y -u --config /etc/pacman.conf --"},
|
|
},
|
|
{
|
|
name: "no combined upgrade",
|
|
combinedUpgrade: false,
|
|
want: []string{"pacman -S -y --config /etc/pacman.conf --"},
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
tc := tc
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
makepkgBin := t.TempDir() + "/makepkg"
|
|
pacmanBin := t.TempDir() + "/pacman"
|
|
gitBin := t.TempDir() + "/git"
|
|
f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
|
|
require.NoError(t, err)
|
|
require.NoError(t, f.Close())
|
|
|
|
f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
|
|
require.NoError(t, err)
|
|
require.NoError(t, f.Close())
|
|
|
|
f, err = os.OpenFile(gitBin, os.O_RDONLY|os.O_CREATE, 0o755)
|
|
require.NoError(t, err)
|
|
require.NoError(t, f.Close())
|
|
|
|
captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
|
|
return "", "", nil
|
|
}
|
|
|
|
showOverride := func(cmd *exec.Cmd) error {
|
|
return nil
|
|
}
|
|
|
|
mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
|
|
cmdBuilder := &exe.CmdBuilder{
|
|
MakepkgBin: makepkgBin,
|
|
SudoBin: "su",
|
|
PacmanBin: pacmanBin,
|
|
PacmanConfigPath: "/etc/pacman.conf",
|
|
GitBin: "git",
|
|
Runner: mockRunner,
|
|
SudoLoopEnabled: false,
|
|
}
|
|
|
|
cmdArgs := parser.MakeArguments()
|
|
cmdArgs.AddArg("S")
|
|
cmdArgs.AddArg("y")
|
|
cmdArgs.AddArg("u")
|
|
|
|
db := &mock.DBExecutor{
|
|
AlpmArchitecturesFn: func() ([]string, error) {
|
|
return []string{"x86_64"}, nil
|
|
},
|
|
RefreshHandleFn: func() error {
|
|
return nil
|
|
},
|
|
ReposFn: func() []string {
|
|
return []string{"core"}
|
|
},
|
|
InstalledRemotePackagesFn: func() map[string]alpm.IPackage {
|
|
return map[string]alpm.IPackage{}
|
|
},
|
|
InstalledRemotePackageNamesFn: func() []string {
|
|
return []string{}
|
|
},
|
|
SyncUpgradesFn: func(
|
|
bool,
|
|
) (map[string]db.SyncUpgrade, error) {
|
|
return map[string]db.SyncUpgrade{}, nil
|
|
},
|
|
}
|
|
|
|
run := &runtime.Runtime{
|
|
Cfg: &settings.Configuration{
|
|
RemoveMake: "no",
|
|
CombinedUpgrade: false,
|
|
},
|
|
Logger: text.NewLogger(io.Discard, os.Stderr, strings.NewReader("1\n"), true, "test"),
|
|
CmdBuilder: cmdBuilder,
|
|
VCSStore: &vcs.Mock{},
|
|
AURClient: &mockaur.MockAUR{
|
|
GetFn: func(ctx context.Context, query *aur.Query) ([]aur.Pkg, error) {
|
|
return []aur.Pkg{}, nil
|
|
},
|
|
},
|
|
}
|
|
|
|
err = handleCmd(context.Background(), run, cmdArgs, db)
|
|
require.NoError(t, err)
|
|
|
|
require.Len(t, mockRunner.ShowCalls, len(tc.want))
|
|
require.Len(t, mockRunner.CaptureCalls, 0)
|
|
|
|
for i, call := range mockRunner.ShowCalls {
|
|
show := call.Args[0].(*exec.Cmd).String()
|
|
show = strings.ReplaceAll(show, pacmanBin, "pacman")
|
|
|
|
// options are in a different order on different systems and on CI root user is used
|
|
assert.Subset(t, strings.Split(show, " "), strings.Split(tc.want[i], " "), fmt.Sprintf("%d - %s", i, show))
|
|
}
|
|
})
|
|
}
|
|
}
|