Fix App's preferences referencing deleted categories (#1734)

app/src/main/java/eu/kanade/domain/DomainModule.kt

@@ -111,7 +111,7 @@ class DomainModule : InjektModule {
         addFactory { RenameCategory(get()) }
         addFactory { ReorderCategory(get()) }
         addFactory { UpdateCategory(get()) }
-        addFactory { DeleteCategory(get()) }
+        addFactory { DeleteCategory(get(), get(), get()) }
 
         addSingletonFactory<MangaRepository> { MangaRepositoryImpl(get()) }
         addFactory { GetDuplicateLibraryManga(get()) }

app/src/main/java/mihon/core/migration/migrations/CategoryPreferencesCleanupMigration.kt

@@ -0,0 +1,40 @@
+package mihon.core.migration.migrations
+
+import mihon.core.migration.Migration
+import mihon.core.migration.MigrationContext
+import tachiyomi.core.common.util.lang.withIOContext
+import tachiyomi.domain.category.interactor.GetCategories
+import tachiyomi.domain.download.service.DownloadPreferences
+import tachiyomi.domain.library.service.LibraryPreferences
+
+class CategoryPreferencesCleanupMigration : Migration {
+    override val version: Float = 10f
+
+    override suspend fun invoke(migrationContext: MigrationContext): Boolean = withIOContext {
+        val libraryPreferences = migrationContext.get<LibraryPreferences>() ?: return@withIOContext false
+        val downloadPreferences = migrationContext.get<DownloadPreferences>() ?: return@withIOContext false
+
+        val getCategories = migrationContext.get<GetCategories>() ?: return@withIOContext false
+        val allCategories = getCategories.await().map { it.id.toString() }.toSet()
+
+        val defaultCategory = libraryPreferences.defaultCategory().get()
+        if (defaultCategory.toString() !in allCategories) {
+            libraryPreferences.defaultCategory().delete()
+        }
+
+        val categoryPreferences = listOf(
+            libraryPreferences.updateCategories(),
+            libraryPreferences.updateCategoriesExclude(),
+            downloadPreferences.removeExcludeCategories(),
+            downloadPreferences.downloadNewChapterCategories(),
+            downloadPreferences.downloadNewChapterCategoriesExclude(),
+        )
+        categoryPreferences.forEach { preference ->
+            val ids = preference.get()
+            val garbageIds = ids.minus(allCategories)
+            if (garbageIds.isEmpty()) return@forEach
+            preference.set(ids.minus(garbageIds))
+        }
+        return@withIOContext true
+    }
+}

app/src/main/java/mihon/core/migration/migrations/Migrations.kt

@@ -7,4 +7,5 @@ val migrations: List<Migration>
         SetupBackupCreateMigration(),
         SetupLibraryUpdateMigration(),
         TrustExtensionRepositoryMigration(),
+        CategoryPreferencesCleanupMigration(),
     )