mirror/mihon
1
0
Fork 0
mirror of https://github.com/mihonapp/mihon.git synced 2025-03-01 18:34:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix Bangumi login regression (#1770)

Browse Source 
Caused by #1748.

Two different issues actually.

Firstly, the getUsername API call uses the authClient, which uses the
BangumiInterceptor to get the current OAuth data and attach the
Authorization header. However, on login, #1748 did not try to set the
new auth details until after attempting to call getUsername.
This would cause Mihon to think the user was not authenticated with
Bangumi and cancel the process.

This is fixed by having Mihon store the OAuth credentials in the
interceptor first before attempting to call getUsername.

The second issue is a simple trailing dollar sign in the API URL for
the getUsername method. This was removed.
This commit is contained in:
MajorTanya 2025-02-25 06:38:33 +01:00 committed by GitHub
parent 277d8bad8e
commit badc229a23
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/main/java/eu/kanade/tachiyomi/data/track/bangumi/Bangumi.kt
View File

@ -105,11 +105,11 @@ class Bangumi(id: Long) : BaseTracker(id, "Bangumi") {
suspend fun login(code: String) { suspend fun login(code: String) {
try { try {
val oauth = api.accessToken(code) val oauth = api.accessToken(code)
interceptor.newAuth(oauth)
// Users can set a 'username' (not nickname) once which effectively // Users can set a 'username' (not nickname) once which effectively
// replaces the stringified ID in certain queries. // replaces the stringified ID in certain queries.
// If no username is set, the API returns the user ID as a strings // If no username is set, the API returns the user ID as a strings
var username = api.getUsername() var username = api.getUsername()
interceptor.newAuth(oauth)
saveCredentials(username, oauth.accessToken) saveCredentials(username, oauth.accessToken)
} catch (_: Throwable) { } catch (_: Throwable) {
logout() logout()

2
app/src/main/java/eu/kanade/tachiyomi/data/track/bangumi/BangumiApi.kt
View File

@ -153,7 +153,7 @@ class BangumiApi(
suspend fun getUsername(): String { suspend fun getUsername(): String {
return withIOContext { return withIOContext {
with(json) { with(json) {
authClient.newCall(GET("$API_URL/v0/me$")) authClient.newCall(GET("$API_URL/v0/me"))
.awaitSuccess() .awaitSuccess()
.parseAs<BGMUser>() .parseAs<BGMUser>()
.username .username