Delayed Tracking Update related fix (#8642)

* Delayed Tracking Update related fix

* Lint

app/src/main/java/eu/kanade/tachiyomi/AppModule.kt

@@ -20,6 +20,7 @@ import eu.kanade.domain.download.service.DownloadPreferences
 import eu.kanade.domain.library.service.LibraryPreferences
 import eu.kanade.domain.source.service.SourcePreferences
 import eu.kanade.domain.track.service.TrackPreferences
+import eu.kanade.domain.track.store.DelayedTrackingStore
 import eu.kanade.domain.ui.UiPreferences
 import eu.kanade.tachiyomi.core.preference.AndroidPreferenceStore
 import eu.kanade.tachiyomi.core.preference.PreferenceStore
@@ -33,7 +34,6 @@ import eu.kanade.tachiyomi.data.download.DownloadManager
 import eu.kanade.tachiyomi.data.download.DownloadProvider
 import eu.kanade.tachiyomi.data.saver.ImageSaver
 import eu.kanade.tachiyomi.data.track.TrackManager
-import eu.kanade.tachiyomi.data.track.job.DelayedTrackingStore
 import eu.kanade.tachiyomi.extension.ExtensionManager
 import eu.kanade.tachiyomi.network.JavaScriptEngine
 import eu.kanade.tachiyomi.network.NetworkHelper

app/src/main/java/eu/kanade/tachiyomi/Migrations.kt

@@ -36,7 +36,6 @@ object Migrations {
     /**
      * Performs a migration when the application is updated.
      *
-     * @param preferences Preferences of the application.
      * @return true if a migration is performed, false otherwise.
      */
     fun upgrade(
@@ -339,6 +338,16 @@ object Migrations {
                     }
                 }
             }
+            if (oldVersion < 92) {
+                val trackingQueuePref = context.getSharedPreferences("tracking_queue", Context.MODE_PRIVATE)
+                trackingQueuePref.all.forEach {
+                    val (_, lastChapterRead) = it.value.toString().split(":")
+                    trackingQueuePref.edit {
+                        remove(it.key)
+                        putFloat(it.key, lastChapterRead.toFloat())
+                    }
+                }
+            }
             return true
         }
 

app/src/main/java/eu/kanade/tachiyomi/data/track/job/DelayedTrackingStore.kt

@@ -1,52 +0,0 @@
-package eu.kanade.tachiyomi.data.track.job
-
-import android.content.Context
-import androidx.core.content.edit
-import eu.kanade.domain.track.model.Track
-import eu.kanade.tachiyomi.util.system.logcat
-import logcat.LogPriority
-
-class DelayedTrackingStore(context: Context) {
-
-    /**
-     * Preference file where queued tracking updates are stored.
-     */
-    private val preferences = context.getSharedPreferences("tracking_queue", Context.MODE_PRIVATE)
-
-    fun addItem(track: Track) {
-        val trackId = track.id.toString()
-        val (_, lastChapterRead) = preferences.getString(trackId, "0:0.0")!!.split(":")
-        if (track.lastChapterRead > lastChapterRead.toFloat()) {
-            val value = "${track.mangaId}:${track.lastChapterRead}"
-            logcat(LogPriority.DEBUG) { "Queuing track item: $trackId, $value" }
-            preferences.edit {
-                putString(trackId, value)
-            }
-        }
-    }
-
-    fun remove(track: Track) {
-        preferences.edit {
-            remove(track.id.toString())
-        }
-    }
-
-    @Suppress("UNCHECKED_CAST")
-    fun getItems(): List<DelayedTrackingItem> {
-        return (preferences.all as Map<String, String>).entries
-            .map {
-                val (mangaId, lastChapterRead) = it.value.split(":")
-                DelayedTrackingItem(
-                    trackId = it.key.toLong(),
-                    mangaId = mangaId.toLong(),
-                    lastChapterRead = lastChapterRead.toFloat(),
-                )
-            }
-    }
-
-    data class DelayedTrackingItem(
-        val trackId: Long,
-        val mangaId: Long,
-        val lastChapterRead: Float,
-    )
-}

app/src/main/java/eu/kanade/tachiyomi/data/track/job/DelayedTrackingUpdateJob.kt

@@ -1,78 +0,0 @@
-package eu.kanade.tachiyomi.data.track.job
-
-import android.content.Context
-import androidx.work.BackoffPolicy
-import androidx.work.Constraints
-import androidx.work.CoroutineWorker
-import androidx.work.ExistingWorkPolicy
-import androidx.work.NetworkType
-import androidx.work.OneTimeWorkRequestBuilder
-import androidx.work.WorkManager
-import androidx.work.WorkerParameters
-import eu.kanade.domain.manga.interactor.GetManga
-import eu.kanade.domain.track.interactor.GetTracks
-import eu.kanade.domain.track.interactor.InsertTrack
-import eu.kanade.domain.track.model.toDbTrack
-import eu.kanade.tachiyomi.data.track.TrackManager
-import eu.kanade.tachiyomi.util.lang.withIOContext
-import eu.kanade.tachiyomi.util.system.logcat
-import logcat.LogPriority
-import uy.kohesive.injekt.Injekt
-import uy.kohesive.injekt.api.get
-import java.util.concurrent.TimeUnit
-
-class DelayedTrackingUpdateJob(context: Context, workerParams: WorkerParameters) :
-    CoroutineWorker(context, workerParams) {
-
-    override suspend fun doWork(): Result {
-        val getManga = Injekt.get<GetManga>()
-        val getTracks = Injekt.get<GetTracks>()
-        val insertTrack = Injekt.get<InsertTrack>()
-
-        val trackManager = Injekt.get<TrackManager>()
-        val delayedTrackingStore = Injekt.get<DelayedTrackingStore>()
-
-        withIOContext {
-            val tracks = delayedTrackingStore.getItems().mapNotNull {
-                val manga = getManga.await(it.mangaId) ?: return@withIOContext
-                getTracks.await(manga.id)
-                    .find { track -> track.id == it.trackId }
-                    ?.copy(lastChapterRead = it.lastChapterRead.toDouble())
-            }
-
-            tracks.forEach { track ->
-                try {
-                    val service = trackManager.getService(track.syncId)
-                    if (service != null && service.isLogged) {
-                        service.update(track.toDbTrack(), true)
-                        insertTrack.await(track)
-                    }
-                    delayedTrackingStore.remove(track)
-                } catch (e: Exception) {
-                    logcat(LogPriority.ERROR, e)
-                }
-            }
-        }
-
-        return Result.success()
-    }
-
-    companion object {
-        private const val TAG = "DelayedTrackingUpdate"
-
-        fun setupTask(context: Context) {
-            val constraints = Constraints.Builder()
-                .setRequiredNetworkType(NetworkType.CONNECTED)
-                .build()
-
-            val request = OneTimeWorkRequestBuilder<DelayedTrackingUpdateJob>()
-                .setConstraints(constraints)
-                .setBackoffCriteria(BackoffPolicy.EXPONENTIAL, 20, TimeUnit.SECONDS)
-                .addTag(TAG)
-                .build()
-
-            WorkManager.getInstance(context)
-                .enqueueUniqueWork(TAG, ExistingWorkPolicy.REPLACE, request)
-        }
-    }
-}

app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderPresenter.kt

@@ -21,7 +21,9 @@ import eu.kanade.domain.manga.model.toDbManga
 import eu.kanade.domain.track.interactor.GetTracks
 import eu.kanade.domain.track.interactor.InsertTrack
 import eu.kanade.domain.track.model.toDbTrack
+import eu.kanade.domain.track.service.DelayedTrackingUpdateJob
 import eu.kanade.domain.track.service.TrackPreferences
+import eu.kanade.domain.track.store.DelayedTrackingStore
 import eu.kanade.tachiyomi.data.database.models.Manga
 import eu.kanade.tachiyomi.data.database.models.toDomainChapter
 import eu.kanade.tachiyomi.data.database.models.toDomainManga
@@ -32,8 +34,6 @@ import eu.kanade.tachiyomi.data.saver.Image
 import eu.kanade.tachiyomi.data.saver.ImageSaver
 import eu.kanade.tachiyomi.data.saver.Location
 import eu.kanade.tachiyomi.data.track.TrackManager
-import eu.kanade.tachiyomi.data.track.job.DelayedTrackingStore
-import eu.kanade.tachiyomi.data.track.job.DelayedTrackingUpdateJob
 import eu.kanade.tachiyomi.source.SourceManager
 import eu.kanade.tachiyomi.source.model.Page
 import eu.kanade.tachiyomi.source.online.HttpSource