Misc Service cleanup (#9005)

* Simplify DownloadService wake lock handling

_isRunning is only modified in onCreate/onDestroy, so the listener
job is redundant.

* Drop superclass calls to Service.onCreate/onDestroy

From https://developer.android.com/guide/components/services
> Note: Unlike the activity lifecycle callback methods, you are not
> required to call the superclass implementation of these callback
> methods.
This commit is contained in:
Two-Ai
2023-01-30 17:25:54 -05:00
committed by GitHub
parent 7bf30a094a
commit aca65f13bb
5 changed files with 4 additions and 42 deletions

View File

@@ -22,7 +22,6 @@ class ExtensionInstallService : Service() {
private var installer: Installer? = null
override fun onCreate() {
super.onCreate()
val notification = notificationBuilder(Notifications.CHANNEL_EXTENSIONS_UPDATE) {
setSmallIcon(R.drawable.ic_tachi)
setAutoCancel(false)
@@ -59,7 +58,6 @@ class ExtensionInstallService : Service() {
}
override fun onDestroy() {
super.onDestroy()
installer?.onDestroy()
installer = null
}