From 8fbe630308b962043c7b59422878c94f80156e9f Mon Sep 17 00:00:00 2001 From: kunet Date: Sat, 29 Mar 2025 17:18:38 -0400 Subject: [PATCH] Add user manga notes (#428) Co-authored-by: AntsyLich <59261191+AntsyLich@users.noreply.github.com> --- CHANGELOG.md | 1 + app/build.gradle.kts | 1 + .../java/eu/kanade/domain/DomainModule.kt | 2 + .../presentation/manga/MangaNotesScreen.kt | 45 ++++ .../kanade/presentation/manga/MangaScreen.kt | 11 + .../manga/components/MangaInfoHeader.kt | 50 ++-- .../manga/components/MangaNotesDisplay.kt | 60 +++++ .../manga/components/MangaNotesSection.kt | 90 +++++++ .../manga/components/MangaNotesTextArea.kt | 224 ++++++++++++++++++ .../manga/components/MangaToolbar.kt | 7 + .../create/creators/MangaBackupCreator.kt | 1 + .../data/backup/models/BackupManga.kt | 3 + .../backup/restore/restorers/MangaRestorer.kt | 1 + .../ui/browse/migration/MigrationFlags.kt | 8 + .../browse/migration/search/MigrateDialog.kt | 2 + .../kanade/tachiyomi/ui/manga/MangaScreen.kt | 2 + .../ui/manga/notes/MangaNotesScreen.kt | 61 +++++ .../java/tachiyomi/data/manga/MangaMapper.kt | 4 + .../data/manga/MangaRepositoryImpl.kt | 1 + .../main/sqldelight/tachiyomi/data/mangas.sq | 6 +- .../sqldelight/tachiyomi/migrations/5.sqm | 3 + .../manga/interactor/UpdateMangaNotes.kt | 18 ++ .../tachiyomi/domain/manga/model/Manga.kt | 2 + .../domain/manga/model/MangaUpdate.kt | 2 + gradle/libs.versions.toml | 2 + .../moko-resources/base/strings.xml | 5 + 26 files changed, 596 insertions(+), 16 deletions(-) create mode 100644 app/src/main/java/eu/kanade/presentation/manga/MangaNotesScreen.kt create mode 100644 app/src/main/java/eu/kanade/presentation/manga/components/MangaNotesDisplay.kt create mode 100644 app/src/main/java/eu/kanade/presentation/manga/components/MangaNotesSection.kt create mode 100644 app/src/main/java/eu/kanade/presentation/manga/components/MangaNotesTextArea.kt create mode 100644 app/src/main/java/eu/kanade/tachiyomi/ui/manga/notes/MangaNotesScreen.kt create mode 100644 data/src/main/sqldelight/tachiyomi/migrations/5.sqm create mode 100644 domain/src/main/java/tachiyomi/domain/manga/interactor/UpdateMangaNotes.kt diff --git a/CHANGELOG.md b/CHANGELOG.md index 4db5efa1e..990b6744d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ The format is a modified version of [Keep a Changelog](https://keepachangelog.co ## [Unreleased] ### Added - Add more Kaomoji for empty/error screens ([@ianfhunter](https://github.com/ianfhunter/)) ([#1909](https://github.com/mihonapp/mihon/pull/1909)) +- Add user manga notes ([@imkunet](https://github.com/imkunet), [@AntsyLich](https://github.com/AntsyLich)) ([#428](https://github.com/mihonapp/mihon/pull/428)) ### Fixes - Fix Bangumi search results including novels ([@MajorTanya](https://github.com/MajorTanya)) ([#1885](https://github.com/mihonapp/mihon/pull/1885)) diff --git a/app/build.gradle.kts b/app/build.gradle.kts index 4eec4c119..425b42616 100644 --- a/app/build.gradle.kts +++ b/app/build.gradle.kts @@ -263,6 +263,7 @@ dependencies { } implementation(libs.insetter) implementation(libs.bundles.richtext) + implementation(libs.richeditor.compose) implementation(libs.aboutLibraries.compose) implementation(libs.bundles.voyager) implementation(libs.compose.materialmotion) diff --git a/app/src/main/java/eu/kanade/domain/DomainModule.kt b/app/src/main/java/eu/kanade/domain/DomainModule.kt index 1fa63beeb..16c0fd53e 100644 --- a/app/src/main/java/eu/kanade/domain/DomainModule.kt +++ b/app/src/main/java/eu/kanade/domain/DomainModule.kt @@ -79,6 +79,7 @@ import tachiyomi.domain.manga.interactor.GetMangaWithChapters import tachiyomi.domain.manga.interactor.NetworkToLocalManga import tachiyomi.domain.manga.interactor.ResetViewerFlags import tachiyomi.domain.manga.interactor.SetMangaChapterFlags +import tachiyomi.domain.manga.interactor.UpdateMangaNotes import tachiyomi.domain.manga.repository.MangaRepository import tachiyomi.domain.release.interactor.GetApplicationRelease import tachiyomi.domain.release.service.ReleaseService @@ -129,6 +130,7 @@ class DomainModule : InjektModule { addFactory { SetMangaViewerFlags(get()) } addFactory { NetworkToLocalManga(get()) } addFactory { UpdateManga(get(), get()) } + addFactory { UpdateMangaNotes(get()) } addFactory { SetMangaCategories(get()) } addFactory { GetExcludedScanlators(get()) } addFactory { SetExcludedScanlators(get()) } diff --git a/app/src/main/java/eu/kanade/presentation/manga/MangaNotesScreen.kt b/app/src/main/java/eu/kanade/presentation/manga/MangaNotesScreen.kt new file mode 100644 index 000000000..415e7b728 --- /dev/null +++ b/app/src/main/java/eu/kanade/presentation/manga/MangaNotesScreen.kt @@ -0,0 +1,45 @@ +package eu.kanade.presentation.manga + +import androidx.compose.foundation.layout.consumeWindowInsets +import androidx.compose.foundation.layout.imePadding +import androidx.compose.foundation.layout.padding +import androidx.compose.runtime.Composable +import androidx.compose.ui.Modifier +import eu.kanade.presentation.components.AppBar +import eu.kanade.presentation.components.AppBarTitle +import eu.kanade.presentation.manga.components.MangaNotesTextArea +import eu.kanade.tachiyomi.ui.manga.notes.MangaNotesScreen +import tachiyomi.i18n.MR +import tachiyomi.presentation.core.components.material.Scaffold +import tachiyomi.presentation.core.i18n.stringResource + +@Composable +fun MangaNotesScreen( + state: MangaNotesScreen.State, + navigateUp: () -> Unit, + onUpdate: (String) -> Unit, +) { + Scaffold( + topBar = { topBarScrollBehavior -> + AppBar( + titleContent = { + AppBarTitle( + title = stringResource(MR.strings.action_edit_notes), + subtitle = state.manga.title, + ) + }, + navigateUp = navigateUp, + scrollBehavior = topBarScrollBehavior, + ) + }, + ) { contentPadding -> + MangaNotesTextArea( + state = state, + onUpdate = onUpdate, + modifier = Modifier + .padding(contentPadding) + .consumeWindowInsets(contentPadding) + .imePadding(), + ) + } +} diff --git a/app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt b/app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt index ce6e02366..b8e23ddca 100644 --- a/app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt +++ b/app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt @@ -112,6 +112,7 @@ fun MangaScreen( onEditCategoryClicked: (() -> Unit)?, onEditFetchIntervalClicked: (() -> Unit)?, onMigrateClicked: (() -> Unit)?, + onEditNotesClicked: () -> Unit, // For bottom action menu onMultiBookmarkClicked: (List, bookmarked: Boolean) -> Unit, @@ -160,6 +161,7 @@ fun MangaScreen( onEditCategoryClicked = onEditCategoryClicked, onEditIntervalClicked = onEditFetchIntervalClicked, onMigrateClicked = onMigrateClicked, + onEditNotesClicked = onEditNotesClicked, onMultiBookmarkClicked = onMultiBookmarkClicked, onMultiMarkAsReadClicked = onMultiMarkAsReadClicked, onMarkPreviousAsReadClicked = onMarkPreviousAsReadClicked, @@ -195,6 +197,7 @@ fun MangaScreen( onEditCategoryClicked = onEditCategoryClicked, onEditIntervalClicked = onEditFetchIntervalClicked, onMigrateClicked = onMigrateClicked, + onEditNotesClicked = onEditNotesClicked, onMultiBookmarkClicked = onMultiBookmarkClicked, onMultiMarkAsReadClicked = onMultiMarkAsReadClicked, onMarkPreviousAsReadClicked = onMarkPreviousAsReadClicked, @@ -240,6 +243,7 @@ private fun MangaScreenSmallImpl( onEditCategoryClicked: (() -> Unit)?, onEditIntervalClicked: (() -> Unit)?, onMigrateClicked: (() -> Unit)?, + onEditNotesClicked: () -> Unit, // For bottom action menu onMultiBookmarkClicked: (List, bookmarked: Boolean) -> Unit, @@ -302,6 +306,7 @@ private fun MangaScreenSmallImpl( onClickEditCategory = onEditCategoryClicked, onClickRefresh = onRefresh, onClickMigrate = onMigrateClicked, + onClickEditNotes = onEditNotesClicked, actionModeCounter = selectedChapterCount, onCancelActionMode = { onAllChapterSelected(false) }, onSelectAll = { onAllChapterSelected(true) }, @@ -414,8 +419,10 @@ private fun MangaScreenSmallImpl( defaultExpandState = state.isFromSource, description = state.manga.description, tagsProvider = { state.manga.genre }, + notes = state.manga.notes, onTagSearch = onTagSearch, onCopyTagToClipboard = onCopyTagToClipboard, + onEditNotes = onEditNotesClicked, ) } @@ -484,6 +491,7 @@ fun MangaScreenLargeImpl( onEditCategoryClicked: (() -> Unit)?, onEditIntervalClicked: (() -> Unit)?, onMigrateClicked: (() -> Unit)?, + onEditNotesClicked: () -> Unit, // For bottom action menu onMultiBookmarkClicked: (List, bookmarked: Boolean) -> Unit, @@ -539,6 +547,7 @@ fun MangaScreenLargeImpl( onClickEditCategory = onEditCategoryClicked, onClickRefresh = onRefresh, onClickMigrate = onMigrateClicked, + onClickEditNotes = onEditNotesClicked, onCancelActionMode = { onAllChapterSelected(false) }, actionModeCounter = selectedChapterCount, onSelectAll = { onAllChapterSelected(true) }, @@ -640,8 +649,10 @@ fun MangaScreenLargeImpl( defaultExpandState = true, description = state.manga.description, tagsProvider = { state.manga.genre }, + notes = state.manga.notes, onTagSearch = onTagSearch, onCopyTagToClipboard = onCopyTagToClipboard, + onEditNotes = onEditNotesClicked, ) } }, diff --git a/app/src/main/java/eu/kanade/presentation/manga/components/MangaInfoHeader.kt b/app/src/main/java/eu/kanade/presentation/manga/components/MangaInfoHeader.kt index 6a1376463..32b315985 100644 --- a/app/src/main/java/eu/kanade/presentation/manga/components/MangaInfoHeader.kt +++ b/app/src/main/java/eu/kanade/presentation/manga/components/MangaInfoHeader.kt @@ -236,8 +236,10 @@ fun ExpandableMangaDescription( defaultExpandState: Boolean, description: String?, tagsProvider: () -> List?, + notes: String, onTagSearch: (String) -> Unit, onCopyTagToClipboard: (tag: String) -> Unit, + onEditNotes: () -> Unit, modifier: Modifier = Modifier, ) { Column(modifier = modifier) { @@ -255,6 +257,8 @@ fun ExpandableMangaDescription( expandedDescription = desc, shrunkDescription = trimmedDescription, expanded = expanded, + notes = notes, + onEditNotesClicked = onEditNotes, modifier = Modifier .padding(top = 8.dp) .padding(horizontal = 16.dp) @@ -559,7 +563,9 @@ private fun ColumnScope.MangaContentInfo( private fun MangaSummary( expandedDescription: String, shrunkDescription: String, + notes: String, expanded: Boolean, + onEditNotesClicked: () -> Unit, modifier: Modifier = Modifier, ) { val animProgress by animateFloatAsState( @@ -571,25 +577,41 @@ private fun MangaSummary( contents = listOf( { Text( - text = "\n\n", // Shows at least 3 lines + // Shows at least 3 lines if no notes + // when there are notes show 6 + text = if (notes.isBlank()) "\n\n" else "\n\n\n\n\n", style = MaterialTheme.typography.bodyMedium, ) }, { - Text( - text = expandedDescription, - style = MaterialTheme.typography.bodyMedium, - ) - }, - { - SelectionContainer { - Text( - text = if (expanded) expandedDescription else shrunkDescription, - maxLines = Int.MAX_VALUE, - style = MaterialTheme.typography.bodyMedium, - color = MaterialTheme.colorScheme.onBackground, - modifier = Modifier.secondaryItemAlpha(), + Column { + MangaNotesSection( + content = notes, + expanded = true, + onEditNotes = onEditNotesClicked, ) + Text( + text = expandedDescription, + style = MaterialTheme.typography.bodyMedium, + ) + } + }, + { + Column { + MangaNotesSection( + content = notes, + expanded = expanded, + onEditNotes = onEditNotesClicked, + ) + SelectionContainer { + Text( + text = if (expanded) expandedDescription else shrunkDescription, + maxLines = Int.MAX_VALUE, + style = MaterialTheme.typography.bodyMedium, + color = MaterialTheme.colorScheme.onBackground, + modifier = Modifier.secondaryItemAlpha(), + ) + } } }, { diff --git a/app/src/main/java/eu/kanade/presentation/manga/components/MangaNotesDisplay.kt b/app/src/main/java/eu/kanade/presentation/manga/components/MangaNotesDisplay.kt new file mode 100644 index 000000000..a7b93fbed --- /dev/null +++ b/app/src/main/java/eu/kanade/presentation/manga/components/MangaNotesDisplay.kt @@ -0,0 +1,60 @@ +package eu.kanade.presentation.manga.components + +import androidx.compose.animation.animateContentSize +import androidx.compose.animation.core.Animatable +import androidx.compose.animation.core.tween +import androidx.compose.foundation.text.selection.SelectionContainer +import androidx.compose.material3.MaterialTheme +import androidx.compose.runtime.Composable +import androidx.compose.runtime.LaunchedEffect +import androidx.compose.runtime.getValue +import androidx.compose.runtime.mutableStateOf +import androidx.compose.runtime.remember +import androidx.compose.runtime.setValue +import androidx.compose.ui.Modifier +import androidx.compose.ui.draw.alpha +import com.mohamedrejeb.richeditor.model.rememberRichTextState +import com.mohamedrejeb.richeditor.ui.material3.RichText + +private val FADE_TIME = tween(500) + +@Composable +fun MangaNotesDisplay( + content: String, + modifier: Modifier, +) { + val alpha = remember { Animatable(1f) } + var contentUpdatedOnce by remember { mutableStateOf(false) } + + val richTextState = rememberRichTextState() + val primaryColor = MaterialTheme.colorScheme.primary + LaunchedEffect(content) { + richTextState.setMarkdown(content) + + if (!contentUpdatedOnce) { + contentUpdatedOnce = true + return@LaunchedEffect + } + + alpha.snapTo(targetValue = 0f) + alpha.animateTo(targetValue = 1f, animationSpec = FADE_TIME) + } + LaunchedEffect(Unit) { + richTextState.config.unorderedListIndent = 4 + richTextState.config.orderedListIndent = 20 + } + LaunchedEffect(primaryColor) { + richTextState.config.linkColor = primaryColor + } + + SelectionContainer { + RichText( + modifier = modifier + // Only animate size if the notes changes + .then(if (contentUpdatedOnce) Modifier.animateContentSize() else Modifier) + .alpha(alpha.value), + style = MaterialTheme.typography.bodyMedium, + state = richTextState, + ) + } +} diff --git a/app/src/main/java/eu/kanade/presentation/manga/components/MangaNotesSection.kt b/app/src/main/java/eu/kanade/presentation/manga/components/MangaNotesSection.kt new file mode 100644 index 000000000..37adea58e --- /dev/null +++ b/app/src/main/java/eu/kanade/presentation/manga/components/MangaNotesSection.kt @@ -0,0 +1,90 @@ +package eu.kanade.presentation.manga.components + +import androidx.compose.foundation.layout.Arrangement +import androidx.compose.foundation.layout.Column +import androidx.compose.foundation.layout.Row +import androidx.compose.foundation.layout.fillMaxWidth +import androidx.compose.foundation.layout.padding +import androidx.compose.foundation.layout.size +import androidx.compose.foundation.shape.RoundedCornerShape +import androidx.compose.material.icons.Icons +import androidx.compose.material.icons.filled.EditNote +import androidx.compose.material3.HorizontalDivider +import androidx.compose.material3.Icon +import androidx.compose.material3.MaterialTheme +import androidx.compose.material3.Text +import androidx.compose.runtime.Composable +import androidx.compose.ui.Alignment +import androidx.compose.ui.Modifier +import androidx.compose.ui.graphics.Color +import androidx.compose.ui.tooling.preview.PreviewLightDark +import androidx.compose.ui.unit.dp +import tachiyomi.i18n.MR +import tachiyomi.presentation.core.components.material.Button +import tachiyomi.presentation.core.components.material.ButtonDefaults +import tachiyomi.presentation.core.components.material.padding +import tachiyomi.presentation.core.i18n.stringResource + +@Composable +fun MangaNotesSection( + content: String, + expanded: Boolean, + onEditNotes: () -> Unit, + modifier: Modifier = Modifier, +) { + if (content.isBlank()) return + Column( + modifier = modifier.fillMaxWidth(), + horizontalAlignment = Alignment.CenterHorizontally, + ) { + MangaNotesDisplay( + content = content, + modifier = modifier.fillMaxWidth(), + ) + if (expanded) { + Button( + onClick = onEditNotes, + colors = ButtonDefaults.buttonColors( + containerColor = Color.Transparent, + contentColor = MaterialTheme.colorScheme.primary, + ), + shape = RoundedCornerShape(8.dp), + modifier = Modifier + .padding(horizontal = 16.dp, vertical = 4.dp), + ) { + Row( + horizontalArrangement = Arrangement.spacedBy(MaterialTheme.padding.extraSmall), + verticalAlignment = Alignment.CenterVertically, + ) { + Icon( + imageVector = Icons.Filled.EditNote, + contentDescription = null, + modifier = Modifier + .size(16.dp), + ) + Text( + stringResource(MR.strings.action_edit_notes), + ) + } + } + } + + HorizontalDivider( + modifier = Modifier + .padding( + top = if (expanded) 0.dp else 12.dp, + bottom = if (expanded) 16.dp else 12.dp, + ), + ) + } +} + +@PreviewLightDark +@Composable +private fun MangaNotesSectionPreview() { + MangaNotesSection( + onEditNotes = {}, + expanded = true, + content = "# Hello world\ntest1234 hi there!", + ) +} diff --git a/app/src/main/java/eu/kanade/presentation/manga/components/MangaNotesTextArea.kt b/app/src/main/java/eu/kanade/presentation/manga/components/MangaNotesTextArea.kt new file mode 100644 index 000000000..12aca3d3b --- /dev/null +++ b/app/src/main/java/eu/kanade/presentation/manga/components/MangaNotesTextArea.kt @@ -0,0 +1,224 @@ +package eu.kanade.presentation.manga.components + +import androidx.compose.foundation.background +import androidx.compose.foundation.clickable +import androidx.compose.foundation.layout.Arrangement +import androidx.compose.foundation.layout.Box +import androidx.compose.foundation.layout.Column +import androidx.compose.foundation.layout.PaddingValues +import androidx.compose.foundation.layout.Row +import androidx.compose.foundation.layout.fillMaxSize +import androidx.compose.foundation.layout.fillMaxWidth +import androidx.compose.foundation.layout.height +import androidx.compose.foundation.layout.padding +import androidx.compose.foundation.lazy.LazyRow +import androidx.compose.material.icons.Icons +import androidx.compose.material.icons.automirrored.outlined.FormatListBulleted +import androidx.compose.material.icons.outlined.FormatBold +import androidx.compose.material.icons.outlined.FormatItalic +import androidx.compose.material.icons.outlined.FormatListNumbered +import androidx.compose.material.icons.outlined.FormatUnderlined +import androidx.compose.material3.Icon +import androidx.compose.material3.MaterialTheme +import androidx.compose.material3.Text +import androidx.compose.material3.VerticalDivider +import androidx.compose.runtime.Composable +import androidx.compose.runtime.DisposableEffect +import androidx.compose.runtime.LaunchedEffect +import androidx.compose.runtime.remember +import androidx.compose.runtime.rememberCoroutineScope +import androidx.compose.runtime.snapshotFlow +import androidx.compose.ui.Alignment +import androidx.compose.ui.Modifier +import androidx.compose.ui.draw.clip +import androidx.compose.ui.focus.FocusRequester +import androidx.compose.ui.focus.focusRequester +import androidx.compose.ui.graphics.Color +import androidx.compose.ui.graphics.vector.ImageVector +import androidx.compose.ui.semantics.Role +import androidx.compose.ui.text.SpanStyle +import androidx.compose.ui.text.font.FontStyle +import androidx.compose.ui.text.font.FontWeight +import androidx.compose.ui.text.style.TextDecoration +import androidx.compose.ui.unit.dp +import com.mohamedrejeb.richeditor.model.rememberRichTextState +import com.mohamedrejeb.richeditor.ui.material3.RichTextEditor +import com.mohamedrejeb.richeditor.ui.material3.RichTextEditorDefaults.richTextEditorColors +import eu.kanade.tachiyomi.ui.manga.notes.MangaNotesScreen +import kotlinx.coroutines.flow.debounce +import kotlinx.coroutines.flow.distinctUntilChanged +import kotlinx.coroutines.flow.launchIn +import kotlinx.coroutines.flow.map +import kotlinx.coroutines.flow.onEach +import tachiyomi.i18n.MR +import tachiyomi.presentation.core.components.material.padding +import tachiyomi.presentation.core.i18n.stringResource +import kotlin.time.Duration.Companion.seconds + +private const val MAX_LENGTH = 250 +private const val MAX_LENGTH_WARN = MAX_LENGTH * 0.9 + +@Composable +fun MangaNotesTextArea( + state: MangaNotesScreen.State, + onUpdate: (String) -> Unit, + modifier: Modifier = Modifier, +) { + val scope = rememberCoroutineScope() + val richTextState = rememberRichTextState() + val primaryColor = MaterialTheme.colorScheme.primary + + DisposableEffect(scope, richTextState) { + snapshotFlow { richTextState.annotatedString } + .debounce(0.25.seconds) + .distinctUntilChanged() + .map { richTextState.toMarkdown() } + .onEach { onUpdate(it) } + .launchIn(scope) + + onDispose { + onUpdate(richTextState.toMarkdown()) + } + } + LaunchedEffect(Unit) { + richTextState.setMarkdown(state.notes) + richTextState.config.unorderedListIndent = 4 + richTextState.config.orderedListIndent = 20 + } + LaunchedEffect(primaryColor) { + richTextState.config.linkColor = primaryColor + } + val focusRequester = remember { FocusRequester() } + LaunchedEffect(focusRequester) { + focusRequester.requestFocus() + } + val textLength = remember(richTextState.annotatedString) { richTextState.toText().length } + + Column( + modifier = modifier + .padding(horizontal = MaterialTheme.padding.small) + .fillMaxSize(), + ) { + RichTextEditor( + state = richTextState, + textStyle = MaterialTheme.typography.bodyLarge, + maxLength = MAX_LENGTH, + placeholder = { + Text(text = stringResource(MR.strings.notes_placeholder)) + }, + colors = richTextEditorColors( + containerColor = Color.Transparent, + focusedIndicatorColor = Color.Transparent, + unfocusedIndicatorColor = Color.Transparent, + ), + contentPadding = PaddingValues( + horizontal = MaterialTheme.padding.medium, + ), + modifier = Modifier + .weight(1f) + .fillMaxWidth() + .focusRequester(focusRequester), + ) + Row( + verticalAlignment = Alignment.CenterVertically, + horizontalArrangement = Arrangement.SpaceBetween, + modifier = Modifier + .padding(vertical = MaterialTheme.padding.small) + .fillMaxWidth(), + ) { + LazyRow( + verticalAlignment = Alignment.CenterVertically, + horizontalArrangement = Arrangement.spacedBy(2.dp), + ) { + item { + MangaNotesTextAreaButton( + onClick = { richTextState.toggleSpanStyle(SpanStyle(fontWeight = FontWeight.Bold)) }, + isSelected = richTextState.currentSpanStyle.fontWeight == FontWeight.Bold, + icon = Icons.Outlined.FormatBold, + ) + } + item { + MangaNotesTextAreaButton( + onClick = { richTextState.toggleSpanStyle(SpanStyle(fontStyle = FontStyle.Italic)) }, + isSelected = richTextState.currentSpanStyle.fontStyle == FontStyle.Italic, + icon = Icons.Outlined.FormatItalic, + ) + } + item { + MangaNotesTextAreaButton( + onClick = { + richTextState.toggleSpanStyle(SpanStyle(textDecoration = TextDecoration.Underline)) + }, + isSelected = richTextState.currentSpanStyle.textDecoration + ?.contains(TextDecoration.Underline) + ?: false, + icon = Icons.Outlined.FormatUnderlined, + ) + } + item { + VerticalDivider( + modifier = Modifier + .padding(horizontal = MaterialTheme.padding.extraSmall) + .height(MaterialTheme.padding.large), + ) + } + item { + MangaNotesTextAreaButton( + onClick = { richTextState.toggleUnorderedList() }, + isSelected = richTextState.isUnorderedList, + icon = Icons.AutoMirrored.Outlined.FormatListBulleted, + ) + } + item { + MangaNotesTextAreaButton( + onClick = { richTextState.toggleOrderedList() }, + isSelected = richTextState.isOrderedList, + icon = Icons.Outlined.FormatListNumbered, + ) + } + } + + Box( + contentAlignment = Alignment.Center, + ) { + Text( + text = (MAX_LENGTH - textLength).toString(), + color = if (textLength > MAX_LENGTH_WARN) { + MaterialTheme.colorScheme.error + } else { + Color.Unspecified + }, + modifier = Modifier.padding(MaterialTheme.padding.extraSmall), + ) + } + } + } +} + +@Composable +fun MangaNotesTextAreaButton( + onClick: () -> Unit, + icon: ImageVector, + isSelected: Boolean, + modifier: Modifier = Modifier, +) { + Box( + modifier = modifier + .clip(MaterialTheme.shapes.small) + .clickable( + onClick = onClick, + enabled = true, + role = Role.Button, + ), + contentAlignment = Alignment.Center, + ) { + Icon( + imageVector = icon, + contentDescription = icon.name, + tint = if (isSelected) MaterialTheme.colorScheme.onPrimary else MaterialTheme.colorScheme.primary, + modifier = Modifier + .background(color = if (isSelected) MaterialTheme.colorScheme.onBackground else Color.Transparent) + .padding(MaterialTheme.padding.extraSmall), + ) + } +} diff --git a/app/src/main/java/eu/kanade/presentation/manga/components/MangaToolbar.kt b/app/src/main/java/eu/kanade/presentation/manga/components/MangaToolbar.kt index 43fc92a77..5ab5c6401 100644 --- a/app/src/main/java/eu/kanade/presentation/manga/components/MangaToolbar.kt +++ b/app/src/main/java/eu/kanade/presentation/manga/components/MangaToolbar.kt @@ -37,6 +37,7 @@ fun MangaToolbar( onClickEditCategory: (() -> Unit)?, onClickRefresh: () -> Unit, onClickMigrate: (() -> Unit)?, + onClickEditNotes: () -> Unit, // For action mode actionModeCounter: Int, @@ -140,6 +141,12 @@ fun MangaToolbar( ), ) } + add( + AppBar.OverflowAction( + title = stringResource(MR.strings.action_notes), + onClick = onClickEditNotes, + ), + ) } .build(), ) diff --git a/app/src/main/java/eu/kanade/tachiyomi/data/backup/create/creators/MangaBackupCreator.kt b/app/src/main/java/eu/kanade/tachiyomi/data/backup/create/creators/MangaBackupCreator.kt index 040de931b..97c4b9fbc 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/data/backup/create/creators/MangaBackupCreator.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/data/backup/create/creators/MangaBackupCreator.kt @@ -99,4 +99,5 @@ private fun Manga.toBackupManga() = lastModifiedAt = this.lastModifiedAt, favoriteModifiedAt = this.favoriteModifiedAt, version = this.version, + notes = this.notes, ) diff --git a/app/src/main/java/eu/kanade/tachiyomi/data/backup/models/BackupManga.kt b/app/src/main/java/eu/kanade/tachiyomi/data/backup/models/BackupManga.kt index 3bfc1ffcc..830636337 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/data/backup/models/BackupManga.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/data/backup/models/BackupManga.kt @@ -38,8 +38,10 @@ data class BackupManga( @ProtoNumber(105) var updateStrategy: UpdateStrategy = UpdateStrategy.ALWAYS_UPDATE, @ProtoNumber(106) var lastModifiedAt: Long = 0, @ProtoNumber(107) var favoriteModifiedAt: Long? = null, + // Mihon values start here @ProtoNumber(108) var excludedScanlators: List = emptyList(), @ProtoNumber(109) var version: Long = 0, + @ProtoNumber(110) var notes: String = "", ) { fun getMangaImpl(): Manga { return Manga.create().copy( @@ -60,6 +62,7 @@ data class BackupManga( lastModifiedAt = this@BackupManga.lastModifiedAt, favoriteModifiedAt = this@BackupManga.favoriteModifiedAt, version = this@BackupManga.version, + notes = this@BackupManga.notes, ) } } diff --git a/app/src/main/java/eu/kanade/tachiyomi/data/backup/restore/restorers/MangaRestorer.kt b/app/src/main/java/eu/kanade/tachiyomi/data/backup/restore/restorers/MangaRestorer.kt index 11c11e220..77ffd67ae 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/data/backup/restore/restorers/MangaRestorer.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/data/backup/restore/restorers/MangaRestorer.kt @@ -129,6 +129,7 @@ class MangaRestorer( updateStrategy = manga.updateStrategy.let(UpdateStrategyColumnAdapter::encode), version = manga.version, isSyncing = 1, + notes = manga.notes, ) } return manga diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/MigrationFlags.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/MigrationFlags.kt index 3064ad60f..99b5f1543 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/MigrationFlags.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/MigrationFlags.kt @@ -30,6 +30,7 @@ object MigrationFlags { private const val CATEGORIES = 0b00010 private const val CUSTOM_COVER = 0b01000 private const val DELETE_DOWNLOADED = 0b10000 + private const val NOTES = 0b100000 private val coverCache: CoverCache by injectLazy() private val downloadCache: DownloadCache by injectLazy() @@ -50,6 +51,10 @@ object MigrationFlags { return value and DELETE_DOWNLOADED != 0 } + fun hasNotes(value: Int): Boolean { + return value and NOTES != 0 + } + /** Returns information about applicable flags with default selections. */ fun getFlags(manga: Manga?, defaultSelectedBitMap: Int): List { val flags = mutableListOf() @@ -63,6 +68,9 @@ object MigrationFlags { if (downloadCache.getDownloadCount(manga) > 0) { flags += MigrationFlag.create(DELETE_DOWNLOADED, defaultSelectedBitMap, MR.strings.delete_downloaded) } + if (manga.notes.isNotBlank()) { + flags += MigrationFlag.create(NOTES, defaultSelectedBitMap, MR.strings.action_notes) + } } return flags } diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/MigrateDialog.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/MigrateDialog.kt index 3a2369d35..bf50d677d 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/MigrateDialog.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/search/MigrateDialog.kt @@ -213,6 +213,7 @@ internal class MigrateDialogScreenModel( val migrateCategories = MigrationFlags.hasCategories(flags) val migrateCustomCover = MigrationFlags.hasCustomCover(flags) val deleteDownloaded = MigrationFlags.hasDeleteDownloaded(flags) + val migrateNotes = MigrationFlags.hasNotes(flags) try { syncChaptersWithSource.await(sourceChapters, newManga, newSource) @@ -299,6 +300,7 @@ internal class MigrateDialogScreenModel( chapterFlags = oldManga.chapterFlags, viewerFlags = oldManga.viewerFlags, dateAdded = if (replace) oldManga.dateAdded else Instant.now().toEpochMilli(), + notes = if (migrateNotes) oldManga.notes else null, ), ) } diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreen.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreen.kt index 0d922d4a4..ef31803ea 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreen.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreen.kt @@ -50,6 +50,7 @@ import eu.kanade.tachiyomi.ui.browse.source.browse.BrowseSourceScreen import eu.kanade.tachiyomi.ui.browse.source.globalsearch.GlobalSearchScreen import eu.kanade.tachiyomi.ui.category.CategoryScreen import eu.kanade.tachiyomi.ui.home.HomeScreen +import eu.kanade.tachiyomi.ui.manga.notes.MangaNotesScreen import eu.kanade.tachiyomi.ui.manga.track.TrackInfoDialogHomeScreen import eu.kanade.tachiyomi.ui.reader.ReaderActivity import eu.kanade.tachiyomi.ui.setting.SettingsScreen @@ -164,6 +165,7 @@ class MangaScreen( onMigrateClicked = { navigator.push(MigrateSearchScreen(successState.manga.id)) }.takeIf { successState.manga.favorite }, + onEditNotesClicked = { navigator.push(MangaNotesScreen(manga = successState.manga)) }, onMultiBookmarkClicked = screenModel::bookmarkChapters, onMultiMarkAsReadClicked = screenModel::markChaptersRead, onMarkPreviousAsReadClicked = screenModel::markPreviousChapterRead, diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/manga/notes/MangaNotesScreen.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/manga/notes/MangaNotesScreen.kt new file mode 100644 index 000000000..03ee92df1 --- /dev/null +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/manga/notes/MangaNotesScreen.kt @@ -0,0 +1,61 @@ +package eu.kanade.tachiyomi.ui.manga.notes + +import androidx.compose.runtime.Composable +import androidx.compose.runtime.Immutable +import androidx.compose.runtime.collectAsState +import androidx.compose.runtime.getValue +import cafe.adriel.voyager.core.model.StateScreenModel +import cafe.adriel.voyager.core.model.rememberScreenModel +import cafe.adriel.voyager.core.model.screenModelScope +import cafe.adriel.voyager.navigator.LocalNavigator +import cafe.adriel.voyager.navigator.currentOrThrow +import eu.kanade.presentation.manga.MangaNotesScreen +import eu.kanade.presentation.util.Screen +import kotlinx.coroutines.flow.update +import tachiyomi.core.common.util.lang.launchNonCancellable +import tachiyomi.domain.manga.interactor.UpdateMangaNotes +import tachiyomi.domain.manga.model.Manga +import uy.kohesive.injekt.Injekt +import uy.kohesive.injekt.api.get + +class MangaNotesScreen( + private val manga: Manga, +) : Screen() { + @Composable + override fun Content() { + val navigator = LocalNavigator.currentOrThrow + + val screenModel = rememberScreenModel { Model(manga) } + val state by screenModel.state.collectAsState() + + MangaNotesScreen( + state = state, + navigateUp = navigator::pop, + onUpdate = screenModel::updateNotes, + ) + } + + private class Model( + private val manga: Manga, + private val updateMangaNotes: UpdateMangaNotes = Injekt.get(), + ) : StateScreenModel(State(manga, manga.notes)) { + + fun updateNotes(content: String) { + if (content == state.value.notes) return + + mutableState.update { + it.copy(notes = content) + } + + screenModelScope.launchNonCancellable { + updateMangaNotes(manga.id, content) + } + } + } + + @Immutable + data class State( + val manga: Manga, + val notes: String, + ) +} diff --git a/data/src/main/java/tachiyomi/data/manga/MangaMapper.kt b/data/src/main/java/tachiyomi/data/manga/MangaMapper.kt index 53b45ad09..b4c13b349 100644 --- a/data/src/main/java/tachiyomi/data/manga/MangaMapper.kt +++ b/data/src/main/java/tachiyomi/data/manga/MangaMapper.kt @@ -31,6 +31,7 @@ object MangaMapper { version: Long, @Suppress("UNUSED_PARAMETER") isSyncing: Long, + notes: String, ): Manga = Manga( id = id, source = source, @@ -55,6 +56,7 @@ object MangaMapper { lastModifiedAt = lastModifiedAt, favoriteModifiedAt = favoriteModifiedAt, version = version, + notes = notes, ) fun mapLibraryManga( @@ -82,6 +84,7 @@ object MangaMapper { favoriteModifiedAt: Long?, version: Long, isSyncing: Long, + notes: String, totalCount: Long, readCount: Double, latestUpload: Long, @@ -115,6 +118,7 @@ object MangaMapper { favoriteModifiedAt, version, isSyncing, + notes, ), category = category, totalChapters = totalCount, diff --git a/data/src/main/java/tachiyomi/data/manga/MangaRepositoryImpl.kt b/data/src/main/java/tachiyomi/data/manga/MangaRepositoryImpl.kt index ae6c8d340..6c67f638b 100644 --- a/data/src/main/java/tachiyomi/data/manga/MangaRepositoryImpl.kt +++ b/data/src/main/java/tachiyomi/data/manga/MangaRepositoryImpl.kt @@ -171,6 +171,7 @@ class MangaRepositoryImpl( updateStrategy = value.updateStrategy?.let(UpdateStrategyColumnAdapter::encode), version = value.version, isSyncing = 0, + notes = value.notes, ) } } diff --git a/data/src/main/sqldelight/tachiyomi/data/mangas.sq b/data/src/main/sqldelight/tachiyomi/data/mangas.sq index e3cb8076a..bfc57713d 100644 --- a/data/src/main/sqldelight/tachiyomi/data/mangas.sq +++ b/data/src/main/sqldelight/tachiyomi/data/mangas.sq @@ -27,7 +27,8 @@ CREATE TABLE mangas( last_modified_at INTEGER NOT NULL DEFAULT 0, favorite_modified_at INTEGER, version INTEGER NOT NULL DEFAULT 0, - is_syncing INTEGER NOT NULL DEFAULT 0 + is_syncing INTEGER NOT NULL DEFAULT 0, + notes TEXT NOT NULL DEFAULT "" ); CREATE INDEX library_favorite_index ON mangas(favorite) WHERE favorite = 1; @@ -175,7 +176,8 @@ UPDATE mangas SET update_strategy = coalesce(:updateStrategy, update_strategy), calculate_interval = coalesce(:calculateInterval, calculate_interval), version = coalesce(:version, version), - is_syncing = coalesce(:isSyncing, is_syncing) + is_syncing = coalesce(:isSyncing, is_syncing), + notes = coalesce(:notes, notes) WHERE _id = :mangaId; selectLastInsertedRowId: diff --git a/data/src/main/sqldelight/tachiyomi/migrations/5.sqm b/data/src/main/sqldelight/tachiyomi/migrations/5.sqm new file mode 100644 index 000000000..0cc85ecf4 --- /dev/null +++ b/data/src/main/sqldelight/tachiyomi/migrations/5.sqm @@ -0,0 +1,3 @@ +-- Add notes column +ALTER TABLE mangas +ADD notes TEXT NOT NULL DEFAULT ""; diff --git a/domain/src/main/java/tachiyomi/domain/manga/interactor/UpdateMangaNotes.kt b/domain/src/main/java/tachiyomi/domain/manga/interactor/UpdateMangaNotes.kt new file mode 100644 index 000000000..cadb3aed7 --- /dev/null +++ b/domain/src/main/java/tachiyomi/domain/manga/interactor/UpdateMangaNotes.kt @@ -0,0 +1,18 @@ +package tachiyomi.domain.manga.interactor + +import tachiyomi.domain.manga.model.MangaUpdate +import tachiyomi.domain.manga.repository.MangaRepository + +class UpdateMangaNotes( + private val mangaRepository: MangaRepository, +) { + + suspend operator fun invoke(mangaId: Long, notes: String): Boolean { + return mangaRepository.update( + MangaUpdate( + id = mangaId, + notes = notes, + ), + ) + } +} diff --git a/domain/src/main/java/tachiyomi/domain/manga/model/Manga.kt b/domain/src/main/java/tachiyomi/domain/manga/model/Manga.kt index fb634c1cd..2402fddb7 100644 --- a/domain/src/main/java/tachiyomi/domain/manga/model/Manga.kt +++ b/domain/src/main/java/tachiyomi/domain/manga/model/Manga.kt @@ -32,6 +32,7 @@ data class Manga( val lastModifiedAt: Long, val favoriteModifiedAt: Long?, val version: Long, + val notes: String, ) : Serializable { val expectedNextUpdate: Instant? @@ -126,6 +127,7 @@ data class Manga( lastModifiedAt = 0L, favoriteModifiedAt = null, version = 0L, + notes = "", ) } } diff --git a/domain/src/main/java/tachiyomi/domain/manga/model/MangaUpdate.kt b/domain/src/main/java/tachiyomi/domain/manga/model/MangaUpdate.kt index 7f1cc2f87..67882d848 100644 --- a/domain/src/main/java/tachiyomi/domain/manga/model/MangaUpdate.kt +++ b/domain/src/main/java/tachiyomi/domain/manga/model/MangaUpdate.kt @@ -24,6 +24,7 @@ data class MangaUpdate( val updateStrategy: UpdateStrategy? = null, val initialized: Boolean? = null, val version: Long? = null, + val notes: String? = null, ) fun Manga.toMangaUpdate(): MangaUpdate { @@ -49,5 +50,6 @@ fun Manga.toMangaUpdate(): MangaUpdate { updateStrategy = updateStrategy, initialized = initialized, version = version, + notes = notes, ) } diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml index 47adac9ac..7cc1310bb 100644 --- a/gradle/libs.versions.toml +++ b/gradle/libs.versions.toml @@ -56,6 +56,8 @@ natural-comparator = "com.github.gpanther:java-nat-sort:natural-comparator-1.1" richtext-commonmark = { module = "com.halilibo.compose-richtext:richtext-commonmark", version.ref = "richtext" } richtext-m3 = { module = "com.halilibo.compose-richtext:richtext-ui-material3", version.ref = "richtext" } +richeditor-compose = "com.mohamedrejeb.richeditor:richeditor-compose:1.0.0-rc10" + material = "com.google.android.material:material:1.12.0" flexible-adapter-core = "com.github.arkon.FlexibleAdapter:flexible-adapter:c8013533" photoview = "com.github.chrisbanes:PhotoView:2.3.0" diff --git a/i18n/src/commonMain/moko-resources/base/strings.xml b/i18n/src/commonMain/moko-resources/base/strings.xml index a322d92dd..ccf56dbc3 100644 --- a/i18n/src/commonMain/moko-resources/base/strings.xml +++ b/i18n/src/commonMain/moko-resources/base/strings.xml @@ -147,6 +147,8 @@ Move series to top Move to bottom Move series to bottom + Notes + Edit notes Install Share Save @@ -983,4 +985,7 @@ HTTP %d, check website in WebView No Internet connection Couldn\'t reach %s + + + Enjoyed the part where…