mirror of
				https://github.com/mihonapp/mihon.git
				synced 2025-11-04 08:08:55 +01:00 
			
		
		
		
	Allow manga titles to update from source if they are not in library (#6177)
The previous rationale for not allowing manga titles to update (at all) was that it would be confusing for users if a manga's title arbitrarily changed when the source changed it. Presumably, users would care less about this arbitrary change for manga that is not in library, so this provides a path for getting a manga's title updated, and prevents incorrect titles from persisting in the DB for manga that get title updates but aren't in library.
This commit is contained in:
		@@ -202,6 +202,10 @@ open class BrowseSourcePresenter(
 | 
			
		||||
            val result = db.insertManga(newManga).executeAsBlocking()
 | 
			
		||||
            newManga.id = result.insertedId()
 | 
			
		||||
            localManga = newManga
 | 
			
		||||
        } else if (!localManga.favorite) {
 | 
			
		||||
            // if the manga isn't a favorite, set its display title from source
 | 
			
		||||
            // if it later becomes a favorite, updated title will go to db
 | 
			
		||||
            localManga.title = sManga.title
 | 
			
		||||
        }
 | 
			
		||||
        return localManga
 | 
			
		||||
    }
 | 
			
		||||
 
 | 
			
		||||
@@ -267,6 +267,10 @@ open class GlobalSearchPresenter(
 | 
			
		||||
            val result = db.insertManga(newManga).executeAsBlocking()
 | 
			
		||||
            newManga.id = result.insertedId()
 | 
			
		||||
            localManga = newManga
 | 
			
		||||
        } else if (!localManga.favorite) {
 | 
			
		||||
            // if the manga isn't a favorite, set its display title from source
 | 
			
		||||
            // if it later becomes a favorite, updated title will go to db
 | 
			
		||||
            localManga.title = sManga.title
 | 
			
		||||
        }
 | 
			
		||||
        return localManga
 | 
			
		||||
    }
 | 
			
		||||
 
 | 
			
		||||
@@ -204,6 +204,10 @@ class MangaPresenter(
 | 
			
		||||
                val sManga = networkManga.toSManga()
 | 
			
		||||
                manga.prepUpdateCover(coverCache, sManga, manualFetch)
 | 
			
		||||
                manga.copyFrom(sManga)
 | 
			
		||||
                if (!manga.favorite) {
 | 
			
		||||
                    // if the manga isn't a favorite, set its title from source and update in db
 | 
			
		||||
                    manga.title = sManga.title
 | 
			
		||||
                }
 | 
			
		||||
                manga.initialized = true
 | 
			
		||||
                db.insertManga(manga).executeAsBlocking()
 | 
			
		||||
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user