From 503d0be66772c37e08e69e5d022475245b706fd1 Mon Sep 17 00:00:00 2001 From: MajorTanya <39014446+MajorTanya@users.noreply.github.com> Date: Tue, 28 Jan 2025 10:53:26 +0100 Subject: [PATCH] Add zoned "Current time" to debug info and include year & timezone in logcat output (#1672) * Add zoned date & time to debug info & logs This should help distinguish log entries that happened recently and may be related to crashes from older entries that occurred before now. * Change logcat date and time output format After some discussion, it was decided to adjust the logcat date and time display to include the year and the timezone in the logcat output. This results in a line start like this: `2025-01-27 18:37:46.662 +0100` which follows the following DateTimeFormatter pattern: `yyyy-MM-dd HH:mm:ss.SSS Z` * Add CHANGELOG.md entry --- CHANGELOG.md | 3 +++ app/src/main/java/eu/kanade/tachiyomi/util/CrashLogUtil.kt | 5 ++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6bba18064..2cc205e45 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,9 @@ The format is a modified version of [Keep a Changelog](https://keepachangelog.co ### Fixed - Fix MAL `main_picture` nullability breaking search if a result doesn't have a cover set ([@MajorTanya](https://github.com/MajorTanya)) ([#1618](https://github.com/mihonapp/mihon/pull/1618)) +### Other +- Add zoned "Current time" to debug info and include year & timezone in logcat output ([@MajorTanya](https://github.com/MajorTanya)) ([#1672](https://github.com/mihonapp/mihon/pull/1672)) + ## [v0.17.1] - 2024-12-06 ### Changed - Bump default user agent ([@AntsyLich](https://github.com/AntsyLich)) ([`76dcf90`](https://github.com/mihonapp/mihon/commit/76dcf903403d565056f44c66d965c1ea8affffc3)) diff --git a/app/src/main/java/eu/kanade/tachiyomi/util/CrashLogUtil.kt b/app/src/main/java/eu/kanade/tachiyomi/util/CrashLogUtil.kt index ed27314ef..96e52bd44 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/util/CrashLogUtil.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/util/CrashLogUtil.kt @@ -13,6 +13,8 @@ import tachiyomi.core.common.util.lang.withNonCancellableContext import tachiyomi.core.common.util.lang.withUIContext import uy.kohesive.injekt.Injekt import uy.kohesive.injekt.api.get +import java.time.OffsetDateTime +import java.time.ZoneId class CrashLogUtil( private val context: Context, @@ -27,7 +29,7 @@ class CrashLogUtil( getExtensionsInfo()?.let { file.appendText("$it\n\n") } exception?.let { file.appendText("$it\n\n") } - Runtime.getRuntime().exec("logcat *:E -d -f ${file.absolutePath}").waitFor() + Runtime.getRuntime().exec("logcat *:E -d -v year -v zone -f ${file.absolutePath}").waitFor() val uri = file.getUriCompat(context) context.startActivity(uri.toShareIntent(context, "text/plain")) @@ -45,6 +47,7 @@ class CrashLogUtil( Device name: ${Build.DEVICE} (${Build.PRODUCT}) Device model: ${Build.MODEL} WebView: ${WebViewUtil.getVersion(context)} + Current time: ${OffsetDateTime.now(ZoneId.systemDefault())} """.trimIndent() }