mirror/mihon
1
0
Fork 0
mirror of https://github.com/mihonapp/mihon.git synced 2025-10-30 22:07:57 +01:00
Code Issues Packages Projects Releases Wiki Activity

JDK8, lint fixing (#2888)

Browse Source 
* Use Kotlin JDK8

* Satisfy a ton of lints

* Run res/layout files (and manifest) through reformatter
This commit is contained in:
TacoTheDank
2020-04-18 14:47:22 -04:00
committed by GitHub
parent 4fc8800a37
commit 415df2357c
75 changed files with 224 additions and 229 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/src/main/res/layout/categories_item.xml
View File

@@ -33,7 +33,7 @@
android:layout_height="@dimen/material_component_lists_single_line_with_avatar_height"
android:layout_gravity="end"
android:scaleType="center"
android:tint="?android:attr/textColorPrimary"
app:srcCompat="@drawable/ic_reorder_grey_24dp" />
app:srcCompat="@drawable/ic_reorder_grey_24dp"
app:tint="?android:attr/textColorPrimary" />
</FrameLayout>

13
app/src/main/res/layout/chapters_controller.xml
View File

@@ -1,6 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<androidx.coordinatorlayout.widget.CoordinatorLayout
xmlns:android="http://schemas.android.com/apk/res/android"
<androidx.coordinatorlayout.widget.CoordinatorLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
@@ -13,7 +12,7 @@
android:layout_height="match_parent"
android:background="?attr/colorAccent"
android:elevation="5dp"
android:visibility="invisible"/>
android:visibility="invisible" />
<eu.kanade.tachiyomi.widget.ThemedSwipeRefreshLayout
android:id="@+id/swipe_refresh"
@@ -28,9 +27,9 @@
android:layout_height="match_parent"
android:layout_marginStart="16dp"
android:layout_marginEnd="16dp"
android:paddingBottom="@dimen/fab_list_padding"
android:clipToPadding="false"
android:descendantFocusability="blocksDescendants"
android:paddingBottom="@dimen/fab_list_padding"
tools:listitem="@layout/chapters_item" />
</eu.kanade.tachiyomi.widget.ThemedSwipeRefreshLayout>
@@ -42,7 +41,7 @@
android:layout_centerHorizontal="true"
android:layout_gravity="end"
app:fastScrollerBubbleEnabled="false"
tools:visibility="visible"/>
tools:visibility="visible" />
<eu.kanade.tachiyomi.widget.ActionToolbar
android:id="@+id/action_toolbar"
@@ -54,7 +53,7 @@
android:id="@+id/fab"
style="@style/Theme.Widget.FAB"
android:text="@string/action_resume"
app:layout_anchor="@id/recycler"
app:icon="@drawable/ic_play_arrow_24dp" />
app:icon="@drawable/ic_play_arrow_24dp"
app:layout_anchor="@id/recycler" />
</androidx.coordinatorlayout.widget.CoordinatorLayout>

6
app/src/main/res/layout/chapters_item.xml
View File

@@ -5,8 +5,8 @@
android:layout_width="fill_parent"
android:layout_height="?android:attr/listPreferredItemHeight"
android:background="@drawable/list_item_selector"
android:paddingEnd="16dp"
android:paddingStart="16dp">
android:paddingStart="16dp"
android:paddingEnd="16dp">
<TextView
android:id="@+id/chapter_title"
@@ -29,8 +29,8 @@
android:layout_marginBottom="8dp"
android:ellipsize="end"
android:singleLine="true"
app:layout_constraintEnd_toStartOf="@+id/download_text"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toStartOf="@+id/download_text"
app:layout_constraintStart_toStartOf="parent"
tools:text="22/02/2016 • Scanlator • Page: 45" />

6
app/src/main/res/layout/common_action_toolbar.xml
View File

@@ -10,11 +10,11 @@
android:layout_height="?attr/actionBarSize"
android:layout_gravity="bottom"
android:background="?attr/colorPrimary"
android:elevation="2dp"
android:theme="?attr/actionBarTheme"
android:visibility="gone"
android:elevation="2dp"
app:contentInsetStart="8dp"
app:contentInsetEnd="8dp">
app:contentInsetEnd="8dp"
app:contentInsetStart="8dp">
<androidx.appcompat.widget.ActionMenuView
android:id="@+id/common_action_menu"

3
app/src/main/res/layout/common_listitem_dir.xml
View File

@@ -1,5 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools"
android:id="@+id/nnf_item_container"
android:layout_width="match_parent"
@@ -18,8 +19,8 @@
android:adjustViewBounds="true"
android:scaleType="center"
android:src="@drawable/nnf_ic_file_folder"
android:tint="?attr/colorAccent"
android:visibility="visible"
app:tint="?attr/colorAccent"
tools:ignore="ContentDescription" />
<TextView

4
app/src/main/res/layout/download_item.xml
View File

@@ -14,11 +14,11 @@
android:layout_alignParentStart="true"
android:layout_gravity="start"
android:scaleType="center"
android:tint="?android:attr/textColorPrimary"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent"
app:srcCompat="@drawable/ic_reorder_grey_24dp" />
app:srcCompat="@drawable/ic_reorder_grey_24dp"
app:tint="?android:attr/textColorPrimary" />
<TextView
android:id="@+id/manga_full_title"

4
app/src/main/res/layout/extension_controller.xml
View File

@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="match_parent">
@@ -25,6 +25,6 @@
android:layout_centerHorizontal="true"
android:layout_gravity="end"
app:fastScrollerBubbleEnabled="false"
tools:visibility="visible"/>
tools:visibility="visible" />
</FrameLayout>

2
app/src/main/res/layout/manga_info_controller.xml
View File

@@ -80,8 +80,8 @@
style="@style/TextAppearance.Medium.Title"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:paddingBottom="8dp"
android:maxLines="2"
android:paddingBottom="8dp"
android:text="@string/manga_info_full_title_label"
android:textIsSelectable="false"
app:autoSizeMaxTextSize="20sp"

2
app/src/main/res/layout/navigation_view_spinner.xml
View File

@@ -1,8 +1,8 @@
<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="?attr/listPreferredItemHeightSmall"
xmlns:tools="http://schemas.android.com/tools"
android:background="?attr/selectableItemBackground"
android:focusable="true"
android:paddingStart="?attr/listPreferredItemPaddingStart"

1
app/src/main/res/layout/navigation_view_text.xml
View File

@@ -3,6 +3,7 @@
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:background="?attr/selectableItemBackground"
android:baselineAligned="false"
android:focusable="true"
android:paddingStart="?attr/listPreferredItemPaddingStart"
android:paddingEnd="?attr/listPreferredItemPaddingEnd">

1
app/src/main/res/layout/pref_library_columns.xml
View File

@@ -3,6 +3,7 @@
xmlns:app="http://schemas.android.com/apk/res-auto"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:baselineAligned="false"
android:orientation="horizontal"
android:paddingStart="@dimen/dialog_content_padding"
android:paddingTop="@dimen/dialog_margin_top_content"

12
app/src/main/res/layout/reader_page_sheet.xml
View File

@@ -19,8 +19,8 @@
<ImageView
android:layout_width="24dp"
android:layout_height="24dp"
android:tint="@color/md_white_1000_54"
app:srcCompat="@drawable/ic_photo_24dp" />
app:srcCompat="@drawable/ic_photo_24dp"
app:tint="@color/md_white_1000_54" />
<TextView
android:layout_width="match_parent"
@@ -44,8 +44,8 @@
<ImageView
android:layout_width="24dp"
android:layout_height="24dp"
android:tint="@color/md_white_1000_54"
app:srcCompat="@drawable/ic_share_24dp" />
app:srcCompat="@drawable/ic_share_24dp"
app:tint="@color/md_white_1000_54" />
<TextView
android:layout_width="match_parent"
@@ -69,8 +69,8 @@
<ImageView
android:layout_width="24dp"
android:layout_height="24dp"
android:tint="@color/md_white_1000_54"
app:srcCompat="@drawable/ic_file_download_black_24dp" />
app:srcCompat="@drawable/ic_file_download_black_24dp"
app:tint="@color/md_white_1000_54" />
<TextView
android:layout_width="match_parent"

6
app/src/main/res/layout/reader_settings_sheet.xml
View File

@@ -260,9 +260,9 @@
android:layout_width="0dp"
android:layout_height="wrap_content"
android:text="@string/pref_webtoon_side_padding"
app:layout_constraintBaseline_toBaselineOf="@id/webtoon_side_padding"
app:layout_constraintLeft_toLeftOf="parent"
app:layout_constraintRight_toLeftOf="@id/verticalcenter"
app:layout_constraintBaseline_toBaselineOf="@id/webtoon_side_padding"/>
app:layout_constraintRight_toLeftOf="@id/verticalcenter" />
<androidx.appcompat.widget.AppCompatSpinner
android:id="@+id/webtoon_side_padding"
@@ -272,7 +272,7 @@
android:entries="@array/webtoon_side_padding"
app:layout_constraintLeft_toRightOf="@id/verticalcenter"
app:layout_constraintRight_toRightOf="@id/spinner_end"
app:layout_constraintTop_toBottomOf="@id/crop_borders_webtoon"/>
app:layout_constraintTop_toBottomOf="@id/crop_borders_webtoon" />
<!-- Groups of preferences -->

4
app/src/main/res/layout/source_filter_sheet.xml
View File

@@ -21,10 +21,10 @@
android:alpha="0.5"
android:scaleType="fitCenter"
android:src="@drawable/ic_drag_pill_24dp"
android:tint="?attr/colorOnBackground"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" />
app:layout_constraintTop_toTopOf="parent"
app:tint="?attr/colorOnBackground" />
<Button
android:id="@+id/reset_btn"

2
app/src/main/res/layout/source_grid_item.xml
View File

@@ -98,6 +98,7 @@
android:layout_height="wrap_content"
android:layout_gravity="bottom"
android:ellipsize="end"
android:fontFamily="@font/ptsans_narrow_bold"
android:lineSpacingExtra="-4dp"
android:maxLines="2"
android:padding="8dp"
@@ -105,7 +106,6 @@
android:shadowDx="0"
android:shadowDy="0"
android:shadowRadius="4"
android:fontFamily="@font/ptsans_narrow_bold"
tools:text="Sample name" />
<ProgressBar

4
app/src/main/res/layout/source_main_controller.xml
View File

@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="wrap_content">
@@ -18,6 +18,6 @@
android:layout_centerHorizontal="true"
android:layout_gravity="end"
app:fastScrollerBubbleEnabled="false"
tools:visibility="visible"/>
tools:visibility="visible" />
</FrameLayout>

2
app/src/main/res/layout/updates_controller.xml
View File

@@ -13,9 +13,9 @@
android:id="@+id/recycler"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:clipToPadding="false"
android:descendantFocusability="blocksDescendants"
android:paddingBottom="?attr/actionBarSize"
android:clipToPadding="false"
tools:listitem="@layout/updates_item" />
<eu.kanade.tachiyomi.widget.ActionToolbar

4
app/src/main/res/layout/updates_item.xml
View File

@@ -4,8 +4,8 @@
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="@dimen/material_component_lists_two_line_height"
android:paddingEnd="16dp"
android:background="@drawable/list_item_selector">
android:background="@drawable/list_item_selector"
android:paddingEnd="16dp">
<ImageView
android:id="@+id/manga_cover"