From 412815af067cdf343a6b5c7b5cd38eeb8190d543 Mon Sep 17 00:00:00 2001 From: AntsyLich <59261191+AntsyLich@users.noreply.github.com> Date: Fri, 7 Nov 2025 19:07:14 +0600 Subject: [PATCH] Revert "Fix reader tap zones triggering after scrolling was stopped by the user" (#2670) --- CHANGELOG.md | 10 ++++++---- .../viewer/webtoon/WebtoonRecyclerView.kt | 17 +---------------- 2 files changed, 7 insertions(+), 20 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8b69ff808..4be1003b6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,15 +10,17 @@ The format is a modified version of [Keep a Changelog](https://keepachangelog.co - `Fixed` - for any bug fixes. - `Other` - for technical stuff. -## [Unreleased] +## [v0.19.3] - 2025-11-07 ### Improved -- Improved various aspects of the WebView multi window support added in 0.19.2 ([@TheUnlocked](https://github.com/TheUnlocked)) ([#2662](https://github.com/mihonapp/mihon/pull/2662)) +- Improved various aspects of the WebView multi window support ([@TheUnlocked](https://github.com/TheUnlocked)) ([#2662](https://github.com/mihonapp/mihon/pull/2662)) + +### Removed +- Revert "Fix reader tap zones triggering after scrolling was stopped by the user" due to introduction of regression ([@AntsyLich](https://github.com/AntsyLich)) ([#2670](https://github.com/mihonapp/mihon/pull/2670)) -## [v0.19.3] - 2025-11-04 ### Fixed - Fix WebView crash introduced in 0.19.2 ([@bapeey](https://github.com/bapeey)) ([#2649](https://github.com/mihonapp/mihon/pull/2649)) -- Fix long strip reader not scrolling on consecutive taps ([@AntsyLich](https://github.com/AntsyLich)) ([#2650](https://github.com/mihonapp/mihon/pull/2650)) - Fix extra padding appearing in reader after user interactions ([@AntsyLich](https://github.com/AntsyLich)) ([#2669](https://github.com/mihonapp/mihon/pull/2669)) +- Fix long strip reader not scrolling on consecutive taps ([@AntsyLich](https://github.com/AntsyLich)) ([#2670](https://github.com/mihonapp/mihon/pull/2670)) ## [v0.19.2] - 2025-11-02 ### Added diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/webtoon/WebtoonRecyclerView.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/webtoon/WebtoonRecyclerView.kt index cc87af36c..95cef7345 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/webtoon/WebtoonRecyclerView.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/webtoon/WebtoonRecyclerView.kt @@ -2,7 +2,6 @@ package eu.kanade.tachiyomi.ui.reader.viewer.webtoon import android.animation.AnimatorSet import android.animation.ValueAnimator -import android.annotation.SuppressLint import android.content.Context import android.util.AttributeSet import android.view.HapticFeedbackConstants @@ -35,10 +34,6 @@ class WebtoonRecyclerView @JvmOverloads constructor( private var firstVisibleItemPosition = 0 private var lastVisibleItemPosition = 0 private var currentScale = DEFAULT_RATE - - private var isManuallyScrolling = false - private var hasTappedWhileScrolling = false - var zoomOutDisabled = false set(value) { field = value @@ -67,11 +62,7 @@ class WebtoonRecyclerView @JvmOverloads constructor( super.onMeasure(widthSpec, heightSpec) } - @SuppressLint("ClickableViewAccessibility") override fun onTouchEvent(e: MotionEvent): Boolean { - if (e.actionMasked == MotionEvent.ACTION_DOWN) { - hasTappedWhileScrolling = isManuallyScrolling - } detector.onTouchEvent(e) return super.onTouchEvent(e) } @@ -91,9 +82,6 @@ class WebtoonRecyclerView @JvmOverloads constructor( val totalItemCount = layoutManager?.itemCount ?: 0 atLastPosition = visibleItemCount > 0 && lastVisibleItemPosition == totalItemCount - 1 atFirstPosition = firstVisibleItemPosition == 0 - if (state == SCROLL_STATE_IDLE) { - isManuallyScrolling = false - } } private fun getPositionX(positionX: Float): Float { @@ -227,9 +215,7 @@ class WebtoonRecyclerView @JvmOverloads constructor( inner class GestureListener : GestureDetectorWithLongTap.Listener() { override fun onSingleTapConfirmed(ev: MotionEvent): Boolean { - if (!hasTappedWhileScrolling) { - tapListener?.invoke(ev) - } + tapListener?.invoke(ev) return false } @@ -323,7 +309,6 @@ class WebtoonRecyclerView @JvmOverloads constructor( if (startScroll) { isZoomDragging = true - isManuallyScrolling = true } }