From 3d3c36078a3b8cb741adffd46931aeab9cb38578 Mon Sep 17 00:00:00 2001 From: Secozzi <49240133+Secozzi@users.noreply.github.com> Date: Mon, 11 Aug 2025 18:01:07 +0200 Subject: [PATCH] Don't hardcode app name in `strings.xml` (#2394) --- .../screen/browse/components/ExtensionReposDialogs.kt | 2 +- .../java/eu/kanade/tachiyomi/data/download/Downloader.kt | 5 ++++- i18n/src/commonMain/moko-resources/base/strings.xml | 4 ++-- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/eu/kanade/presentation/more/settings/screen/browse/components/ExtensionReposDialogs.kt b/app/src/main/java/eu/kanade/presentation/more/settings/screen/browse/components/ExtensionReposDialogs.kt index 80cada76b..39a57d4f8 100644 --- a/app/src/main/java/eu/kanade/presentation/more/settings/screen/browse/components/ExtensionReposDialogs.kt +++ b/app/src/main/java/eu/kanade/presentation/more/settings/screen/browse/components/ExtensionReposDialogs.kt @@ -57,7 +57,7 @@ fun ExtensionRepoCreateDialog( }, text = { Column { - Text(text = stringResource(MR.strings.action_add_repo_message)) + Text(text = stringResource(MR.strings.action_add_repo_message, stringResource(MR.strings.app_name))) OutlinedTextField( modifier = Modifier diff --git a/app/src/main/java/eu/kanade/tachiyomi/data/download/Downloader.kt b/app/src/main/java/eu/kanade/tachiyomi/data/download/Downloader.kt index 72949f410..820fb51ae 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/data/download/Downloader.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/data/download/Downloader.kt @@ -299,7 +299,10 @@ class Downloader( maxDownloadsFromSource > CHAPTERS_PER_SOURCE_QUEUE_WARNING_THRESHOLD ) { notifier.onWarning( - context.stringResource(MR.strings.download_queue_size_warning), + context.stringResource( + MR.strings.download_queue_size_warning, + context.stringResource(MR.strings.app_name), + ), WARNING_NOTIF_TIMEOUT_MS, NotificationHandler.openUrl(context, LibraryUpdateNotifier.HELP_WARNING_URL), ) diff --git a/i18n/src/commonMain/moko-resources/base/strings.xml b/i18n/src/commonMain/moko-resources/base/strings.xml index 269bffb21..074cac6f0 100644 --- a/i18n/src/commonMain/moko-resources/base/strings.xml +++ b/i18n/src/commonMain/moko-resources/base/strings.xml @@ -364,7 +364,7 @@ You have no repos set. Add repo Repo URL - Add additional repos to Mihon. This should be a URL that ends with \"index.min.json\". + Add additional repos to %s. This should be a URL that ends with \"index.min.json\". This repo already exists! Delete repo Invalid repo URL @@ -904,7 +904,7 @@ Couldn\'t download chapters. You can try again in the downloads section Couldn\'t download chapters due to low storage space - Warning: large bulk downloads may lead to sources becoming slower and/or blocking Mihon. Tap to learn more. + Warning: large bulk downloads may lead to sources becoming slower and/or blocking %s. Tap to learn more. Updating library… (%s)