mirror of
				https://github.com/mihonapp/mihon.git
				synced 2025-11-04 16:18:55 +01:00 
			
		
		
		
	Provide more human readable error when downloading to invalid directory (#2462)
This commit is contained in:
		@@ -3,6 +3,7 @@ package eu.kanade.tachiyomi.data.download
 | 
			
		||||
import android.content.Context
 | 
			
		||||
import android.net.Uri
 | 
			
		||||
import com.hippo.unifile.UniFile
 | 
			
		||||
import eu.kanade.tachiyomi.R
 | 
			
		||||
import eu.kanade.tachiyomi.data.database.models.Chapter
 | 
			
		||||
import eu.kanade.tachiyomi.data.database.models.Manga
 | 
			
		||||
import eu.kanade.tachiyomi.data.preference.PreferencesHelper
 | 
			
		||||
@@ -46,9 +47,13 @@ class DownloadProvider(private val context: Context) {
 | 
			
		||||
     * @param source the source of the manga.
 | 
			
		||||
     */
 | 
			
		||||
    internal fun getMangaDir(manga: Manga, source: Source): UniFile {
 | 
			
		||||
        return downloadsDir
 | 
			
		||||
                .createDirectory(getSourceDirName(source))
 | 
			
		||||
                .createDirectory(getMangaDirName(manga))
 | 
			
		||||
        try {
 | 
			
		||||
            return downloadsDir
 | 
			
		||||
                    .createDirectory(getSourceDirName(source))
 | 
			
		||||
                    .createDirectory(getMangaDirName(manga))
 | 
			
		||||
        } catch (e: NullPointerException) {
 | 
			
		||||
            throw Exception(context.getString(R.string.invalid_download_dir))
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    /**
 | 
			
		||||
 
 | 
			
		||||
@@ -102,7 +102,7 @@ class Downloader(
 | 
			
		||||
        pending.forEach { if (it.status != Download.QUEUE) it.status = Download.QUEUE }
 | 
			
		||||
 | 
			
		||||
        downloadsRelay.call(pending)
 | 
			
		||||
        return !pending.isEmpty()
 | 
			
		||||
        return pending.isNotEmpty()
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    /**
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user