Use ShapeableImageView for rounded thumbnails instead of Coil transformations

This commit is contained in:
arkon
2021-08-31 22:35:52 -04:00
parent 59aef13200
commit 0e26abf7a6
11 changed files with 21 additions and 38 deletions

View File

@ -3,9 +3,7 @@ package eu.kanade.tachiyomi.ui.browse.migration.manga
import android.view.View
import coil.clear
import coil.loadAny
import coil.transform.RoundedCornersTransformation
import eu.davidea.viewholders.FlexibleViewHolder
import eu.kanade.tachiyomi.R
import eu.kanade.tachiyomi.databinding.SourceListItemBinding
class MigrationMangaHolder(
@ -24,11 +22,8 @@ class MigrationMangaHolder(
fun bind(item: MigrationMangaItem) {
binding.title.text = item.manga.title
// Update the cover.
val radius = itemView.context.resources.getDimension(R.dimen.card_radius)
// Update the cover
binding.thumbnail.clear()
binding.thumbnail.loadAny(item.manga) {
transformations(RoundedCornersTransformation(radius))
}
binding.thumbnail.loadAny(item.manga)
}
}

View File

@ -4,7 +4,6 @@ import android.view.View
import androidx.core.view.isVisible
import coil.clear
import coil.loadAny
import coil.transform.RoundedCornersTransformation
import eu.davidea.flexibleadapter.FlexibleAdapter
import eu.kanade.tachiyomi.R
import eu.kanade.tachiyomi.data.coil.MangaCoverFetcher
@ -53,10 +52,8 @@ class SourceListHolder(private val view: View, adapter: FlexibleAdapter<*>) :
override fun setImage(manga: Manga) {
binding.thumbnail.clear()
if (!manga.thumbnail_url.isNullOrEmpty()) {
val radius = view.context.resources.getDimension(R.dimen.card_radius)
binding.thumbnail.loadAny(manga) {
setParameter(MangaCoverFetcher.USE_CUSTOM_COVER, false)
transformations(RoundedCornersTransformation(radius))
}
}
}

View File

@ -4,9 +4,7 @@ import android.view.View
import androidx.core.view.isVisible
import coil.clear
import coil.loadAny
import coil.transform.RoundedCornersTransformation
import eu.davidea.flexibleadapter.FlexibleAdapter
import eu.kanade.tachiyomi.R
import eu.kanade.tachiyomi.databinding.SourceListItemBinding
/**
@ -57,11 +55,8 @@ class LibraryListHolder(
onLongClick(itemView)
}
// Update the cover.
val radius = view.context.resources.getDimension(R.dimen.card_radius)
// Update the cover
binding.thumbnail.clear()
binding.thumbnail.loadAny(item.manga) {
transformations(RoundedCornersTransformation(radius))
}
binding.thumbnail.loadAny(item.manga)
}
}

View File

@ -4,10 +4,8 @@ import androidx.core.view.isVisible
import androidx.recyclerview.widget.RecyclerView
import coil.clear
import coil.loadAny
import coil.transform.RoundedCornersTransformation
import eu.kanade.tachiyomi.data.track.model.TrackSearch
import eu.kanade.tachiyomi.databinding.TrackSearchItemBinding
import eu.kanade.tachiyomi.util.system.dpToPx
import java.util.Locale
class TrackSearchHolder(
@ -24,9 +22,7 @@ class TrackSearchHolder(
binding.trackSearchTitle.text = track.title
binding.trackSearchCover.clear()
if (track.cover_url.isNotEmpty()) {
binding.trackSearchCover.loadAny(track.cover_url) {
transformations(RoundedCornersTransformation(6.dpToPx.toFloat()))
}
binding.trackSearchCover.loadAny(track.cover_url)
}
val hasStatus = track.publishing_status.isNotBlank()

View File

@ -3,7 +3,6 @@ package eu.kanade.tachiyomi.ui.recent.history
import android.view.View
import coil.clear
import coil.loadAny
import coil.transform.RoundedCornersTransformation
import eu.davidea.viewholders.FlexibleViewHolder
import eu.kanade.tachiyomi.R
import eu.kanade.tachiyomi.data.database.models.MangaChapterHistory
@ -66,10 +65,7 @@ class HistoryHolder(
}
// Set cover
val radius = itemView.context.resources.getDimension(R.dimen.card_radius)
binding.cover.clear()
binding.cover.loadAny(item.manga) {
transformations(RoundedCornersTransformation(radius))
}
binding.cover.loadAny(item.manga)
}
}

View File

@ -4,8 +4,6 @@ import android.view.View
import androidx.core.view.isVisible
import coil.clear
import coil.loadAny
import coil.transform.RoundedCornersTransformation
import eu.kanade.tachiyomi.R
import eu.kanade.tachiyomi.databinding.UpdatesItemBinding
import eu.kanade.tachiyomi.source.LocalSource
import eu.kanade.tachiyomi.ui.manga.chapter.base.BaseChapterHolder
@ -55,10 +53,7 @@ class UpdatesHolder(private val view: View, private val adapter: UpdatesAdapter)
binding.download.setState(item.status, item.progress)
// Set cover
val radius = itemView.context.resources.getDimension(R.dimen.card_radius)
binding.mangaCover.clear()
binding.mangaCover.loadAny(item.manga) {
transformations(RoundedCornersTransformation(radius))
}
binding.mangaCover.loadAny(item.manga)
}
}