Use Compose for reader transition chapter info (#9373)

app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/ReaderTransitionView.kt

@@ -1,30 +1,17 @@
 package eu.kanade.tachiyomi.ui.reader.viewer
 
 import android.content.Context
-import android.text.SpannableStringBuilder
-import android.text.style.ImageSpan
 import android.util.AttributeSet
-import android.view.LayoutInflater
-import android.widget.LinearLayout
-import androidx.core.content.ContextCompat
-import androidx.core.text.bold
-import androidx.core.text.buildSpannedString
-import androidx.core.text.inSpans
-import androidx.core.view.isVisible
-import eu.kanade.tachiyomi.R
+import android.widget.FrameLayout
+import androidx.compose.ui.platform.ComposeView
+import eu.kanade.presentation.reader.ChapterTransition
 import eu.kanade.tachiyomi.data.download.DownloadManager
-import eu.kanade.tachiyomi.databinding.ReaderTransitionViewBinding
-import eu.kanade.tachiyomi.ui.reader.loader.DownloadPageLoader
 import eu.kanade.tachiyomi.ui.reader.model.ChapterTransition
-import eu.kanade.tachiyomi.util.system.dpToPx
+import eu.kanade.tachiyomi.util.view.setComposeContent
 import tachiyomi.domain.manga.model.Manga
-import kotlin.math.roundToInt
 
 class ReaderTransitionView @JvmOverloads constructor(context: Context, attrs: AttributeSet? = null) :
-    LinearLayout(context, attrs) {
-
-    private val binding: ReaderTransitionViewBinding =
-        ReaderTransitionViewBinding.inflate(LayoutInflater.from(context), this, true)
+    FrameLayout(context, attrs) {
 
     init {
         layoutParams = LayoutParams(LayoutParams.WRAP_CONTENT, LayoutParams.WRAP_CONTENT)
@@ -32,133 +19,18 @@ class ReaderTransitionView @JvmOverloads constructor(context: Context, attrs: At
 
     fun bind(transition: ChapterTransition, downloadManager: DownloadManager, manga: Manga?) {
         manga ?: return
-        when (transition) {
-            is ChapterTransition.Prev -> bindPrevChapterTransition(transition, downloadManager, manga)
-            is ChapterTransition.Next -> bindNextChapterTransition(transition, downloadManager, manga)
-        }
-        missingChapterWarning(transition)
-    }
 
-    /**
-     * Binds a previous chapter transition on this view and subscribes to the page load status.
-     */
-    private fun bindPrevChapterTransition(
-        transition: ChapterTransition,
-        downloadManager: DownloadManager,
-        manga: Manga,
-    ) {
-        val prevChapter = transition.to?.chapter
+        removeAllViews()
 
-        binding.lowerText.isVisible = prevChapter != null
-        if (prevChapter != null) {
-            binding.upperText.textAlignment = TEXT_ALIGNMENT_TEXT_START
-            val isPrevDownloaded = downloadManager.isChapterDownloaded(
-                prevChapter.name,
-                prevChapter.scanlator,
-                manga.title,
-                manga.source,
-                skipCache = true,
-            )
-            val isCurrentDownloaded = transition.from.pageLoader is DownloadPageLoader
-            binding.upperText.text = buildSpannedString {
-                bold { append(context.getString(R.string.transition_previous)) }
-                append("\n${prevChapter.name}")
-                if (!prevChapter.scanlator.isNullOrBlank()) {
-                    append(DOT_SEPARATOR)
-                    append("${prevChapter.scanlator}")
-                }
-                if (isPrevDownloaded) addDLImageSpan()
+        val transitionView = ComposeView(context).apply {
+            setComposeContent {
+                ChapterTransition(
+                    transition = transition,
+                    downloadManager = downloadManager,
+                    manga = manga,
+                )
             }
-            binding.lowerText.text = buildSpannedString {
-                bold { append(context.getString(R.string.transition_current)) }
-                append("\n${transition.from.chapter.name}")
-                if (!transition.from.chapter.scanlator.isNullOrBlank()) {
-                    append(DOT_SEPARATOR)
-                    append("${transition.from.chapter.scanlator}")
-                }
-                if (isCurrentDownloaded) addDLImageSpan()
-            }
-        } else {
-            binding.upperText.textAlignment = TEXT_ALIGNMENT_CENTER
-            binding.upperText.text = context.getString(R.string.transition_no_previous)
         }
-    }
-
-    /**
-     * Binds a next chapter transition on this view and subscribes to the load status.
-     */
-    private fun bindNextChapterTransition(
-        transition: ChapterTransition,
-        downloadManager: DownloadManager,
-        manga: Manga,
-    ) {
-        val nextChapter = transition.to?.chapter
-
-        binding.lowerText.isVisible = nextChapter != null
-        if (nextChapter != null) {
-            binding.upperText.textAlignment = TEXT_ALIGNMENT_TEXT_START
-            val isCurrentDownloaded = transition.from.pageLoader is DownloadPageLoader
-            val isNextDownloaded = downloadManager.isChapterDownloaded(
-                nextChapter.name,
-                nextChapter.scanlator,
-                manga.title,
-                manga.source,
-                skipCache = true,
-            )
-            binding.upperText.text = buildSpannedString {
-                bold { append(context.getString(R.string.transition_finished)) }
-                append("\n${transition.from.chapter.name}")
-                if (!transition.from.chapter.scanlator.isNullOrBlank()) {
-                    append(DOT_SEPARATOR)
-                    append("${transition.from.chapter.scanlator}")
-                }
-                if (isCurrentDownloaded) addDLImageSpan()
-            }
-            binding.lowerText.text = buildSpannedString {
-                bold { append(context.getString(R.string.transition_next)) }
-                append("\n${nextChapter.name}")
-                if (!nextChapter.scanlator.isNullOrBlank()) {
-                    append(DOT_SEPARATOR)
-                    append("${nextChapter.scanlator}")
-                }
-                if (isNextDownloaded) addDLImageSpan()
-            }
-        } else {
-            binding.upperText.textAlignment = TEXT_ALIGNMENT_CENTER
-            binding.upperText.text = context.getString(R.string.transition_no_next)
-        }
-    }
-
-    private fun SpannableStringBuilder.addDLImageSpan() {
-        val icon = ContextCompat.getDrawable(context, R.drawable.ic_offline_pin_24dp)?.mutate()
-            ?.apply {
-                val size = binding.lowerText.textSize + 4.dpToPx
-                setTint(binding.lowerText.currentTextColor)
-                setBounds(0, 0, size.roundToInt(), size.roundToInt())
-            } ?: return
-        append(" ")
-        inSpans(ImageSpan(icon)) { append("image") }
-    }
-
-    private fun missingChapterWarning(transition: ChapterTransition) {
-        if (transition.to == null) {
-            binding.warning.isVisible = false
-            return
-        }
-
-        val chapterGap = when (transition) {
-            is ChapterTransition.Prev -> calculateChapterGap(transition.from, transition.to)
-            is ChapterTransition.Next -> calculateChapterGap(transition.to, transition.from)
-        }
-
-        if (chapterGap == 0) {
-            binding.warning.isVisible = false
-            return
-        }
-
-        binding.warningText.text = resources.getQuantityString(R.plurals.missing_chapters_warning, chapterGap.toInt(), chapterGap.toInt())
-        binding.warning.isVisible = true
+        addView(transitionView)
     }
 }
-
-private const val DOT_SEPARATOR = " • "

app/src/main/java/eu/kanade/tachiyomi/util/view/ViewExtensions.kt

@@ -25,6 +25,8 @@ import androidx.compose.material3.MaterialTheme
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.CompositionContext
 import androidx.compose.runtime.CompositionLocalProvider
+import androidx.compose.ui.platform.ComposeView
+import androidx.compose.ui.platform.ViewCompositionStrategy
 import androidx.core.view.forEach
 import com.google.android.material.shape.MaterialShapeDrawable
 import eu.kanade.presentation.theme.TachiyomiTheme
@@ -47,6 +49,22 @@ inline fun ComponentActivity.setComposeContent(
     }
 }
 
+fun ComposeView.setComposeContent(
+    content: @Composable () -> Unit,
+) {
+    setViewCompositionStrategy(ViewCompositionStrategy.DisposeOnViewTreeLifecycleDestroyed)
+    setContent {
+        TachiyomiTheme {
+            CompositionLocalProvider(
+                LocalTextStyle provides MaterialTheme.typography.bodySmall,
+                LocalContentColor provides MaterialTheme.colorScheme.onBackground,
+            ) {
+                content()
+            }
+        }
+    }
+}
+
 /**
  * Adds a tooltip shown on long press.
  *