Move self-building git repository URLs to variables (stop hardcoding)

roles/matrix-registration/defaults/main.yml

@@ -4,6 +4,7 @@
 matrix_registration_enabled: true
 
 matrix_registration_container_image_self_build: false
+matrix_registration_container_image_self_build_repo: "https://github.com/ZerataX/matrix-registration"
 
 matrix_registration_base_path: "{{ matrix_base_data_path }}/matrix-registration"
 matrix_registration_config_path: "{{ matrix_registration_base_path }}/config"
@@ -15,7 +16,6 @@ matrix_registration_version: "v0.7.0"
 matrix_registration_docker_image: "{{ matrix_registration_docker_image_name_prefix }}devture/zeratax-matrix-registration:{{ matrix_registration_version }}"
 matrix_registration_docker_image_name_prefix: "{{ 'localhost/' if matrix_registration_container_image_self_build else 'docker.io/' }}"
 matrix_registration_docker_image_force_pull: "{{ matrix_registration_docker_image.endswith(':latest') }}"
-matrix_registration_docker_repo: "https://github.com/ZerataX/matrix-registration"
 
 # A list of extra arguments to pass to the container
 matrix_registration_container_extra_arguments: []

roles/matrix-registration/tasks/setup.yml

@@ -28,7 +28,7 @@
 
 - name: Ensure matrix-registration repository is present when self-building
   git:
-    repo: "{{ matrix_registration_docker_repo }}"
+    repo: "{{ matrix_registration_container_image_self_build_repo }}"
     dest: "{{ matrix_registration_docker_src_files_path }}"
     version: "{{ matrix_registration_version }}"
     force: "yes"

roles/matrix-registration/tasks/validate_config.yml

@@ -9,3 +9,12 @@
     - "matrix_registration_shared_secret"
     - "matrix_registration_admin_secret"
     - "matrix_registration_server_location"
+
+- name: (Deprecation) Catch and report renamed settings
+  fail:
+    msg: >-
+      Your configuration contains a variable, which now has a different name.
+      Please change your configuration to rename the variable (`{{ item.old }}` -> `{{ item.new }}`).
+  when: "item.old in vars"
+  with_items:
+    - {'old': 'matrix_registration_docker_repo', 'new': 'matrix_registration_container_image_self_build_repo'}