From 58a8f79d951c46b81f1642935b417c0fe2c3a498 Mon Sep 17 00:00:00 2001 From: Slavi Pantaleev Date: Wed, 13 Nov 2024 21:48:18 +0200 Subject: [PATCH] Remove gzip support from synapse-reverse-proxy-companion gzipping certain responses is known to cause problems with QR code logins. Fixes https://github.com/spantaleev/matrix-docker-ansible-deploy/issues/3749 Gzipping at the synapse-reverse-proxy-companion level and not at the level of the outer-most reverse-proxy (Traefik) also sounds non-ideal. This change only affects setups powered by Synapse workers. Non-worker setups (and setups powered by other homeservers) were not having their requests go through synapse-reverse-proxy-companion anyway, so this change does not affect them. Future patches may enable response compression support at the Traefik level for all setups. --- .../conf.d/matrix-synapse-reverse-proxy-companion.conf.j2 | 6 ------ .../templates/nginx/nginx.conf.j2 | 1 - 2 files changed, 7 deletions(-) diff --git a/roles/custom/matrix-synapse-reverse-proxy-companion/templates/nginx/conf.d/matrix-synapse-reverse-proxy-companion.conf.j2 b/roles/custom/matrix-synapse-reverse-proxy-companion/templates/nginx/conf.d/matrix-synapse-reverse-proxy-companion.conf.j2 index 379f2091a..f32fe1e27 100644 --- a/roles/custom/matrix-synapse-reverse-proxy-companion/templates/nginx/conf.d/matrix-synapse-reverse-proxy-companion.conf.j2 +++ b/roles/custom/matrix-synapse-reverse-proxy-companion/templates/nginx/conf.d/matrix-synapse-reverse-proxy-companion.conf.j2 @@ -91,9 +91,6 @@ server { server_tokens off; root /dev/null; - gzip on; - gzip_types text/plain application/json; - {% if matrix_synapse_reverse_proxy_companion_synapse_workers_enabled %} # Client-server overrides -- These locations must go to the main Synapse process location ~ {{ matrix_synapse_reverse_proxy_companion_client_server_main_override_locations_regex }} { @@ -252,9 +249,6 @@ server { root /dev/null; - gzip on; - gzip_types text/plain application/json; - {% if matrix_synapse_reverse_proxy_companion_synapse_workers_enabled %} # Federation overrides -- These locations must go to the main Synapse process location ~ {{ matrix_synapse_reverse_proxy_companion_federation_override_locations_regex }} { diff --git a/roles/custom/matrix-synapse-reverse-proxy-companion/templates/nginx/nginx.conf.j2 b/roles/custom/matrix-synapse-reverse-proxy-companion/templates/nginx/nginx.conf.j2 index 119227634..4c532d1fe 100644 --- a/roles/custom/matrix-synapse-reverse-proxy-companion/templates/nginx/nginx.conf.j2 +++ b/roles/custom/matrix-synapse-reverse-proxy-companion/templates/nginx/nginx.conf.j2 @@ -66,7 +66,6 @@ http { server_tokens off; - #gzip on; {# Map directive needed for proxied WebSocket upgrades #} map $http_upgrade $connection_upgrade { default upgrade;