Fix shellcheck warnings in entrypoint scripts

- Add shellcheck disable=SC1091 for dynamic source paths
- Quote INSTALLED_DIRECTORY variables to prevent word splitting
- Resolves all reported shellcheck issues in PR review

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

.github/workflows/docker-build.yml

@@ -15,7 +15,7 @@ jobs:
     steps:
 
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
 
       - name: Set up QEMU
         uses: docker/setup-qemu-action@v3

.github/workflows/docker-description.yml

@@ -14,7 +14,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
 
       - name: Docker Hub Description
         uses: peter-evans/dockerhub-description@v4.0.2

.github/workflows/lint.yml

@@ -11,7 +11,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
 
       - name: shellcheck
         uses: reviewdog/action-shellcheck@v1
@@ -23,7 +23,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
 
       - name: hadolint
         uses: reviewdog/action-hadolint@v1

.github/workflows/update.yml

@@ -12,7 +12,7 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
         with:
           token: ${{ secrets.REPO_TOKEN }}
 

README.md

@@ -6,17 +6,8 @@
 [中文](./README_zh_CN.md)
 
 <!-- start autogeneration tags -->
-* `latest, 2.0.60`
+* `latest, 2.0.65`
-* `2, 2.0, 2.0.55, stable, stable-2.0.55`
+* `2, 2.0, 2.0.60, stable, stable-2.0.60`
-* `2.0.59`
-* `stable-1.1.110, 1, 1.1, 1.1.110`
-* `1.0.0, 1.0`
-* `0.17.79, 0.17`
-* `0.16.51, 0.16`
-* `0.15.40, 0.15`
-* `0.14.23, 0.14`
-* `0.13.20, 0.13`
-* `0.12.35, 0.12`
 <!-- end autogeneration tags -->
 
 ## Tag descriptions

buildinfo.json

@@ -1,19 +1,19 @@
 {
-  "2.0.55": {
-    "sha256": "ef12a54d1556ae1f84ff99edc23706d13b7ad41f1c02d74ca1dfadf9448fcbae",
-    "tags": [
-      "stable",
-      "stable-2.0.55",
-      "2",
-      "2.0",
-      "2.0.55"
-    ]
-  },
   "2.0.60": {
     "sha256": "69b5be1a867fd99524f9914dfee900a1ac386cf4e74c4a63768c05dc4d2b2b0b",
     "tags": [
-      "latest",
+      "stable",
+      "stable-2.0.60",
+      "2",
+      "2.0",
       "2.0.60"
     ]
+  },
+  "2.0.65": {
+    "sha256": "6b80f0fbeb43753ed7654695ffa427f442496068f2f72129de76cea246a0c63e",
+    "tags": [
+      "latest",
+      "2.0.65"
+    ]
   }
 }

docker/Dockerfile

@@ -54,8 +54,8 @@ RUN apt-get -q update \
     fi \
     && rm -rf /var/lib/apt/lists/*
 
-RUN addgroup --system --gid "$PGID" "$GROUP" \
+RUN groupadd --system --gid "$PGID" "$GROUP" \
-    && adduser --system --uid "$PUID" --gid "$PGID" --no-create-home --disabled-password --shell /bin/sh "$USER"
+    && useradd --system --uid "$PUID" --gid "$PGID" --no-create-home --shell /bin/sh "$USER"
 
 # version checksum of the archive to download
 ARG VERSION

docker/docker-compose.yml

@@ -6,8 +6,8 @@ services:
       args:
         # Check buildinfo.json for supported versions and SHAs
         # https://github.com/factoriotools/factorio-docker/blob/master/buildinfo.json
-        - VERSION=2.0.55
+        - VERSION=2.0.60
-        - SHA256=ef12a54d1556ae1f84ff99edc23706d13b7ad41f1c02d74ca1dfadf9448fcbae
+        - SHA256=69b5be1a867fd99524f9914dfee900a1ac386cf4e74c4a63768c05dc4d2b2b0b
     ports:
       - "34197:34197/udp"
       - "27015:27015/tcp"

docker/files/docker-entrypoint-rootless.sh

@@ -53,10 +53,9 @@ fi
 # In rootless mode, we don't need to handle user switching or chown
 # The container runs as the specified user from the start
 EXEC=""
-if [[ -f /bin/box64 ]]; then
+# Setup ARM64 emulation support
-  # Use emulator for ARM hosts
+# shellcheck disable=SC1091
-  EXEC="/bin/box64"
+source "${INSTALLED_DIRECTORY}/setup-exec.sh"
-fi
 
 # Update config path
 sed -i '/write-data=/c\write-data=\/factorio/' /opt/factorio/config/config.ini

docker/files/docker-entrypoint.sh

@@ -41,10 +41,10 @@ if [[ $NRTMPSAVES -gt 0 ]]; then
 fi
 
 if [[ ${UPDATE_MODS_ON_START:-} == "true" ]]; then
-  ${INSTALLED_DIRECTORY}/docker-update-mods.sh
+  "${INSTALLED_DIRECTORY}"/docker-update-mods.sh
 fi
 
-${INSTALLED_DIRECTORY}/docker-dlc.sh
+"${INSTALLED_DIRECTORY}"/docker-dlc.sh
 
 EXEC=""
 if [[ $(id -u) == 0 ]]; then
@@ -56,11 +56,10 @@ if [[ $(id -u) == 0 ]]; then
   # Drop to the factorio user
   EXEC="runuser -u factorio -g factorio --"
 fi
-if [[ -f /bin/box64 ]]; then
+
-  # Use an emulator to run on ARM hosts
+# Setup ARM64 emulation support
-  # this only gets installed when the target docker platform is linux/arm64
+# shellcheck disable=SC1091
-  EXEC="$EXEC /bin/box64"
+source "${INSTALLED_DIRECTORY}/setup-exec.sh"
-fi
 
 sed -i '/write-data=/c\write-data=\/factorio/' /opt/factorio/config/config.ini
 

docker/files/scenario.sh

@@ -1,5 +1,6 @@
 #!/bin/bash
 set -eoux pipefail
+INSTALLED_DIRECTORY=$(dirname "$(readlink -f "${BASH_SOURCE[0]}")")
 
 if [[ -z ${1:-} ]]; then
   echo "No argument supplied"
@@ -31,7 +32,12 @@ if [[ ! -f $CONFIG/map-settings.json ]]; then
   cp /opt/factorio/data/map-settings.example.json "$CONFIG/map-settings.json"
 fi
 
-exec /opt/factorio/bin/x64/factorio \
+# Setup ARM64 emulation support
+EXEC=""
+# shellcheck disable=SC1091
+source "${INSTALLED_DIRECTORY}/setup-exec.sh"
+
+exec $EXEC /opt/factorio/bin/x64/factorio \
   --port "$PORT" \
   --start-server-load-scenario "$SERVER_SCENARIO" \
   --preset "$PRESET" \

docker/files/scenario2map.sh

@@ -1,5 +1,6 @@
 #!/bin/bash
 set -eoux pipefail
+INSTALLED_DIRECTORY=$(dirname "$(readlink -f "${BASH_SOURCE[0]}")")
 
 if [[ -z ${1:-} ]]; then
   echo "No argument supplied"
@@ -23,5 +24,10 @@ if [[ ! -f $CONFIG/map-settings.json ]]; then
   cp /opt/factorio/data/map-settings.example.json "$CONFIG/map-settings.json"
 fi
 
-exec /opt/factorio/bin/x64/factorio \
+# Setup ARM64 emulation support
+EXEC=""
+# shellcheck disable=SC1091
+source "${INSTALLED_DIRECTORY}/setup-exec.sh"
+
+exec $EXEC /opt/factorio/bin/x64/factorio \
   --scenario2map "$SERVER_SCENARIO"

docker/files/setup-exec.sh

@@ -0,0 +1,16 @@
+#!/bin/bash
+# Setup EXEC variable for running Factorio with ARM64 emulation support
+# This script handles ARM64 emulation and can be combined with user switching as needed
+
+# If EXEC is not already set, initialize it
+if [[ -z "${EXEC:-}" ]]; then
+  EXEC=""
+fi
+
+if [[ -f /bin/box64 ]]; then
+  # Use an emulator to run on ARM hosts
+  # this only gets installed when the target docker platform is linux/arm64
+  EXEC="$EXEC /bin/box64"
+fi
+
+export EXEC

docker/rcon/main.c

@@ -1,3 +1,4 @@
+#define _GNU_SOURCE
 #include <stdio.h>
 #include <stdint.h>
 #include <stdbool.h>
@@ -107,7 +108,8 @@ char* read_password(const char* conf_dir) {
     fseek(fptr, 0, SEEK_SET);  /* same as rewind(f); */
 
     char *password = malloc(fsize + 1);
-    fread(password, fsize, 1, fptr);
+    size_t bytes_read = fread(password, fsize, 1, fptr);
+    (void)bytes_read; // Suppress unused warning
     fclose(fptr);
 
     password[fsize] = 0;