From 17ec12cb7f5a395f83028f48a27583b30e2d758e Mon Sep 17 00:00:00 2001
From: Florian Kinder <florian.kinder@enthus.de>
Date: Sun, 31 Aug 2025 22:31:45 +0900
Subject: [PATCH] Fix shellcheck warnings in entrypoint scripts
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Add shellcheck disable=SC1091 for dynamic source paths
- Quote INSTALLED_DIRECTORY variables to prevent word splitting
- Resolves all reported shellcheck issues in PR review

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
---
 docker/files/docker-entrypoint-rootless.sh | 1 +
 docker/files/docker-entrypoint.sh          | 5 +++--
 docker/files/scenario.sh                   | 1 +
 docker/files/scenario2map.sh               | 1 +
 4 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/docker/files/docker-entrypoint-rootless.sh b/docker/files/docker-entrypoint-rootless.sh
index a1aa8d9..2b91698 100755
--- a/docker/files/docker-entrypoint-rootless.sh
+++ b/docker/files/docker-entrypoint-rootless.sh
@@ -54,6 +54,7 @@ fi
 # The container runs as the specified user from the start
 EXEC=""
 # Setup ARM64 emulation support
+# shellcheck disable=SC1091
 source "${INSTALLED_DIRECTORY}/setup-exec.sh"
 
 # Update config path
diff --git a/docker/files/docker-entrypoint.sh b/docker/files/docker-entrypoint.sh
index 84ef3ce..fd9537b 100755
--- a/docker/files/docker-entrypoint.sh
+++ b/docker/files/docker-entrypoint.sh
@@ -41,10 +41,10 @@ if [[ $NRTMPSAVES -gt 0 ]]; then
 fi
 
 if [[ ${UPDATE_MODS_ON_START:-} == "true" ]]; then
-  ${INSTALLED_DIRECTORY}/docker-update-mods.sh
+  "${INSTALLED_DIRECTORY}"/docker-update-mods.sh
 fi
 
-${INSTALLED_DIRECTORY}/docker-dlc.sh
+"${INSTALLED_DIRECTORY}"/docker-dlc.sh
 
 EXEC=""
 if [[ $(id -u) == 0 ]]; then
@@ -58,6 +58,7 @@ if [[ $(id -u) == 0 ]]; then
 fi
 
 # Setup ARM64 emulation support
+# shellcheck disable=SC1091
 source "${INSTALLED_DIRECTORY}/setup-exec.sh"
 
 sed -i '/write-data=/c\write-data=\/factorio/' /opt/factorio/config/config.ini
diff --git a/docker/files/scenario.sh b/docker/files/scenario.sh
index 4bd2eaa..a98d9d9 100755
--- a/docker/files/scenario.sh
+++ b/docker/files/scenario.sh
@@ -34,6 +34,7 @@ fi
 
 # Setup ARM64 emulation support
 EXEC=""
+# shellcheck disable=SC1091
 source "${INSTALLED_DIRECTORY}/setup-exec.sh"
 
 exec $EXEC /opt/factorio/bin/x64/factorio \
diff --git a/docker/files/scenario2map.sh b/docker/files/scenario2map.sh
index c0a1075..7f40d3a 100755
--- a/docker/files/scenario2map.sh
+++ b/docker/files/scenario2map.sh
@@ -26,6 +26,7 @@ fi
 
 # Setup ARM64 emulation support
 EXEC=""
+# shellcheck disable=SC1091
 source "${INSTALLED_DIRECTORY}/setup-exec.sh"
 
 exec $EXEC /opt/factorio/bin/x64/factorio \