Commit Graph

1975 Commits

Author SHA1 Message Date
Docile-Alligator
af870c157b Swipe to see gallery images in PostDetailRecyclerViewAdapter. 2022-11-14 18:44:07 +11:00
Docile-Alligator
a95c77731a Swipe to see gallery images in HistoryPostFragment. 2022-11-14 17:38:59 +11:00
Docile-Alligator
968b04a508 Send correct image index when opening the image in gallery posts. 2022-11-14 15:17:55 +11:00
Docile-Alligator
746ebc848c Merge remote-tracking branch 'origin/master' 2022-11-14 15:08:14 +11:00
Docile-Alligator
8520c0c8ad Swipe to see images in gallery in gallery layout. 2022-11-14 15:07:15 +11:00
Wladimir Kirianov
05910f5489 add example post form 2022-11-13 17:00:18 +01:00
Docile-Alligator
c44fecb3f2 Fix gallery layout issues. 2022-11-13 18:41:48 +11:00
Docile-Alligator
ef1b14cc6a Swipe to view images in a gallery in Card Layout 2. 2022-11-13 18:25:30 +11:00
Docile-Alligator
2eaf8a8a01 Show correct image in the gallery in ViewRedditGalleryActivity. 2022-11-13 17:00:37 +11:00
Docile-Alligator
2d62332e8d Merge remote-tracking branch 'origin/master' 2022-11-13 16:50:54 +11:00
Docile-Alligator
6f2eea90ae Fix ItemTouchHelper and gallery swipe gesture fighting each other. 2022-11-13 16:50:25 +11:00
Aidan223
cb7805c7a7
Fixed issue where filters applied to same feed were behaving incorrectly (#1172) 2022-11-13 10:56:58 +08:00
Docile-Alligator
b85ed3c867 Show the current image index in gallery in PostFragment. 2022-11-13 01:16:27 +11:00
Docile-Alligator
03a2784fb8 Swipe between gallery images in PostFragment. 2022-11-12 17:53:04 +11:00
Sergei Kozelko
0f1c4d1e11
Switch loading more comments to /morechildren endpoint (#1186)
* Load more comments from /morechildren endpoint

Previous implementation requested comments from /api/info which returned the comments themselves but did not include any information about their children. Also /api/info does not allow to specify sort type. On the other hand /morechildren supports sort type and it will be added in a later commit.

I am not proud of this implementation, but I had to fight with both Reddit api response and existing code. The problem with api response is that it is a flat list of comments, not a tree structure. So the tree has to be rebuilt on our end. And the problem with existing code is that it merges "more children" node into its parent but then adds a placeholder anyways.

The code relies on the fact that parent comment will be located before any of its children in the response. The code sequentially processes comments, tries to find their parents and either adds them to the tree or puts in a "top-level" array which will be handled by outside code.

One possible problem is the removal of `depth` argument from parsing as I couldn't find a way to fit it in the new logic. However I also didn't experience any problems with it during my testing and the response seems to always contain depth key. Moreover current depth handling logic in ParseComment#parseCommentRecursion is broken because it does not increment depth when making a recursive call.

* Store moreChildren ids instead of fullnames

/morechildren endpoint accepts ids instead of fullnames so there is no point in converting ids to fullnames and back

* Send all comment ids to Reddit so it can select what to display itself

Sending all ids allows Reddit to sort them properly. Since the number of comments can be very bing, it requires using POST request instead of GET.

This commit changes the meaning of Comment#moreChildrenIds field, now it stores only ids of comments that are not yet loaded. This simplifies the code and removes the need for Comment#moreChildrenStartingIndex

* Fetch more comments with current sort type
2022-11-11 13:32:58 +08:00
Docile-Alligator
8326e6c4a2 New option: Settings->Interface->Comment->Hide the Number of Votes. 2022-11-09 01:10:07 +11:00
Docile-Alligator
681a1c584c Limit EditText's height in CustomizePostFilterActivity. 2022-11-09 00:12:33 +11:00
Docile-Alligator
071ce78b7c Material Design 3 Switch. Target Sdk 33. 2022-11-08 23:17:26 +11:00
Sergei Kozelko
2c9ffbc614
Fix getting comment for "continue thread" button (#1207)
It used position of viewholder during binding which could get outdated by the time user clicks on the button. This would result in retrieving wrong comment or even null. Replaced with getting comment based on current position of vieholder.
2022-11-08 13:53:39 +08:00
Docile-Alligator
c2360ca59a Modify the behaviour of ItemTouchHelper. 2022-11-07 13:38:55 +11:00
Docile-Alligator
fd63dba91b Fix screen staying at MorePostsInfoFragment after retrying. 2022-11-06 17:37:58 +11:00
Docile-Alligator
93e98b4cb5 Retry loading more posts. 2022-11-06 17:22:15 +11:00
Sergei Kozelko
ff10eb5f92
Load sort type from correct shared preferences (#1202)
When extracting sort type loading logic the shared preferences that are used to load sort type got accidentally changed to the wrong ones. This resulted in always using the default value which is displayed as Best.

Fortunately the saving code was not changed so only reading has to be fixed.
2022-11-05 22:22:02 +08:00
Docile-Alligator
0ae9b74729 Minor changes to loading more posts. 2022-11-06 00:52:14 +11:00
Docile-Alligator
cf3595f22d Fix problems when fetching more history posts in ViewPostDetailActivity. 2022-11-06 00:01:18 +11:00
Docile-Alligator
fa472a3ad8 Show status of loading more posts in MorePostsInfoFragment. 2022-11-05 19:51:40 +11:00
Docile-Alligator
c86408dbe5 Fix history posts problems. 2022-11-05 14:31:58 +11:00
Docile-Alligator
be78c20c07 Load more posts in ViewPostDetailActivity for post feed in HistoryPostFragment. There are bugs in HistoryPostPagingSource so duplicate posts will be fetched and more posts could not be fetched. Will be fixed. 2022-11-05 02:12:03 +11:00
Docile-Alligator
0a286cd9ba Load more posts in ViewPostDetailActivity for post feed in PostFragment. 2022-11-05 00:33:12 +11:00
Docile-Alligator
eb40bad3ef New option: Settings->Interface->Hide FAB in Post Feed. 2022-11-04 01:31:44 +11:00
Docile-Alligator
4abadb78c4 New option in PostFragment: More options. 2022-11-03 22:13:08 +11:00
scria1000
20214ce323
Superscript parser overhaul (#1162)
* Superscript parser overhaul

* Make superscript work with tables

* Fix some issues with Table compatibility

* Some bug fixes

* Re-enable Autolink
2022-11-03 18:07:25 +08:00
Docile-Alligator
e362f2ecf0 Fix issues related to hiding account karma in the navigation drawer. 2022-11-03 15:34:45 +11:00
Docile-Alligator
814617b674 Version 5.3.4. 2022-11-03 14:42:01 +11:00
Docile-Alligator
59c74a2a87 Handle u/me. 2022-11-03 13:58:07 +11:00
Docile-Alligator
4b81d554a8 Fix Separate posts and comments in portrait mode not working. 2022-11-03 13:46:30 +11:00
Docile-Alligator
785bb205f6 Handle invalid regex pattern in post filter. 2022-11-03 13:24:54 +11:00
cmp
15b979d3ba
Add some contrast to subreddit and user toolbars. (#1170)
Add a gradient from the primary theme color to transparent so that if a
subreddit or user profile has a very light background, the usually light
text and buttons are not obscured or in some cases invisible.

The gradients don't appear for immersive mode so that the app remains
immersive.
2022-11-03 10:00:25 +08:00
Sergei Kozelko
72c66e7e4e
Rename confidence sort to best (#1177)
* Rename CONFIDENCE comments sort type to BEST and remove old BEST type

The Reddit API supports only CONFIDENCE sort type for comments but displays it
as BEST.
I renamed CONFIDENCE name to Best and added a migration step for loading
correct sort type.

* Clean up sortType usages in ViewPostDetailFragment

Removed unnecessary null checks, object creations and most case conversions
2022-11-03 09:58:08 +08:00
Sergei Kozelko
78496e080f
Display comment avatar only if it is the right user (#1191)
Condition in callback for loading avatar url is almost always true[1]. So it would load avatar even if the viewholder got bound to another comment.

Ideally the solution would be to update the comment just like now, then find current position of the comment and call onItemChanged. However you cannot call onItemChanged from onBindViewHolder and that is a problem because callback can be executed synchronously.

So instead we just check that viewholder is bound to some comment and that bound comment's author matches initially requested author.

[1] The only case I know when it is false is when that comment got deleted and its author got replaced with "[deleted]" before the callback got executed
2022-11-03 09:47:10 +08:00
Patrick Demers
191df66a3b
add backup password below backup settings button (#1185) 2022-11-02 20:49:26 +08:00
scria1000
3815abec36
Don't pick up hyperlink text as a link (#1182) 2022-11-02 20:48:52 +08:00
Patrick Demers
4bec3e0922
always mux videos when downloading (#1152)
* mux videos with and without audio

* move variable to inner scope

* rename argument to catch block
2022-11-02 20:25:35 +08:00
Patrick Demers
28ca5e6bbe
Improve wiki link handling (#1184)
* handle wiki links with dashes and index wiki page

* properly handle w vs wiki and links with wiki in it twice

* remove beginning and end of line tokens from wiki regex

* optimize wiki regex
2022-11-02 20:24:38 +08:00
Abi0711
0cab9663d4
Rules can now show in private subreddits (#1181)
* Added oauth to fetching rules

* Added getRulesOauth for users that are logged in

Co-authored-by: Abi <u7290897@anu.edu.au>
2022-11-02 20:18:00 +08:00
Patrick Demers
2863fa90be
handle reddit.com/report as a url, not post link (#1179) 2022-11-02 20:17:21 +08:00
Patrick Demers
f85959cd89
add button to export logs to GitHub issue (#1180) 2022-11-02 20:16:23 +08:00
Patrick Demers
9703a46f5f
wait to load security settings until successful authentication (#1196) 2022-11-02 20:11:46 +08:00
Blahaj-Samoyed
9b4ee0018e
Fix see removed comment edit wrong comment (#1192)
* Fix removed comment shown in the wrong position.

* Handle index out of bounds.
2022-11-02 19:46:18 +08:00
HuilinChen943
fe9e0bd5d7
fix the bug: Scroll position is lost when changing screen orientation (#1173) 2022-10-24 10:40:07 +08:00