Commit Graph

2284 Commits

Author SHA1 Message Date
Wladimir Kirianov
8fb3d0e498 update issue template form 2023-02-01 20:38:21 +00:00
Docile-Alligator
da9cf78db1
Infinity for Reddit+ 2023-01-30 00:35:57 +08:00
Docile-Alligator
f05ba1c2e5 Version 5.4.0-beta4. Nothing new. 2023-01-29 00:08:54 -05:00
Docile-Alligator
5be035bc22 Version 5.4.0-beta3. Bring back blocking users. 2023-01-25 23:33:30 -05:00
Docile-Alligator
93a53e6ff2 Version 5.4.0-beta2. 2023-01-25 13:45:53 -05:00
scria1000
7839c1cef0
fix misdeletion (#1343) 2023-01-26 02:31:24 +08:00
scria1000
c382512292
Remember paused state for autoplay videos (#1331)
* Remember paused state for autoplay videos

* Update cached playback info

Update cached playback info instead of keeping track of it with a local variable

* Add missing null check

* Move logic into play()
2023-01-26 01:11:13 +08:00
scria1000
ed738437e6
Additional checks for null or potentially empty array (#1341) 2023-01-24 23:53:36 +08:00
Björn Tantau
8d0fd823a4
Only check for file extensions (#1299)
Links that end with jpeg without a dot before it are usually not images. Like here https://www.reddit.com/r/ProgrammerHumor/comments/zxro3m/weinersmith_has_escalated_the_gif_geif_vs_jiff/
2023-01-24 23:52:57 +08:00
cmp
ae1e59327f
In debug, fix crash that occurs when using the camera to post an image. (#1308) 2023-01-24 23:51:56 +08:00
cmp
a9fc1dacaa
Fix wikimode occasionally being null from the API (#1315) 2023-01-24 23:47:28 +08:00
cmp
b0f77528e1
Fix is_submitter property not being present on responses from the reveddit API. (#1335)
Try to fix pushshift API deleted comment searching.
2023-01-21 13:08:30 +08:00
Björn Tantau
116be7ecc2
Handle image posts if url contains query string (#1300)
* Handle image posts if url contains query string

Sometimes the URL to an image contains a query string, which results in Infinity showing a link instead of the image. Example: https://www.reddit.com/r/ProgrammerHumor/comments/zxsf93/like_why_the_hell_does_windows_news_leak/

* Check path for file ending instead of using regex
2023-01-21 13:03:50 +08:00
Sergei Kozelko
2ff6bcfcd7
Ignore NotifyDataSetChanged lint warnings for Markwon adapters (#1228)
There is no "more efficient" way to update it
2023-01-21 12:56:22 +08:00
Sergei Kozelko
c42f183696
Disable aspect ratio logic when it is negative (#1296)
Gallery can set aspect ratio to -1 which would result in negative measured height. It seem that Android treats dimensions as unsigned numbers, so negative numbers actually become huge positive numbers resulting in "infinite" height.

It should be noted that this change allows to disable aspect ratio logic even when some dimension is set to `wrap_content`.
2023-01-21 12:51:44 +08:00
Docile-Alligator
aaa55a6af9 Fix keyboard not showing on Android 13. 2023-01-20 23:43:49 -05:00
Docile-Alligator
12333fb453 Fix gallery image height in PostGalleryTypeImageRecyclerViewAdapter. 2022-12-28 18:13:53 -08:00
Docile-Alligator
8a6eb8e025 Change the style of the bottom app bar. 2022-12-28 17:25:48 -08:00
Docile-Alligator
b97721a1e7 Minor bugs fixed. 2022-12-27 09:41:40 -08:00
Docile-Alligator
b74fc9354c New option in fab: go to top. 2022-12-25 16:05:04 -08:00
Docile-Alligator
24b33bb05d Fix ItemTouchHelper issue? 2022-12-23 22:11:34 -08:00
Sergei Kozelko
a6a46bb29f
Delete unused mCommentIcon field (#1293) 2022-12-24 07:47:05 +08:00
Sergei Kozelko
befc6df1f0
Delete unused isSortingComments field (#1292)
Field value is always false
2022-12-24 07:45:10 +08:00
cmp
5786ac028d
Show moderator author/user colors in more places, such as post lists and history. Show moderator badging in post details as well as color. (#1288) 2022-12-24 06:25:14 +08:00
Sergei Kozelko
a21eccca0d
Inject Streamable api provider instead of Retrofit instance (#1217)
Low effort/high impact case. Simple change that removes Retrofit instance creation from startup path because it is used only after receiving response from Reddit. Eliminates Retrofit instance creation completely if it is not used. Also improves type safety by replacing common Retrofit type with specific api type.
2022-12-24 06:17:24 +08:00
Sergei Kozelko
483cb7023c
Allow importing theme as any text (#1275)
* Allow importing theme as any text

Browsers copy content as text/html and it caused theme import to fail

* Coerce clipboard data to text

Clipboard can have mime type of text even when it doesn't actually contain text. For example it can contain uri to text content provider. Using `coerceToText` automatically handles all cases and returns best text representation of content.
2022-12-24 05:47:41 +08:00
cmp
c0deb78734
If an author is deleted and is clicked, don't switch to view user (#1287)
* If an author is deleted and is clicked, don't switch to the view user detail activity, since it'll just error.

* Fix a canStartActivity check.
2022-12-24 05:38:00 +08:00
Docile-Alligator
206296db5e Material You tweaks. 2022-12-16 00:21:15 +11:00
Sergei Kozelko
20c729244e
Clean up NetworkModule (#1276)
Rename prefixes from `provides` to `provide`

Add Named annotations to all OkHttp and Retrofit providers

Remove RPAN OkHttp client
2022-12-15 20:23:41 +08:00
DeathPhantom77
99f10bddbc
Keep the capital letteing of your Multireddit when displayed on the home bar tab (#1279) 2022-12-15 20:10:37 +08:00
Docile-Alligator
0bcacafec3 Minor UI tweaks. 2022-12-10 19:51:43 +11:00
Sergei Kozelko
56ac5ad6d6
Refactor onFetchMoreCommentFailed callback (#1263)
Unified branches, extracted repeatedly used expressions.

Fortunately both branches had the same logic, except for placeholder position hint calculation.
2022-12-09 15:40:21 +08:00
Docile-Alligator
282817c192 Version v5.4.0-beta1. Minor bugs fixed. 2022-12-04 19:51:07 +11:00
Docile-Alligator
68ed718aa0 Version v5.4.0-beta1. Add authenticator to oauth retrofit. 2022-12-04 19:17:05 +11:00
Docile-Alligator
58881337c8 Version v5.4.0-beta1. 2022-12-04 11:37:46 +11:00
Docile-Alligator
cea5491ba7 Version v5.4.0-beta1. 2022-12-04 11:15:11 +11:00
Docile-Alligator
fbf4201418 Hide more options menu item in some activities. 2022-12-04 10:28:03 +11:00
Docile-Alligator
ecbddaafcb Merge remote-tracking branch 'origin/master' 2022-12-04 09:46:47 +11:00
Docile-Alligator
f173a5d576 Remove RPAN. 2022-12-04 09:44:37 +11:00
scria1000
c7c9727bac
Allow https redirection in ExoPlayer (#1261) 2022-12-04 06:28:13 +08:00
Docile-Alligator
bc03d20845 Fix score shown inside CommentFullyCollapsedViewHolder even the score is hidden. 2022-12-04 09:14:40 +11:00
Sergei Kozelko
1c81d3e0c9
Fix placeholder position check (#1216)
* Fix placeholder position check

Because of the missed negation `placeholderPosition` could actually point to a different comment. As a result loaded comments would be displayed at a wrong position which could result in duplicated comments.

* Extract placeholder search code

Simple refactoring. The only notable change is that now technically `placeholderPosition` can be -1. In practice that should never happen, but I added checks anyways
2022-12-04 05:05:28 +08:00
Docile-Alligator
bd5814fd4d Match parent for the bottom app bar in ViewRedditGalleryImageOrGifFragment. 2022-12-04 07:42:39 +11:00
Docile-Alligator
a3ddcb874d Fix bottom app bar not shown in ViewRedditGalleryImageOrGifFragment. 2022-12-04 07:41:25 +11:00
Docile-Alligator
57985ed95a Fix a stupid bug that prevents posts from loading. 2022-12-04 06:42:02 +11:00
Docile-Alligator
605129517e Notification permission. 2022-12-04 06:15:13 +11:00
Docile-Alligator
4af9e3d161 Minor bugs fixed. 2022-11-28 23:31:23 +11:00
Kurian Vithayathil
b1280bfb36
Dagger networking refactor (#1125)
* Separate network dependency injection module

- Moved network-related dependencies into a separate module
- Consolidated common dependencies to save resources constructing a http client/retrofit

* Separate construction of access token interceptor

* Create providers for Context and Application to be injectable

* Refactor AppModule and AppComponent

- Use component builder to store application context and provide to modules
- Optimise AppModule providers

* Use component factory to add component dependencies

* Updated network dependencies to singleton.

Add missing OAuth base url for oauth request

Co-authored-by: Kurian Vithayathil <no.reply@github.com>
Co-authored-by: Docile-Alligator <25734209+Docile-Alligator@users.noreply.github.com>
2022-11-28 17:08:32 +08:00
Docile-Alligator
234bd7a2dd Minor bugs fixed 2022-11-27 23:40:03 +11:00
Sergei Kozelko
b4c95fe4a5
Use more precise viewholder type in PostGalleryTypeImageRecyclerViewAdapter (#1229) 2022-11-27 20:25:20 +08:00