Commit Graph

2273 Commits

Author SHA1 Message Date
Michael Manganiello
935471d95c
Fix memory leak on BigImageViewer (#1067)
Leak found using LeakCanary. Steps:
1. Enable the LeakCanary dependency.
1. Open the app.
1. Open any post image, and go back.

According to `Piasy/BigImageViewer` documentation,
[Initialize section](9cc045e814/README.md (initialize)),
the app context must be used to avoid memory leaks.

Leak trace:

```
2022-09-04 19:51:38.154 13332-13332/ml.docilealligator.infinityforreddit.debug D/LeakCanary:
    ┬───
    │ GC Root: Thread object
    │
    ├─ android.os.HandlerThread instance
    │    Leaking: NO (PathClassLoader↓ is not leaking)
    │    Thread name: 'LeakCanary-Heap-Dump'
    │    ↓ Thread.contextClassLoader
    ├─ dalvik.system.PathClassLoader instance
    │    Leaking: NO (BigImageViewer↓ is not leaking and A ClassLoader is never leaking)
    │    ↓ ClassLoader.runtimeInternalObjects
    ├─ java.lang.Object[] array
    │    Leaking: NO (BigImageViewer↓ is not leaking)
    │    ↓ Object[257]
    ├─ com.github.piasy.biv.BigImageViewer class
    │    Leaking: NO (a class is never leaking)
    │    ↓ static BigImageViewer.sInstance
    │                            ~~~~~~~~~
    ├─ com.github.piasy.biv.BigImageViewer instance
    │    Leaking: UNKNOWN
    │    Retaining 969.9 kB in 14812 objects
    │    ↓ BigImageViewer.mImageLoader
    │                     ~~~~~~~~~~~~
    ├─ com.github.piasy.biv.loader.glide.GlideImageLoader instance
    │    Leaking: UNKNOWN
    │    Retaining 969.9 kB in 14811 objects
    │    ↓ GlideImageLoader.mRequestManager
    │                       ~~~~~~~~~~~~~~~
    ├─ com.bumptech.glide.RequestManager instance
    │    Leaking: UNKNOWN
    │    Retaining 969.9 kB in 14808 objects
    │    context instance of ml.docilealligator.infinityforreddit.activities.ViewPostDetailActivity with mDestroyed = true
    │    ↓ RequestManager.context
    │                     ~~~~~~~
    ╰→ ml.docilealligator.infinityforreddit.activities.ViewPostDetailActivity instance
         Leaking: YES (ObjectWatcher was watching this because ml.docilealligator.infinityforreddit.activities.
         ViewPostDetailActivity received Activity#onDestroy() callback and Activity#mDestroyed is true)
         Retaining 966.2 kB in 14703 objects
         key = f69c74cc-521e-4f6c-b5c8-8f787e27df75
         watchDurationMillis = 5547
         retainedDurationMillis = 541
         mApplication instance of ml.docilealligator.infinityforreddit.Infinity
         mBase instance of androidx.appcompat.view.ContextThemeWrapper
```
2022-09-09 10:03:07 +08:00
Docile-Alligator
7293b9e758 Update ExoPlayer. 2022-09-09 00:41:35 +10:00
Docile-Alligator
84b5b1d95d Version 5.3.1. 2022-09-07 01:01:45 +10:00
Docile-Alligator
6d224c307d Fix stupid Redgifs API issue. 2022-09-05 00:57:11 +10:00
Docile-Alligator
064b2ceedc Version 5.3.0. 2022-08-27 11:55:58 +10:00
Docile-Alligator
0dc759e9c6 Minor bugs fixed. 2022-08-26 18:08:16 +10:00
Docile-Alligator
965d8ab8ae Show an indicator for the current sort type. 2022-08-21 11:59:14 +10:00
Docile-Alligator
0c7e5bc16f Show an indicator for the current sort type in SortTypeBottomSheetFragment. 2022-08-21 10:58:18 +10:00
Docile-Alligator
6bb208aa61 Version 5.3.0-beta1. 2022-08-16 17:18:03 +10:00
Docile-Alligator
af49571a63 Receive events in HistoryPostFragment. 2022-08-16 17:07:30 +10:00
Docile-Alligator
69c4ab96b9 Update Redgifs API. 2022-08-15 21:58:39 +10:00
Docile-Alligator
8b8a9073dd Show urls in ShareLinkBottomSheetFragment. 2022-08-15 21:11:17 +10:00
Docile-Alligator
7d8e32320f Apply custom theme to settings page. 2022-08-15 21:10:42 +10:00
Docile-Alligator
2750636847 Apply custom theme to the header of the navigation drawer. 2022-08-14 17:47:57 +10:00
Sergei Kozelko
7a0a40f696
Heading markdown fix (#908)
* Copy heading parser and adjust it to match Reddit behavior

Unlike CommonMark, Reddit does not require space after #. This behavior is
coded in a private static function, so the only way to override it is to
copy everything and use the modified copy instead of the default parser.

* Use RedditHeadingPlugin instead of regexes

* Apply plugins to post body when writing a comment

This fixes display when writing comment to a post
that contains spoilers or headings without space

* Apply plugins to parent comment body when writing a comment

This fixes display when replying to a comment that contains strikethrough text
2022-08-14 15:33:07 +08:00
Docile-Alligator
633ccc7f7d Fix post content is not parsed in other types of posts. 2022-08-14 16:55:44 +10:00
Docile-Alligator
97dcc263e3 Fix saved comments not shown when clicking Saved option in the bottom navigation bar. 2022-08-13 13:35:30 +10:00
Docile-Alligator
da708748ba Merge branch 'master' of github.com:Docile-Alligator/Infinity-For-Reddit 2022-08-13 12:25:29 +10:00
Docile-Alligator
e3f9d31a34 Fix caption shown under the navbar in ViewRedditGalleryImageOrGifFragment. 2022-08-13 12:25:04 +10:00
Wladimir Kirianov
1366ff0147
Merge pull request #844 from SenseiSchizo/feature/stringTypoFix
Fixed typos in strings.xml
2022-08-12 13:58:10 +02:00
Andrei Shpakovskiy
a12e65aa0e
Manage theme insertion callbacks behaviour (#892) 2022-08-12 18:36:14 +08:00
Wladimir Kirianov
41504e779b
fixed renamed label 2022-08-12 12:17:50 +02:00
Wladimir Kirianov
6572803b56
fixed typos 2022-08-12 12:14:51 +02:00
Docile-Alligator
fc73816a40 Extra small font size 2022-08-05 12:28:49 +10:00
Andrei Shpakovskiy
a18ae7d62e
Set default position of cursor at the end of query (#842) 2022-08-05 08:55:22 +08:00
Anatolii Afanasev
926e50090e
Move mAccessToken and mAccountName initialization upper (#841) 2022-08-05 08:53:20 +08:00
Sergei Kozelko
2bc9034c89
Apply FAB theme in CustomThemeListingActivity (#857) 2022-08-05 08:52:19 +08:00
Sergei Kozelko
8db3736dd4
Fix loading previews after quick scroll (#861)
* Request layout on ratio change

* Change imageView visibility on bind/recycle to force layout change
2022-08-05 08:22:35 +08:00
Docile-Alligator
3c0e2ab2d6 Clear user flair. 2022-08-04 14:05:34 +10:00
Wladimir Kirianov
767bfb5af6
Fixed links 2022-07-29 17:08:22 +02:00
Docile-Alligator
9614f4a67a Minor UI tweaks in ViewSubredditDetailActivity, ViewUserDetailActivity and CustomThemePreviewActivity. 2022-07-28 23:42:46 +10:00
Docile-Alligator
318240e271 Merge branch 'master' of github.com:Docile-Alligator/Infinity-For-Reddit 2022-07-28 22:14:24 +10:00
Wladimir Kirianov
cdabfc8a6c
Update config.yml 2022-07-28 14:13:56 +02:00
Docile-Alligator
b4fb0fac13 Update translation contributors. 2022-07-28 22:13:38 +10:00
Wladimir Kirianov
9fe7d06ec0
Create config.yml 2022-07-28 13:51:06 +02:00
Wladimir Kirianov
cf36646b7d
Create Bug_Report Issues Template 2022-07-28 10:51:55 +02:00
Wladimir Kirianov
756f44a319
Add Bug Report Template 2022-07-28 10:17:53 +02:00
Wladimir Kirianov
a7e4b354a4
Create CONTRIBUTING.md 2022-07-28 10:13:48 +02:00
Wladimir Kirianov
621e67479d
Create CODE_OF_CONDUCT.md 2022-07-28 10:13:34 +02:00
Docile-Alligator
6f4e9233b8 Remove Block User menu option in ViewUserDetailActivity since Reddit does not allow 3rd-party apps access this API now. 2022-07-28 00:31:48 +10:00
Nan
176d6ce7ef
Fix misinterpretation of strings 2022-07-21 20:21:26 -07:00
Nan
e0339aa076
Fixed typos 2022-07-21 20:14:54 -07:00
Docile-Alligator
55af125dfe Fix changing post layout not working in HistoryActivity. 2022-07-19 10:30:59 +08:00
Docile-Alligator
a8d8e08323 Movable FAB in ViewPostDetailActivity. 2022-07-18 23:06:08 +08:00
Docile-Alligator
ce04d2bd77 Fix cannot go back from ViewMultiRedditDetailActivity. 2022-07-17 22:57:34 +08:00
Patrick Demers
5c0addbc91
Fix scroll using volume on multireddit (#834) 2022-07-17 22:48:42 +08:00
Docile-Alligator
12f404246b Show the number of subscribers in SubredditAutocompleteRecyclerViewAdapter. 2022-07-16 00:25:35 +08:00
Docile-Alligator
1cb79742c7 Show the number of subscribers in SubredditListingRecyclerViewAdapter. 2022-07-15 18:02:11 +08:00
Docile-Alligator
0265ac6227 Add an option for History in the navigation drawer. 2022-07-15 11:54:08 +08:00
Wladimir Kirianov
e6acd1bafc
Update README (#833)
Update Readme
2022-07-15 10:55:47 +08:00