From 9db117e47d94cd613e5cf29f2a9a0c29971162bd Mon Sep 17 00:00:00 2001 From: Julien Humbert Date: Wed, 23 Aug 2023 19:17:23 +0900 Subject: [PATCH] Add pluralized string (WIP 2) --- .../infinityforlemmy/PullNotificationWorker.java | 12 ++++++++++-- .../activities/PostPollActivity.java | 16 ++++++++++++++-- app/src/main/res/values/strings.xml | 16 ++++++++++++---- 3 files changed, 36 insertions(+), 8 deletions(-) diff --git a/app/src/main/java/eu/toldi/infinityforlemmy/PullNotificationWorker.java b/app/src/main/java/eu/toldi/infinityforlemmy/PullNotificationWorker.java index 31da6e5f..afc6fd51 100644 --- a/app/src/main/java/eu/toldi/infinityforlemmy/PullNotificationWorker.java +++ b/app/src/main/java/eu/toldi/infinityforlemmy/PullNotificationWorker.java @@ -102,7 +102,11 @@ public class PullNotificationWorker extends Worker { if (!messages.isEmpty()) { NotificationCompat.Builder summaryBuilder = NotificationUtils.buildSummaryNotification(context, notificationManager, accountName, - context.getString(R.string.notification_new_messages, messages.size()), + context.getResources().getQuantityString( + R.plurals.notification_new_messages, + messages.size(), + messages.size() + ), NotificationUtils.CHANNEL_ID_NEW_MESSAGES, NotificationUtils.CHANNEL_NEW_MESSAGES, NotificationUtils.getAccountGroupName(accountName), color); @@ -152,7 +156,11 @@ public class PullNotificationWorker extends Worker { } if (hasValidMessage) { - inboxStyle.setBigContentTitle(context.getString(R.string.notification_new_messages, messages.size())) + inboxStyle.setBigContentTitle(context.getResources().getQuantityString( + R.plurals.notification_new_messages, + messages.size(), + messages.size() + )) .setSummaryText(accountName); summaryBuilder.setStyle(inboxStyle); diff --git a/app/src/main/java/eu/toldi/infinityforlemmy/activities/PostPollActivity.java b/app/src/main/java/eu/toldi/infinityforlemmy/activities/PostPollActivity.java index cbf03903..ab190f9d 100644 --- a/app/src/main/java/eu/toldi/infinityforlemmy/activities/PostPollActivity.java +++ b/app/src/main/java/eu/toldi/infinityforlemmy/activities/PostPollActivity.java @@ -352,8 +352,20 @@ public class PostPollActivity extends BaseActivity implements FlairBottomSheetFr receivePostReplyNotificationsSwitchMaterial.performClick(); }); - votingLengthTextView.setText(getString(R.string.voting_length, (int) votingLengthSlider.getValue())); - votingLengthSlider.addOnChangeListener((slider, value, fromUser) -> votingLengthTextView.setText(getString(R.string.voting_length, (int) value))); + votingLengthTextView.setText( + getResources().getQuantityString( + R.plurals.voting_length, + (int) votingLengthSlider.getValue(), + (int) votingLengthSlider.getValue() + ) + ); + votingLengthSlider.addOnChangeListener((slider, value, fromUser) -> votingLengthTextView.setText( + getResources().getQuantityString( + R.plurals.voting_length, + (int) value, + (int) value + ) + )); } private void loadCurrentAccount() { diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 4552561d..5f61bcae 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -225,7 +225,10 @@ The post needs a good title Hey where is the link? Please select an image first - Voting length: %1$d days + + Voting length: %1$d day + Voting length: %1$d days + Posting Could not post it Error processing image @@ -382,7 +385,10 @@ New Message Community Award - %1$d New Messages + + %1$d New Message + %1$d New Messages + Account Lemmy @@ -1023,8 +1029,10 @@ Edit Multicommunity Delete Multicommunity - %1$,d Awards - 1 Award + + %1$,d Award + %1$,d Awards + Report Reporting