From 4947bc1be5ae386f62e9d5018c54fd763c9805c5 Mon Sep 17 00:00:00 2001 From: Sergei Kozelko Date: Sun, 25 Sep 2022 15:15:38 +0700 Subject: [PATCH] Fix crash in debug build by using fully qualified class name for layoutmanager (#1130) When the class name is relative, Android tries to resolve it against applicationId. However it does not match the package because of `.debug` suffix so it tries to load the wrong class. This results in ClassNotFoundException and a crash. Using fully qualified class name fixes it as the system can use the class name as is. --- app/src/main/res/layout-land/fragment_view_post_detail.xml | 4 ++-- app/src/main/res/layout-sw600dp/fragment_view_post_detail.xml | 4 ++-- app/src/main/res/layout/activity_custom_theme_listing.xml | 2 +- app/src/main/res/layout/activity_customize_theme.xml | 2 +- app/src/main/res/layout/activity_report.xml | 2 +- app/src/main/res/layout/activity_rules.xml | 2 +- app/src/main/res/layout/activity_trending.xml | 2 +- .../res/layout/exo_rpan_broadcast_playback_control_view.xml | 2 +- app/src/main/res/layout/fragment_crash_reports.xml | 2 +- app/src/main/res/layout/fragment_flair_bottom_sheet.xml | 2 +- app/src/main/res/layout/fragment_translation.xml | 2 +- app/src/main/res/layout/fragment_view_post_detail.xml | 2 +- 12 files changed, 14 insertions(+), 14 deletions(-) diff --git a/app/src/main/res/layout-land/fragment_view_post_detail.xml b/app/src/main/res/layout-land/fragment_view_post_detail.xml index 02bba243..ad693051 100644 --- a/app/src/main/res/layout-land/fragment_view_post_detail.xml +++ b/app/src/main/res/layout-land/fragment_view_post_detail.xml @@ -25,7 +25,7 @@ android:layout_weight="1" android:paddingBottom="144dp" android:clipToPadding="false" - app:layoutManager=".customviews.LinearLayoutManagerBugFixed" /> + app:layoutManager="ml.docilealligator.infinityforreddit.customviews.LinearLayoutManagerBugFixed" /> + app:layoutManager="ml.docilealligator.infinityforreddit.customviews.LinearLayoutManagerBugFixed" /> diff --git a/app/src/main/res/layout-sw600dp/fragment_view_post_detail.xml b/app/src/main/res/layout-sw600dp/fragment_view_post_detail.xml index dd688bfc..61f27727 100644 --- a/app/src/main/res/layout-sw600dp/fragment_view_post_detail.xml +++ b/app/src/main/res/layout-sw600dp/fragment_view_post_detail.xml @@ -25,7 +25,7 @@ android:layout_weight="1" android:paddingBottom="144dp" android:clipToPadding="false" - app:layoutManager=".customviews.LinearLayoutManagerBugFixed" /> + app:layoutManager="ml.docilealligator.infinityforreddit.customviews.LinearLayoutManagerBugFixed" /> + app:layoutManager="ml.docilealligator.infinityforreddit.customviews.LinearLayoutManagerBugFixed" /> diff --git a/app/src/main/res/layout/activity_custom_theme_listing.xml b/app/src/main/res/layout/activity_custom_theme_listing.xml index e0d88d70..57168d04 100644 --- a/app/src/main/res/layout/activity_custom_theme_listing.xml +++ b/app/src/main/res/layout/activity_custom_theme_listing.xml @@ -37,7 +37,7 @@ android:id="@+id/recycler_view_customize_theme_listing_activity" android:layout_width="match_parent" android:layout_height="match_parent" - app:layoutManager=".customviews.LinearLayoutManagerBugFixed" + app:layoutManager="ml.docilealligator.infinityforreddit.customviews.LinearLayoutManagerBugFixed" app:layout_behavior="@string/appbar_scrolling_view_behavior" /> \ No newline at end of file diff --git a/app/src/main/res/layout/activity_report.xml b/app/src/main/res/layout/activity_report.xml index a0d114b6..fc0b504d 100644 --- a/app/src/main/res/layout/activity_report.xml +++ b/app/src/main/res/layout/activity_report.xml @@ -27,7 +27,7 @@ android:id="@+id/recycler_view_report_activity" android:layout_width="match_parent" android:layout_height="match_parent" - app:layoutManager=".customviews.LinearLayoutManagerBugFixed" + app:layoutManager="ml.docilealligator.infinityforreddit.customviews.LinearLayoutManagerBugFixed" app:layout_behavior="@string/appbar_scrolling_view_behavior" /> \ No newline at end of file diff --git a/app/src/main/res/layout/activity_rules.xml b/app/src/main/res/layout/activity_rules.xml index 38256a63..606546a3 100644 --- a/app/src/main/res/layout/activity_rules.xml +++ b/app/src/main/res/layout/activity_rules.xml @@ -45,7 +45,7 @@ android:layout_width="match_parent" android:layout_height="match_parent" android:clipToPadding="false" - app:layoutManager=".customviews.LinearLayoutManagerBugFixed" + app:layoutManager="ml.docilealligator.infinityforreddit.customviews.LinearLayoutManagerBugFixed" app:layout_behavior="@string/appbar_scrolling_view_behavior" /> + app:layoutManager="ml.docilealligator.infinityforreddit.customviews.LinearLayoutManagerBugFixed" /> diff --git a/app/src/main/res/layout/exo_rpan_broadcast_playback_control_view.xml b/app/src/main/res/layout/exo_rpan_broadcast_playback_control_view.xml index 7922dc7a..4e224e24 100644 --- a/app/src/main/res/layout/exo_rpan_broadcast_playback_control_view.xml +++ b/app/src/main/res/layout/exo_rpan_broadcast_playback_control_view.xml @@ -142,7 +142,7 @@ android:paddingEnd="16dp" app:layout_constraintTop_toBottomOf="@id/control_linear_layout" app:layout_constraintBottom_toTopOf="@id/time_bar_linear_layout" - app:layoutManager=".customviews.LinearLayoutManagerBugFixed" /> + app:layoutManager="ml.docilealligator.infinityforreddit.customviews.LinearLayoutManagerBugFixed" /> \ No newline at end of file diff --git a/app/src/main/res/layout/fragment_flair_bottom_sheet.xml b/app/src/main/res/layout/fragment_flair_bottom_sheet.xml index 5649a70c..159e2b72 100644 --- a/app/src/main/res/layout/fragment_flair_bottom_sheet.xml +++ b/app/src/main/res/layout/fragment_flair_bottom_sheet.xml @@ -29,6 +29,6 @@ android:id="@+id/recycler_view_bottom_sheet_fragment" android:layout_width="match_parent" android:layout_height="match_parent" - app:layoutManager=".customviews.LinearLayoutManagerBugFixed" /> + app:layoutManager="ml.docilealligator.infinityforreddit.customviews.LinearLayoutManagerBugFixed" /> \ No newline at end of file diff --git a/app/src/main/res/layout/fragment_translation.xml b/app/src/main/res/layout/fragment_translation.xml index a0cb2ea7..99e3580a 100644 --- a/app/src/main/res/layout/fragment_translation.xml +++ b/app/src/main/res/layout/fragment_translation.xml @@ -5,5 +5,5 @@ android:layout_height="match_parent" xmlns:app="http://schemas.android.com/apk/res-auto" android:id="@+id/recycler_view_translation_fragment" - app:layoutManager=".customviews.LinearLayoutManagerBugFixed" + app:layoutManager="ml.docilealligator.infinityforreddit.customviews.LinearLayoutManagerBugFixed" tools:context=".settings.TranslationFragment" /> \ No newline at end of file diff --git a/app/src/main/res/layout/fragment_view_post_detail.xml b/app/src/main/res/layout/fragment_view_post_detail.xml index 72b9e3d0..8bcb680e 100644 --- a/app/src/main/res/layout/fragment_view_post_detail.xml +++ b/app/src/main/res/layout/fragment_view_post_detail.xml @@ -18,7 +18,7 @@ android:layout_height="match_parent" android:paddingBottom="144dp" android:clipToPadding="false" - app:layoutManager=".customviews.LinearLayoutManagerBugFixed" /> + app:layoutManager="ml.docilealligator.infinityforreddit.customviews.LinearLayoutManagerBugFixed" />