From bb31a16190c9540fedb3ff53224618afac1f10b9 Mon Sep 17 00:00:00 2001 From: Jays2Kings Date: Tue, 6 Apr 2021 18:14:34 -0400 Subject: [PATCH] Add button to remove reading history in recents As an alternative to long press (which in another commit can be removed) --- .../ui/recents/RecentMangaAdapter.kt | 1 + .../tachiyomi/ui/recents/RecentMangaHolder.kt | 3 ++ .../tachiyomi/ui/recents/RecentsController.kt | 4 +++ .../drawable/ic_eye_remove_outline_24dp.xml | 8 +++++ app/src/main/res/layout/recent_manga_item.xml | 34 ++++++++++++++----- app/src/main/res/values-night/colors.xml | 2 ++ app/src/main/res/values/colors.xml | 1 + app/src/main/res/values/strings.xml | 1 + 8 files changed, 46 insertions(+), 8 deletions(-) create mode 100644 app/src/main/res/drawable/ic_eye_remove_outline_24dp.xml diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/recents/RecentMangaAdapter.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/recents/RecentMangaAdapter.kt index ded71cd62f..5c049546a7 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/recents/RecentMangaAdapter.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/recents/RecentMangaAdapter.kt @@ -27,6 +27,7 @@ class RecentMangaAdapter(val delegate: RecentsInterface) : interface RecentMangaInterface { fun onCoverClick(position: Int) + fun onRemoveHistoryClicked(position: Int) fun markAsRead(position: Int) fun isSearching(): Boolean fun setViewType(viewType: Int) diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/recents/RecentMangaHolder.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/recents/RecentMangaHolder.kt index 0edc08c457..a212676d7d 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/recents/RecentMangaHolder.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/recents/RecentMangaHolder.kt @@ -2,6 +2,7 @@ package eu.kanade.tachiyomi.ui.recents import android.app.Activity import android.view.View +import androidx.core.view.isVisible import eu.kanade.tachiyomi.R import eu.kanade.tachiyomi.data.image.coil.loadLibraryManga import eu.kanade.tachiyomi.data.download.model.Download @@ -21,11 +22,13 @@ class RecentMangaHolder( init { binding.cardLayout.setOnClickListener { adapter.delegate.onCoverClick(flexibleAdapterPosition) } + binding.removeHistory.setOnClickListener { adapter.delegate.onRemoveHistoryClicked(flexibleAdapterPosition) } } fun bind(item: RecentMangaItem) { binding.downloadButton.downloadButton.visibleIf(item.mch.manga.source != LocalSource.ID) + binding.removeHistory.isVisible = item.mch.history.id != null binding.title.apply { text = item.chapter.name ChapterUtil.setTextViewForChapter(this, item) diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/recents/RecentsController.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/recents/RecentsController.kt index f1bf27b60f..648dd451aa 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/recents/RecentsController.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/recents/RecentsController.kt @@ -364,6 +364,10 @@ class RecentsController(bundle: Bundle? = null) : router.pushController(MangaDetailsController(manga).withFadeTransaction()) } + override fun onRemoveHistoryClicked(position: Int) { + onItemLongClick(position) + } + fun showHistory() { presenter.toggleGroupRecents(RecentsPresenter.VIEW_TYPE_ONLY_HISTORY, false) } diff --git a/app/src/main/res/drawable/ic_eye_remove_outline_24dp.xml b/app/src/main/res/drawable/ic_eye_remove_outline_24dp.xml new file mode 100644 index 0000000000..4c8f7946e4 --- /dev/null +++ b/app/src/main/res/drawable/ic_eye_remove_outline_24dp.xml @@ -0,0 +1,8 @@ + + + + \ No newline at end of file diff --git a/app/src/main/res/layout/recent_manga_item.xml b/app/src/main/res/layout/recent_manga_item.xml index 8a4d5bd022..42a8e814b4 100644 --- a/app/src/main/res/layout/recent_manga_item.xml +++ b/app/src/main/res/layout/recent_manga_item.xml @@ -125,7 +125,7 @@ android:textColor="?android:attr/textColorSecondary" android:textSize="14sp" app:layout_constrainedWidth="true" - app:layout_constraintEnd_toStartOf="@+id/download_button" + app:layout_constraintEnd_toStartOf="@id/button_layout" app:layout_constraintHorizontal_bias="0.0" app:layout_constraintStart_toStartOf="@+id/title" app:layout_constraintTop_toBottomOf="@+id/subtitle" @@ -145,19 +145,37 @@ android:progress="10" android:progressTint="?colorAccent" android:visibility="gone" - app:layout_constraintEnd_toStartOf="@id/download_button" + app:layout_constraintEnd_toStartOf="@id/button_layout" app:layout_constraintStart_toStartOf="@id/title" app:layout_constraintTop_toBottomOf="@id/subtitle" /> + + + + + android:layout_width="45dp" + android:layout_height="match_parent" + android:layout_marginEnd="8dp" /> + @color/md_white_1000_38 @color/md_white_1000_12 @color/material_green_700 + #cc4444 + #1C1C1D #212121 diff --git a/app/src/main/res/values/colors.xml b/app/src/main/res/values/colors.xml index 2008a50175..c15d3289de 100644 --- a/app/src/main/res/values/colors.xml +++ b/app/src/main/res/values/colors.xml @@ -60,6 +60,7 @@ #2979FF #F44336 + #AA2200 #99CC99 diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 9d7b2fe284..cd3bd6f3cc 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -207,6 +207,7 @@ Updates Newly added History + Reset chapter history Recent updates This will remove the read date of \"%1$s\". Are you sure?