rtl_tcp: Extracted some constants out of printf strings

The help output contained constants that should print values
based on code constants and not be hardcoded into the print strings.
This commit is contained in:
David Neiss 2021-08-17 15:43:44 -04:00 committed by Steve Markgraf
parent 0847e93e08
commit 641c221fab

View File

@ -56,6 +56,10 @@ typedef int socklen_t;
#define SOCKET_ERROR -1 #define SOCKET_ERROR -1
#endif #endif
static const char* DEFAULT_PORT_STR = "1234";
static const uint32_t DEFAULT_SAMPLE_RATE_HZ = 2048000;
static const int DEFAULT_MAX_NUM_BUFFERS = 500;
static SOCKET s; static SOCKET s;
static pthread_t tcp_worker_thread; static pthread_t tcp_worker_thread;
@ -83,23 +87,24 @@ static rtlsdr_dev_t *dev = NULL;
static int enable_biastee = 0; static int enable_biastee = 0;
static int global_numq = 0; static int global_numq = 0;
static struct llist *ll_buffers = 0; static struct llist *ll_buffers = 0;
static int llbuf_num = 500; static int llbuf_num = DEFAULT_MAX_NUM_BUFFERS;
static volatile int do_exit = 0; static volatile int do_exit = 0;
void usage(void) void usage(void)
{ {
printf("rtl_tcp, an I/Q spectrum server for RTL2832 based DVB-T receivers\n\n" printf("rtl_tcp, an I/Q spectrum server for RTL2832 based DVB-T receivers\n\n");
"Usage:\t[-a listen address]\n" printf("Usage:\t[-a listen address]\n");
"\t[-p listen port (default: 1234)]\n" printf("\t[-p listen port (default: %s)]\n", DEFAULT_PORT_STR);
"\t[-f frequency to tune to [Hz]]\n" printf("\t[-f frequency to tune to [Hz]]\n");
"\t[-g gain (default: 0 for auto)]\n" printf("\t[-g gain (default: 0 for auto)]\n");
"\t[-s samplerate in Hz (default: 2048000 Hz)]\n" printf("\t[-s samplerate in Hz (default: %d Hz)]\n", DEFAULT_SAMPLE_RATE_HZ);
"\t[-b number of buffers (default: 15, set by library)]\n" printf("\t[-b number of buffers (default: 15, set by library)]\n");
"\t[-n max number of linked list buffers to keep (default: 500)]\n" printf("\t[-n max number of linked list buffers to keep (default: %d)]\n", DEFAULT_MAX_NUM_BUFFERS);
"\t[-d device index (default: 0)]\n" printf("\t[-d device index (default: 0)]\n");
"\t[-P ppm_error (default: 0)]\n" printf("\t[-P ppm_error (default: 0)]\n");
"\t[-T enable bias-T on GPIO PIN 0 (works for rtl-sdr.com v3 dongles)]\n"); printf("\t[-T enable bias-T on GPIO PIN 0 (works for rtl-sdr.com v3 dongles)]\n");
exit(1); exit(1);
} }
@ -374,8 +379,8 @@ int main(int argc, char **argv)
{ {
int r, opt, i; int r, opt, i;
char *addr = "127.0.0.1"; char *addr = "127.0.0.1";
char *port = "1234"; const char *port = DEFAULT_PORT_STR;
uint32_t frequency = 100000000, samp_rate = 2048000; uint32_t frequency = 100000000, samp_rate = DEFAULT_SAMPLE_RATE_HZ;
struct sockaddr_storage local, remote; struct sockaddr_storage local, remote;
struct addrinfo *ai; struct addrinfo *ai;
struct addrinfo *aiHead; struct addrinfo *aiHead;