Frédéric Mangano-Tarumi
6f7ac1f13b
review the code comments
...
In particular, delete the obsolete TODOs.
2020-08-24 21:51:23 +02:00
Frédéric Mangano-Tarumi
ea4d74d844
proper permissions setting on output files
2020-08-23 17:51:45 +02:00
Aarni Koskela
40defdf2e1
Add headers required on macOS
2019-01-09 14:19:41 +02:00
Frédéric Mangano-Tarumi
8d287a8070
fix a memory leak in ot::read_comments
2019-01-08 20:57:55 -05:00
Frédéric Mangano-Tarumi
06fff8cbeb
support --delete NAME=VALUE
2018-12-17 20:00:27 -05:00
Frédéric Mangano-Tarumi
e2a1c06005
case-insensitive field name for comment deletion
2018-12-16 18:56:18 -05:00
Frédéric Mangano-Tarumi
f872f71411
move delete_comments into cli
2018-12-16 18:44:08 -05:00
Frédéric Mangano-Tarumi
6797e59417
reduce match_field into delete_comments
2018-12-16 18:41:20 -05:00
Frédéric Mangano-Tarumi
7df8c5c426
--set: add only the field name to to_delete
2018-12-16 18:33:08 -05:00
Frédéric Mangano-Tarumi
e26f3f268c
error when --set-all's parsing fails
2018-12-16 12:50:18 -05:00
Frédéric Mangano-Tarumi
46cd25f744
warn about newlines and control characters
2018-12-16 12:36:37 -05:00
Frédéric Mangano-Tarumi
70e9b576cf
review the doc, for utf-8 in particular
2018-12-09 14:05:50 -05:00
Frédéric Mangano-Tarumi
e471c82605
convert command-line arguments to UTF-8 too
2018-12-09 12:33:48 -05:00
Frédéric Mangano-Tarumi
cc3bb6397d
convert tags to and from the user locale
2018-12-09 12:18:17 -05:00
Frédéric Mangano-Tarumi
bb548f51d3
encoding_converter: overload for C strings
2018-12-09 12:17:10 -05:00
Frédéric Mangano-Tarumi
ebc8347c9e
character encoding converter
2018-12-09 11:45:00 -05:00
Frédéric Mangano-Tarumi
ca06c6fb9d
detect muxed streams
2018-12-08 12:55:58 -05:00
Frédéric Mangano-Tarumi
42845e4867
cli: don't increment the absolute page number on error
2018-12-08 12:27:40 -05:00
Frédéric Mangano-Tarumi
b2826bf0cc
raise error on unsynced data
2018-12-08 12:20:00 -05:00
Frédéric Mangano-Tarumi
33ef7ee153
better error messages for multi-page headers
2018-12-08 11:42:10 -05:00
Frédéric Mangano-Tarumi
ccc8417413
rename the methods of ogg_reader
...
read_page → next_page, because it's more consistent with iterators.
read_header_packet → process_header_packet, because it doesn't actually
*read* anything.
2018-12-08 11:36:10 -05:00
Frédéric Mangano-Tarumi
d9dfc29b7d
drop ot::validate_identification_header
...
No more need to extract the header packet.
2018-12-08 11:28:16 -05:00
Frédéric Mangano-Tarumi
23049a7ff6
introduce ot::is_opus_stream
2018-12-08 11:24:17 -05:00
Frédéric Mangano-Tarumi
f080f9da70
ogg_stream → ogg_logical_stream
2018-12-08 10:59:07 -05:00
Frédéric Mangano-Tarumi
4e3ee61ca3
reject continued header pages
2018-12-05 20:11:03 -05:00
Frédéric Mangano-Tarumi
c01045172c
check for partial packets in header page
2018-12-05 19:21:48 -05:00
Frédéric Mangano-Tarumi
7e6d9eae39
reduce read_packet into read_header_packet
2018-12-05 18:42:58 -05:00
Frédéric Mangano-Tarumi
14ae681e61
get rid of ogg_writer::prepare_stream
2018-12-05 18:03:53 -05:00
Frédéric Mangano-Tarumi
7e575ffbc3
reduce write_packet and flush_page into write_header_packet
2018-12-05 17:37:59 -05:00
Frédéric Mangano-Tarumi
1ff5284b60
process the streams by page instead of packets
2018-12-03 20:07:00 -05:00
Frédéric Mangano-Tarumi
71c9dd7209
reduce process_tags into a simpler function
...
It had too many responsibilities.
2018-12-03 18:22:33 -05:00
Frédéric Mangano-Tarumi
fcfb4a2a1d
fatal errors are not special
2018-12-03 18:13:51 -05:00
Frédéric Mangano-Tarumi
1d6ca8fc59
write the output to a temporary file
2018-12-02 16:20:40 -05:00
Frédéric Mangano-Tarumi
a74ea34352
introduce partial files
2018-12-02 12:12:58 -05:00
Frédéric Mangano-Tarumi
289391a9df
more robust tests for input/output equality
2018-12-02 10:45:36 -05:00
Frédéric Mangano-Tarumi
5860902084
isolate the process function to the cli module
...
Its interface is not good enough to be exposed.
2018-12-02 10:10:40 -05:00
Frédéric Mangano-Tarumi
614bd6379b
inplace -> in_place
2018-12-01 17:39:27 -05:00
Frédéric Mangano-Tarumi
7189d63c20
check for duplicate options
2018-12-01 17:23:38 -05:00
Frédéric Mangano-Tarumi
d67ce423d1
parse_options: return the error message in the status
2018-12-01 13:26:22 -05:00
Frédéric Mangano-Tarumi
6f290702a8
catch getopt's errors
2018-12-01 13:03:44 -05:00
Frédéric Mangano-Tarumi
067c9240c3
proces_options -> parse_options
...
The function is not supposed to have side effects anymore.
2018-12-01 12:02:19 -05:00
Frédéric Mangano-Tarumi
90bcf0bd71
process_options: don't deduce path_out from inplace
2018-12-01 11:51:00 -05:00
Frédéric Mangano-Tarumi
b60183c0ca
calling opustags without arguments is now an error
...
Get rid of the exit_now status and simplify the help display code.
2018-12-01 11:36:03 -05:00
Frédéric Mangano-Tarumi
2b92ee0ce1
finalize 1.2.0
2018-11-25 12:13:30 -05:00
Frédéric Mangano-Tarumi
c4acca18d8
review the --help message
2018-11-24 20:02:24 -05:00
Frédéric Mangano-Tarumi
5b5b67a0df
clean-up the includes
2018-11-24 11:56:43 -05:00
Frédéric Mangano-Tarumi
80a4b2ccf6
rewrite ot::read_comments with getline
2018-11-24 11:44:15 -05:00
Frédéric Mangano-Tarumi
d1299360de
smart ot::file handle
2018-11-24 11:33:04 -05:00
Frédéric Mangano-Tarumi
bfa46273b9
fix ot::read_comments when handling empty lines
2018-11-24 11:33:04 -05:00
Frédéric Mangano-Tarumi
26411d3843
t: test ot::read_comments
2018-11-24 11:33:04 -05:00
