MangaChapterListItem: Don't use alpha modifier

Possibly fixes #822

Co-authored-by: Ivan Iskandar <12537387+ivaniskandar@users.noreply.github.com>

.github/renovate.json5

@@ -9,14 +9,6 @@
         "dev.chrisbanes.compose:compose-bom"
       ],
       "ignoreUnstable": false
-    },
-    {
-      "groupName": "Kotlin and Compose Compiler",
-      "matchPackagePrefixes": [
-        "androidx.compose.compiler",
-        "org.jetbrains.kotlin.",
-        "org.jetbrains.kotlin:",
-      ],
     }
   ]
 }

.github/workflows/build_pull_request.yml

@@ -26,7 +26,7 @@ jobs:
         uses: gradle/wrapper-validation-action@216d1ad2b3710bf005dc39237337b9673fd8fcd5 # v3.3.2
 
       - name: Dependency Review
-        uses: actions/dependency-review-action@0c155c5e8556a497adf53f2c18edabf945ed8e70 # v4.3.2
+        uses: actions/dependency-review-action@72eb03d02c7872a771aacd928f3123ac62ad6d3a # v4.3.3
 
       - name: Set up JDK
         uses: actions/setup-java@99b8673ff64fbf99d8d325f52d9a5bdedb8483e9 # v4.2.1

.gitignore

@@ -1,4 +1,5 @@
 .gradle
+.kotlin
 /local.properties
 /.idea/workspace.xml
 .DS_Store

app/build.gradle.kts

@@ -274,7 +274,7 @@ androidComponents {
 tasks {
     // See https://kotlinlang.org/docs/reference/experimental.html#experimental-status-of-experimental-api(-markers)
     withType<KotlinCompile> {
-        kotlinOptions.freeCompilerArgs += listOf(
+        compilerOptions.freeCompilerArgs.addAll(
             "-Xcontext-receivers",
             "-opt-in=androidx.compose.foundation.layout.ExperimentalLayoutApi",
             "-opt-in=androidx.compose.material.ExperimentalMaterialApi",

app/src/main/java/eu/kanade/presentation/browse/ExtensionsScreen.kt

@@ -90,7 +90,7 @@ fun ExtensionScreen(
     PullRefresh(
         refreshing = state.isRefreshing,
         onRefresh = onRefresh,
-        enabled = { !state.isLoading },
+        enabled = !state.isLoading,
     ) {
         when {
             state.isLoading -> LoadingScreen(Modifier.padding(contentPadding))

app/src/main/java/eu/kanade/presentation/components/AppBar.kt

@@ -179,7 +179,7 @@ fun AppBarTitle(
                 maxLines = 1,
                 overflow = TextOverflow.Ellipsis,
                 modifier = Modifier.basicMarquee(
-                    delayMillis = 2_000,
+                    repeatDelayMillis = 2_000,
                 ),
             )
         }

app/src/main/java/eu/kanade/presentation/library/components/LibraryContent.kt

@@ -93,7 +93,7 @@ fun LibraryContent(
                     isRefreshing = false
                 }
             },
-            enabled = { notSelectionMode },
+            enabled = notSelectionMode,
         ) {
             LibraryPager(
                 state = pagerState,

app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt

@@ -355,7 +355,7 @@ private fun MangaScreenSmallImpl(
         PullRefresh(
             refreshing = state.isRefreshingData,
             onRefresh = onRefresh,
-            enabled = { !isAnySelected },
+            enabled = !isAnySelected,
             indicatorPadding = PaddingValues(top = topPadding),
         ) {
             val layoutDirection = LocalLayoutDirection.current
@@ -601,7 +601,7 @@ fun MangaScreenLargeImpl(
         PullRefresh(
             refreshing = state.isRefreshingData,
             onRefresh = onRefresh,
-            enabled = { !isAnySelected },
+            enabled = !isAnySelected,
             indicatorPadding = PaddingValues(
                 start = insetPadding.calculateStartPadding(layoutDirection),
                 top = with(density) { topBarHeight.toDp() },

app/src/main/java/eu/kanade/presentation/manga/components/MangaChapterListItem.kt

@@ -30,7 +30,6 @@ import androidx.compose.runtime.remember
 import androidx.compose.runtime.setValue
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
-import androidx.compose.ui.draw.alpha
 import androidx.compose.ui.draw.clipToBounds
 import androidx.compose.ui.graphics.Color
 import androidx.compose.ui.graphics.vector.ImageVector
@@ -66,9 +65,6 @@ fun MangaChapterListItem(
     onChapterSwipe: (LibraryPreferences.ChapterSwipeAction) -> Unit,
     modifier: Modifier = Modifier,
 ) {
-    val textAlpha = if (read) ReadItemAlpha else 1f
-    val textSubtitleAlpha = if (read) ReadItemAlpha else SecondaryItemAlpha
-
     val start = getSwipeAction(
         action = chapterSwipeStartAction,
         read = read,
@@ -133,15 +129,20 @@ fun MangaChapterListItem(
                     Text(
                         text = title,
                         style = MaterialTheme.typography.bodyMedium,
-                        color = LocalContentColor.current.copy(alpha = textAlpha),
                         maxLines = 1,
                         overflow = TextOverflow.Ellipsis,
                         onTextLayout = { textHeight = it.size.height },
+                        color = LocalContentColor.current.copy(alpha = if (read) ReadItemAlpha else 1f),
                     )
                 }
 
-                Row(modifier = Modifier.alpha(textSubtitleAlpha)) {
-                    ProvideTextStyle(value = MaterialTheme.typography.bodySmall) {
+                Row {
+                    val subtitleStyle = MaterialTheme.typography.bodySmall
+                        .merge(
+                            color = LocalContentColor.current
+                                .copy(alpha = if (read) ReadItemAlpha else SecondaryItemAlpha)
+                        )
+                    ProvideTextStyle(value = subtitleStyle) {
                         if (date != null) {
                             Text(
                                 text = date,

app/src/main/java/eu/kanade/presentation/updates/UpdatesScreen.kt

@@ -104,7 +104,7 @@ fun UpdateScreen(
                             isRefreshing = false
                         }
                     },
-                    enabled = { !state.selectionMode },
+                    enabled = !state.selectionMode,
                     indicatorPadding = contentPadding,
                 ) {
                     FastScrollLazyColumn(

app/src/main/java/eu/kanade/tachiyomi/data/coil/MangaCoverFetcher.kt

@@ -21,7 +21,6 @@ import okhttp3.CacheControl
 import okhttp3.Call
 import okhttp3.Request
 import okhttp3.Response
-import okhttp3.internal.http.HTTP_NOT_MODIFIED
 import okio.FileSystem
 import okio.Path.Companion.toOkioPath
 import okio.Source
@@ -348,5 +347,7 @@ class MangaCoverFetcher(
 
         private val CACHE_CONTROL_NO_STORE = CacheControl.Builder().noStore().build()
         private val CACHE_CONTROL_NO_NETWORK_NO_CACHE = CacheControl.Builder().noCache().onlyIfCached().build()
+
+        private const val HTTP_NOT_MODIFIED = 304
     }
 }

app/src/test/java/mihon/core/migration/MigratorTest.kt

@@ -1,6 +1,5 @@
 package mihon.core.migration
 
-import io.mockk.Called
 import io.mockk.slot
 import io.mockk.spyk
 import io.mockk.verify
@@ -59,7 +58,7 @@ class MigratorTest {
         val result = execute.await()
         assertFalse(result)
 
-        verify { migrationJobFactory.create(any()) wasNot Called }
+        verify(exactly = 0) { migrationJobFactory.create(any()) }
     }
 
     @Test
@@ -72,7 +71,7 @@ class MigratorTest {
         val result = execute.await()
         assertFalse(result)
 
-        verify { migrationJobFactory.create(any()) wasNot Called }
+        verify(exactly = 0) { migrationJobFactory.create(any()) }
     }
 
     @Test

buildSrc/build.gradle.kts

@@ -3,14 +3,16 @@ plugins {
 }
 
 dependencies {
+    implementation(androidx.gradle)
+    implementation(kotlinx.gradle)
+    implementation(kotlinx.compose.compiler.gradle)
+    implementation(libs.detekt.gradlePlugin)
+    implementation(gradleApi())
+
     implementation(files(libs.javaClass.superclass.protectionDomain.codeSource.location))
     implementation(files(androidx.javaClass.superclass.protectionDomain.codeSource.location))
     implementation(files(compose.javaClass.superclass.protectionDomain.codeSource.location))
     implementation(files(kotlinx.javaClass.superclass.protectionDomain.codeSource.location))
-    implementation(androidx.gradle)
-    implementation(kotlinx.gradle)
-    implementation(libs.detekt.gradlePlugin)
-    implementation(gradleApi())
 }
 
 repositories {

buildSrc/src/main/kotlin/mihon.android.application.compose.gradle.kts

@@ -1,4 +1,3 @@
-import mihon.buildlogic.AndroidConfig
 import mihon.buildlogic.configureCompose
 
 plugins {

buildSrc/src/main/kotlin/mihon/buildlogic/AndroidConfig.kt

@@ -1,11 +1,15 @@
 package mihon.buildlogic
 
 import org.gradle.api.JavaVersion as GradleJavaVersion
+import org.jetbrains.kotlin.gradle.dsl.JvmTarget as KotlinJvmTarget
 
 object AndroidConfig {
     const val COMPILE_SDK = 34
     const val TARGET_SDK = 34
     const val MIN_SDK = 26
     const val NDK = "26.1.10909125"
+
+    // https://youtrack.jetbrains.com/issue/KT-66995/JvmTarget-and-JavaVersion-compatibility-for-easier-JVM-version-setup
     val JavaVersion = GradleJavaVersion.VERSION_17
+    val JvmTarget = KotlinJvmTarget.JVM_17
 }

buildSrc/src/main/kotlin/mihon/buildlogic/ProjectExtensions.kt

@@ -8,9 +8,12 @@ import org.gradle.accessors.dm.LibrariesForLibs
 import org.gradle.api.Project
 import org.gradle.api.tasks.testing.Test
 import org.gradle.api.tasks.testing.logging.TestLogEvent
+import org.gradle.kotlin.dsl.configure
 import org.gradle.kotlin.dsl.dependencies
+import org.gradle.kotlin.dsl.provideDelegate
 import org.gradle.kotlin.dsl.the
 import org.gradle.kotlin.dsl.withType
+import org.jetbrains.kotlin.compose.compiler.gradle.ComposeCompilerGradlePluginExtension
 import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
 
 val Project.androidx get() = the<LibrariesForAndroidx>()
@@ -37,15 +40,18 @@ internal fun Project.configureAndroid(commonExtension: CommonExtension<*, *, *,
     }
 
     tasks.withType<KotlinCompile>().configureEach {
-        kotlinOptions {
-            jvmTarget = AndroidConfig.JavaVersion.toString()
-            // freeCompilerArgs += "-opt-in=kotlin.RequiresOptIn"
-            // freeCompilerArgs += "-Xcontext-receivers"
+        compilerOptions {
+            jvmTarget.set(AndroidConfig.JvmTarget)
+            freeCompilerArgs.addAll(
+                "-opt-in=kotlin.RequiresOptIn",
+                "-Xcontext-receivers",
+            )
 
             // Treat all Kotlin warnings as errors (disabled by default)
             // Override by setting warningsAsErrors=true in your ~/.gradle/gradle.properties
-            // val warningsAsErrors: String? by project
-            // allWarningsAsErrors = warningsAsErrors.toBoolean()
+            val warningsAsErrors: String? by project
+            allWarningsAsErrors.set(warningsAsErrors.toBoolean())
+
         }
     }
 
@@ -55,51 +61,41 @@ internal fun Project.configureAndroid(commonExtension: CommonExtension<*, *, *,
 }
 
 internal fun Project.configureCompose(commonExtension: CommonExtension<*, *, *, *, *, *>) {
+    pluginManager.apply(kotlinx.plugins.compose.compiler.get().pluginId)
+
     commonExtension.apply {
         buildFeatures {
             compose = true
         }
 
-        composeOptions {
-            kotlinCompilerExtensionVersion = compose.versions.compiler.get()
-        }
-
         dependencies {
             "implementation"(platform(compose.bom))
         }
     }
 
-    tasks.withType<KotlinCompile>().configureEach {
-        kotlinOptions {
-            freeCompilerArgs += buildComposeMetricsParameters()
+    extensions.configure<ComposeCompilerGradlePluginExtension> {
+        // Enable strong skipping mode
+        enableStrongSkippingMode.set(true)
 
-            // Enable experimental compiler opts
-            // https://developer.android.com/jetpack/androidx/releases/compose-compiler#1.5.9
-            freeCompilerArgs += listOf(
-                "-P",
-                "plugin:androidx.compose.compiler.plugins.kotlin:nonSkippingGroupOptimization=true",
-            )
+        // Enable experimental compiler opts
+        // https://developer.android.com/jetpack/androidx/releases/compose-compiler#1.5.9
+        enableNonSkippingGroupOptimization.set(true)
+
+        val enableMetrics = project.providers.gradleProperty("enableComposeCompilerMetrics").orNull.toBoolean()
+        val enableReports = project.providers.gradleProperty("enableComposeCompilerReports").orNull.toBoolean()
+
+        val rootProjectDir = rootProject.layout.buildDirectory.asFile.get()
+        val relativePath = projectDir.relativeTo(rootDir)
+        if (enableMetrics) {
+            val buildDirPath = rootProjectDir.resolve("compose-metrics").resolve(relativePath)
+            metricsDestination.set(buildDirPath)
+        }
+        if (enableReports) {
+            val buildDirPath = rootProjectDir.resolve("compose-reports").resolve(relativePath)
+            reportsDestination.set(buildDirPath)
         }
     }
-}
 
-private fun Project.buildComposeMetricsParameters(): List<String> {
-    val rootProjectDir = rootProject.layout.buildDirectory.asFile.get()
-    val relativePath = projectDir.relativeTo(rootDir)
-
-    val enableMetrics = project.providers.gradleProperty("enableComposeCompilerMetrics").orNull.toBoolean()
-    val enableReports = project.providers.gradleProperty("enableComposeCompilerReports").orNull.toBoolean()
-
-    return listOfNotNull(
-        ("metricsDestination" to "compose-metrics").takeIf { enableMetrics },
-        ("reportsDestination" to "compose-reports").takeIf { enableReports },
-    ).flatMap { (flag, dirName) ->
-        val buildDirPath = rootProjectDir.resolve(dirName).resolve(relativePath).absolutePath
-        listOf(
-            "-P",
-            "plugin:androidx.compose.compiler.plugins.kotlin:$flag=$buildDirPath"
-        )
-    }
 }
 
 internal fun Project.configureTest() {

data/build.gradle.kts

@@ -33,7 +33,7 @@ dependencies {
 
 tasks {
     withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile> {
-        kotlinOptions.freeCompilerArgs += listOf(
+        compilerOptions.freeCompilerArgs.addAll(
             "-Xcontext-receivers",
             "-opt-in=kotlinx.serialization.ExperimentalSerializationApi",
         )

domain/build.gradle.kts

@@ -31,7 +31,7 @@ dependencies {
 
 tasks {
     withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile> {
-        kotlinOptions.freeCompilerArgs += listOf(
+        compilerOptions.freeCompilerArgs.addAll(
             "-opt-in=kotlinx.coroutines.ExperimentalCoroutinesApi",
             "-Xcontext-receivers",
         )

gradle/compose.versions.toml

@@ -1,11 +1,8 @@
 [versions]
-compiler = "1.5.14"
-compose-bom = "2024.05.00-alpha02"
-accompanist = "0.35.0-alpha"
+compose-bom = "2024.05.00-alpha03"
+accompanist = "0.35.1-alpha"
 
 [libraries]
-compiler = { module = "androidx.compose.compiler:compiler", version.ref = "compiler" }
-
 activity = "androidx.activity:activity-compose:1.9.0"
 bom = { group = "dev.chrisbanes.compose", name = "compose-bom", version.ref = "compose-bom" }
 foundation = { module = "androidx.compose.foundation:foundation" }

gradle/kotlinx.versions.toml

@@ -1,11 +1,12 @@
 [versions]
-kotlin_version = "1.9.24"
-serialization_version = "1.6.3"
+kotlin_version = "2.0.0"
+serialization_version = "1.7.0"
 xml_serialization_version = "0.86.3"
 
 [libraries]
 reflect = { module = "org.jetbrains.kotlin:kotlin-reflect", version.ref = "kotlin_version" }
 gradle = { module = "org.jetbrains.kotlin:kotlin-gradle-plugin", version.ref = "kotlin_version" }
+compose-compiler-gradle = { module = "org.jetbrains.kotlin:compose-compiler-gradle-plugin", version.ref = "kotlin_version" }
 
 immutables = { module = "org.jetbrains.kotlinx:kotlinx-collections-immutable", version = "0.3.7" }
 
@@ -28,4 +29,5 @@ serialization = ["serialization-json", "serialization-json-okio", "serialization
 
 [plugins]
 android = { id = "org.jetbrains.kotlin.android", version.ref = "kotlin_version" }
+compose-compiler = { id = "org.jetbrains.kotlin.plugin.compose", version.ref = "kotlin_version" }
 serialization = { id = "org.jetbrains.kotlin.plugin.serialization", version.ref = "kotlin_version" }

gradle/libs.versions.toml

@@ -2,7 +2,7 @@
 aboutlib_version = "11.2.1"
 leakcanary = "2.14"
 moko = "0.23.0"
-okhttp_version = "5.0.0-alpha.12"
+okhttp_version = "5.0.0-alpha.14"
 richtext = "0.20.0"
 shizuku_version = "12.2.0"
 sqldelight = "2.0.2"
@@ -91,7 +91,7 @@ sqldelight-dialects-sql = { module = "app.cash.sqldelight:sqlite-3-38-dialect",
 sqldelight-gradle = { module = "app.cash.sqldelight:gradle-plugin", version.ref = "sqldelight" }
 
 junit = "org.junit.jupiter:junit-jupiter:5.10.2"
-kotest-assertions = "io.kotest:kotest-assertions-core:5.9.0"
+kotest-assertions = "io.kotest:kotest-assertions-core:5.9.1"
 mockk = "io.mockk:mockk:1.13.11"
 
 voyager-navigator = { module = "cafe.adriel.voyager:voyager-navigator", version.ref = "voyager" }

i18n/build.gradle.kts

@@ -50,7 +50,7 @@ tasks {
     }
 
     withType<KotlinCompile> {
-        kotlinOptions.freeCompilerArgs += listOf(
+        compilerOptions.freeCompilerArgs.addAll(
             "-Xexpect-actual-classes",
         )
     }

presentation-core/build.gradle.kts

@@ -34,7 +34,7 @@ dependencies {
 tasks {
     // See https://kotlinlang.org/docs/reference/experimental.html#experimental-status-of-experimental-api(-markers)
     withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile> {
-        kotlinOptions.freeCompilerArgs += listOf(
+        compilerOptions.freeCompilerArgs.addAll(
             "-opt-in=androidx.compose.foundation.layout.ExperimentalLayoutApi",
             "-opt-in=androidx.compose.material.ExperimentalMaterialApi",
             "-opt-in=androidx.compose.material3.ExperimentalMaterial3Api",

presentation-core/src/main/java/tachiyomi/presentation/core/components/material/PullRefresh.kt

@@ -22,7 +22,7 @@ import androidx.compose.ui.unit.dp
 @Composable
 fun PullRefresh(
     refreshing: Boolean,
-    enabled: () -> Boolean,
+    enabled: Boolean,
     onRefresh: () -> Unit,
     modifier: Modifier = Modifier,
     indicatorPadding: PaddingValues = PaddingValues(0.dp),
@@ -36,7 +36,7 @@ fun PullRefresh(
                 state = state,
                 enabled = enabled,
                 onRefresh = onRefresh,
-            )
+            ),
     ) {
         content()
 

source-api/build.gradle.kts

@@ -38,7 +38,7 @@ android {
 
 tasks {
     withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile> {
-        kotlinOptions.freeCompilerArgs += listOf(
+        compilerOptions.freeCompilerArgs.addAll(
             "-Xexpect-actual-classes",
         )
     }

source-local/build.gradle.kts

@@ -40,7 +40,7 @@ android {
 
 tasks {
     withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile> {
-        kotlinOptions.freeCompilerArgs += listOf(
+        compilerOptions.freeCompilerArgs.addAll(
             "-Xexpect-actual-classes",
             "-opt-in=kotlinx.serialization.ExperimentalSerializationApi",
         )

source-local/src/androidMain/kotlin/tachiyomi/source/local/LocalSource.kt

@@ -7,6 +7,7 @@ import eu.kanade.tachiyomi.source.Source
 import eu.kanade.tachiyomi.source.UnmeteredSource
 import eu.kanade.tachiyomi.source.model.FilterList
 import eu.kanade.tachiyomi.source.model.MangasPage
+import eu.kanade.tachiyomi.source.model.Page
 import eu.kanade.tachiyomi.source.model.SChapter
 import eu.kanade.tachiyomi.source.model.SManga
 import eu.kanade.tachiyomi.util.lang.compareToCaseInsensitiveNaturalOrder
@@ -20,17 +21,17 @@ import mihon.core.common.extensions.toZipFile
 import nl.adaptivity.xmlutil.AndroidXmlReader
 import nl.adaptivity.xmlutil.serialization.XML
 import tachiyomi.core.common.i18n.stringResource
-import tachiyomi.core.metadata.comicinfo.COMIC_INFO_FILE
-import tachiyomi.core.metadata.comicinfo.ComicInfo
-import tachiyomi.core.metadata.comicinfo.copyFromComicInfo
-import tachiyomi.core.metadata.comicinfo.getComicInfo
-import tachiyomi.core.metadata.tachiyomi.MangaDetails
 import tachiyomi.core.common.storage.extension
 import tachiyomi.core.common.storage.nameWithoutExtension
 import tachiyomi.core.common.storage.openReadOnlyChannel
 import tachiyomi.core.common.util.lang.withIOContext
 import tachiyomi.core.common.util.system.ImageUtil
 import tachiyomi.core.common.util.system.logcat
+import tachiyomi.core.metadata.comicinfo.COMIC_INFO_FILE
+import tachiyomi.core.metadata.comicinfo.ComicInfo
+import tachiyomi.core.metadata.comicinfo.copyFromComicInfo
+import tachiyomi.core.metadata.comicinfo.getComicInfo
+import tachiyomi.core.metadata.tachiyomi.MangaDetails
 import tachiyomi.domain.chapter.service.ChapterRecognition
 import tachiyomi.domain.manga.model.Manga
 import tachiyomi.i18n.MR
@@ -294,7 +295,7 @@ actual class LocalSource(
     override fun getFilterList() = FilterList(OrderBy.Popular(context))
 
     // Unused stuff
-    override suspend fun getPageList(chapter: SChapter) = throw UnsupportedOperationException("Unused")
+    override suspend fun getPageList(chapter: SChapter): List<Page> = throw UnsupportedOperationException("Unused")
 
     fun getFormat(chapter: SChapter): Format {
         try {