mirror/mihon
1
0
Fork 0
mirror of https://github.com/mihonapp/mihon.git synced 2024-11-10 12:47:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

Avoid throw as it is slow expensive operations

Browse Source
This commit is contained in:
quangkieu 2022-03-10 15:20:37 -05:00 committed by arkon
parent 1613d561c1
commit 9547311d7d
1 changed files with 25 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateService.kt
View File

@ -313,16 +313,18 @@ class LibraryUpdateService(
manga, manga,
) { manga -> ) { manga ->
try { try {
if (MANGA_NON_COMPLETED in restrictions && manga.status == SManga.COMPLETED) { when {
throw SkipUpdateException(getString(R.string.skipped_reason_completed)) MANGA_NON_COMPLETED in restrictions && manga.status == SManga.COMPLETED -> {
skippedUpdates.add(manga to getString(R.string.skipped_reason_completed))
} }
if (MANGA_HAS_UNREAD in restrictions && manga.unreadCount != 0) { MANGA_HAS_UNREAD in restrictions && manga.unreadCount != 0 -> {
throw SkipUpdateException(getString(R.string.skipped_reason_not_caught_up)) skippedUpdates.add(manga to getString(R.string.skipped_reason_not_caught_up))
} }
if (MANGA_NON_READ in restrictions && manga.totalChapters > 0 && !manga.hasStarted) { MANGA_NON_READ in restrictions && manga.totalChapters > 0 && !manga.hasStarted -> {
throw SkipUpdateException(getString(R.string.skipped_reason_not_started)) skippedUpdates.add(manga to getString(R.string.skipped_reason_not_started))
} }
else -> {
// Convert to the manga that contains new chapters
val (newChapters, _) = updateManga(manga) val (newChapters, _) = updateManga(manga)
if (newChapters.isNotEmpty()) { if (newChapters.isNotEmpty()) {
@ -337,8 +339,8 @@ class LibraryUpdateService(
.toTypedArray() .toTypedArray()
) )
} }
} catch (e: SkipUpdateException) { }
skippedUpdates.add(manga to e.message) }
} catch (e: Throwable) { } catch (e: Throwable) {
val errorMessage = when (e) { val errorMessage = when (e) {
is NoChaptersException -> { is NoChaptersException -> {
@ -587,5 +589,3 @@ class LibraryUpdateService(
private const val MANGA_PER_SOURCE_QUEUE_WARNING_THRESHOLD = 60 private const val MANGA_PER_SOURCE_QUEUE_WARNING_THRESHOLD = 60
private const val ERROR_LOG_HELP_URL = "https://tachiyomi.org/help/guides/troubleshooting" private const val ERROR_LOG_HELP_URL = "https://tachiyomi.org/help/guides/troubleshooting"
private class SkipUpdateException(override val message: String) : RuntimeException()