Merge branch 'master' of https://github.com/AlexandreRouma/SDRPlusPlus

.github/workflows/build_all.yml

@@ -93,8 +93,8 @@ jobs:
         - name: Update brew repositories
           run: brew update
 
-        - name: Fix python
-          run: rm -f /usr/local/bin/2to3* /usr/local/bin/idle3* /usr/local/bin/pydoc3* /usr/local/bin/python3* /usr/local/bin/python3-config*
+        - name: Fix stuff
+          run: rm -f /usr/local/bin/2to3* /usr/local/bin/idle3* /usr/local/bin/pydoc3* /usr/local/bin/python3* /usr/local/bin/python3-config* && brew reinstall gettext
 
         - name: Install dependencies
           run: brew install libusb fftw glfw airspy airspyhf portaudio hackrf rtl-sdr libbladerf codec2 zstd && pip3 install mako

misc_modules/recorder/src/wav.cpp

@@ -130,6 +130,7 @@ namespace wav {
 
         // Validate samplerate
         if (!samplerate) { throw std::runtime_error("Samplerate must be non-zero"); }
+        _samplerate = samplerate;
     }
 
     void Writer::setFormat(Format format) {
@@ -179,4 +180,4 @@ namespace wav {
         // Increment sample counter
         samplesWritten += count;
     }
-}
+}

readme.md

@@ -407,9 +407,8 @@ To solve, this, simply downgrade to libusb1.3
 
 ## SDR++ crashes when starting a HackRF
 
-If you also have the SoapySDR module loaded (not necessarily enabled), this is a bug in libhackrf. It's caused by libhackrf not checking if it's already initialized.
-The solution until a fixed libhackrf version is released is to completely remove the soapy_source module from SDR++. To do this, delete `modules/soapy_source.dll` on windows
-or `/usr/lib/sdrpp/plugins/soapy_source.so` on linux.
+If you also have the SoapySDR module enabled, this is a bug in libhackrf. It's caused by libhackrf not checking if it's already initialized.
+The solution until a fixed libhackrf version is released is to disable the soapy_source module from SDR++. For this, go into the "Module Manager" menu and click the `-` button next to the row with "soapy_source". After that, restart SDR++.
 
 ## Issue not listed here?