2 Commits

Author SHA1 Message Date
Bazsalanszky
f9a0e0e70d Fix CRASH on starting a foreground service
Starting from android target 34, we need to set a foreground service type. In my opinion, the dataSync one fits best for us.
2024-07-21 11:49:17 +02:00
Bazsalanszky
3d3285d1ee Fix CRASH on CommentActivity 2024-07-21 11:49:17 +02:00
2 changed files with 8 additions and 2 deletions

View File

@@ -17,6 +17,7 @@
android:name="android.permission.WRITE_EXTERNAL_STORAGE"
android:maxSdkVersion="22" />
<uses-permission android:name="android.permission.FOREGROUND_SERVICE" />
<uses-permission android:name="android.permission.FOREGROUND_SERVICE_DATA_SYNC"/>
<uses-permission-sdk-23
android:name="android.permission.WRITE_EXTERNAL_STORAGE"
@@ -158,6 +159,7 @@
<service
android:name=".services.DownloadMediaService"
android:enabled="true"
android:foregroundServiceType="dataSync"
android:exported="false" />
<activity
@@ -175,6 +177,7 @@
<service
android:name=".services.DownloadRedditVideoService"
android:enabled="true"
android:foregroundServiceType="dataSync"
android:exported="false" />
<activity
@@ -537,10 +540,12 @@
<service
android:name=".services.SubmitPostService"
android:enabled="true"
android:foregroundServiceType="dataSync"
android:exported="false" />
<service
android:name=".services.EditProfileService"
android:enabled="true"
android:foregroundServiceType="dataSync"
android:exported="false" />
<receiver android:name=".broadcastreceivers.DownloadedMediaDeleteActionBroadcastReceiver" />

View File

@@ -204,6 +204,9 @@ public class CommentActivity extends BaseActivity implements UploadImageEnabledA
builder.linkColor(linkColor);
}
};
mGlide = Glide.with(getApplication());
Markwon postBodyMarkwon = MarkdownUtils.createFullRedditMarkwon(this,
miscPlugin, parentTextColor, parentSpoilerBackgroundColor, mGlide, null, mSharedPreferences.getBoolean(SharedPreferencesUtils.DISABLE_IMAGE_PREVIEW, false));
MarkwonAdapter markwonAdapter = MarkdownUtils.createTablesAdapter();
@@ -226,8 +229,6 @@ public class CommentActivity extends BaseActivity implements UploadImageEnabledA
setSupportActionBar(binding.commentToolbar);
mGlide = Glide.with(getApplication());
if (savedInstanceState != null) {
selectedAccount = savedInstanceState.getParcelable(SELECTED_ACCOUNT_STATE);
uploadedImages = savedInstanceState.getParcelableArrayList(UPLOADED_IMAGES_STATE);