From 4ca9b065516a6f6799aab6842d419e9f22f8dfa0 Mon Sep 17 00:00:00 2001 From: Alex Ning Date: Mon, 12 Aug 2019 09:50:25 +0800 Subject: [PATCH] Fixed UI in dark theme. --- .../infinityforreddit/ViewPostDetailActivity.java | 4 ---- app/src/main/res/layout/activity_view_post_detail.xml | 1 + app/src/main/res/layout/item_comment.xml | 3 ++- .../main/res/layout/item_load_more_comments_placeholder.xml | 3 ++- app/src/main/res/layout/item_post_detail.xml | 3 ++- app/src/main/res/values-night/colors.xml | 2 ++ app/src/main/res/values/colors.xml | 2 ++ 7 files changed, 11 insertions(+), 7 deletions(-) diff --git a/app/src/main/java/ml/docilealligator/infinityforreddit/ViewPostDetailActivity.java b/app/src/main/java/ml/docilealligator/infinityforreddit/ViewPostDetailActivity.java index 8ef11517..f96301b3 100644 --- a/app/src/main/java/ml/docilealligator/infinityforreddit/ViewPostDetailActivity.java +++ b/app/src/main/java/ml/docilealligator/infinityforreddit/ViewPostDetailActivity.java @@ -6,7 +6,6 @@ import android.content.res.Configuration; import android.content.res.Resources; import android.os.Build; import android.os.Bundle; -import android.util.Log; import android.view.Menu; import android.view.MenuItem; import android.view.View; @@ -354,9 +353,6 @@ public class ViewPostDetailActivity extends AppCompatActivity { ViewPostDetailActivity.this.children = children; comments = expandedComments; - if(comments != null) { - Log.i("thisis ", "not null"); - } hasMoreChildren = children.size() != 0; mAdapter.addComments(expandedComments, hasMoreChildren); diff --git a/app/src/main/res/layout/activity_view_post_detail.xml b/app/src/main/res/layout/activity_view_post_detail.xml index 3a010dc3..9c4a811c 100644 --- a/app/src/main/res/layout/activity_view_post_detail.xml +++ b/app/src/main/res/layout/activity_view_post_detail.xml @@ -5,6 +5,7 @@ android:id="@+id/coordinator_layout_view_post_detail" android:layout_width="match_parent" android:layout_height="match_parent" + android:background="@color/cardViewBackgroundColor" tools:application=".ViewPostDetailActivity"> + android:layout_height="wrap_content" + android:background="@color/cardViewBackgroundColor"> + android:layout_height="wrap_content" + android:background="@color/cardViewBackgroundColor"> + android:orientation="vertical" + android:background="@color/cardViewBackgroundColor"> @color/tabLayoutWithCollapsedCollapsingToolbarTextColor @color/backgroundColor + + #242424 diff --git a/app/src/main/res/values/colors.xml b/app/src/main/res/values/colors.xml index 8b9eb013..9d88ac4f 100644 --- a/app/src/main/res/values/colors.xml +++ b/app/src/main/res/values/colors.xml @@ -43,4 +43,6 @@ @color/tabLayoutWithCollapsedCollapsingToolbarTextColor #FFFFFF + + #FFFFFF